Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 13:48:24 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Costa Shulyupin <costa.shul@redhat.com>
Cc:     Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        Daniel Bristot de Oliveira <bristot@kernel.org>,
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] docs: move tracing tools
Message-ID: <20230425134824.5d57c431@gandalf.local.home>
In-Reply-To: <20230425130231.912349-1-costa.shul@redhat.com>
References: <20230425130231.912349-1-costa.shul@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Apr 2023 16:02:30 +0300
Costa Shulyupin <costa.shul@redhat.com> wrote:

> from list of development tools to user tools
> because these tools work on running kernel
> and are invoked from user mode

Wait what? No!

The trace/ directory has a lot that is kernel internal only. Yes, it may
explain how user space can interact with it, but it's also how internal
kernel processes can use the ftrace infrastructure, and also explains a lot
of the kernel design of that code.

NACK!

-- Steve


> 
> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
> ---
>  Documentation/index.rst       | 1 -
>  Documentation/tools/index.rst | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/index.rst b/Documentation/index.rst
> index 9dfdc826618c..81e1af951731 100644
> --- a/Documentation/index.rst
> +++ b/Documentation/index.rst
> @@ -56,7 +56,6 @@ Various other manuals with useful information for all kernel developers.
>     dev-tools/index
>     dev-tools/testing-overview
>     kernel-hacking/index
> -   trace/index
>     fault-injection/index
>     livepatch/index
>     rust/index
> diff --git a/Documentation/tools/index.rst b/Documentation/tools/index.rst
> index 80488e290e10..6a9a44f7f88a 100644
> --- a/Documentation/tools/index.rst
> +++ b/Documentation/tools/index.rst
> @@ -12,6 +12,7 @@ more additions are needed here:
>  
>     rtla/index
>     rv/index
> +   ../trace/index
>  
>  .. only::  subproject and html
>