Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Apr 2023 11:08:02 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH] kbuild: deb-pkg: specify targets in debian/rules as
 .PHONY
Message-ID: <20230425180802.GA2881732@dev-arch.thelio-3990X>
References: <20230425110859.1757001-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425110859.1757001-1-masahiroy@kernel.org>
Precedence: bulk

On Tue, Apr 25, 2023 at 08:08:59PM +0900, Masahiro Yamada wrote:
> If a file with the same name exists, the target is not run.
> 
> For example, the following command fails.
> 
>   $ make O=build-arch bindeb-pkg
>     [ snip ]
>   sed: can't read modules.order: No such file or directory
>   make[6]: *** [../Makefile:1577: __modinst_pre] Error 2
>   make[5]: *** [../scripts/Makefile.package:150: intdeb-pkg] Error 2
>   make[4]: *** [../Makefile:1657: intdeb-pkg] Error 2
>   make[3]: *** [debian/rules:14: binary-arch] Error 2
>   dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
>   make[2]: *** [../scripts/Makefile.package:139: bindeb-pkg] Error 2
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
>  scripts/package/mkdebian | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index a4c2c2276223..b6cb95473548 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -269,6 +269,8 @@ cat <<EOF > debian/rules
>  srctree ?= .
>  KERNELRELEASE = ${KERNELRELEASE}
>  
> +.PHONY: clean build build-arch build-indep binary binary-arch binary-indep
> +
>  build-indep:
>  build-arch:
>  	\$(MAKE) -f \$(srctree)/Makefile ARCH=${ARCH} \
> -- 
> 2.37.2
>