Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7367090rwr; Tue, 25 Apr 2023 11:52:28 -0700 (PDT) X-Google-Smtp-Source: AKy350a3coB4/0yG/vY+0G4DIY47gRqvrt1ZPkUkD/kS83oYBB2laySuIbPcny6k2EYhWrAlo6Z8 X-Received: by 2002:a17:902:d4c4:b0:1a1:b656:2149 with SMTP id o4-20020a170902d4c400b001a1b6562149mr23202733plg.50.1682448747593; Tue, 25 Apr 2023 11:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682448747; cv=none; d=google.com; s=arc-20160816; b=v7dvIQxXppYAm8OBC8pUc6M/Z/2ifjIvSjF8VURNL77qrRXAoWXcaKELy0aGuEEu/2 IUEFPJGTOHTtzz84FAx2aeCywiFxbFvHw6S2+/zl2rmle8BcDkm7FpzC4pLVE4+zxHTj xotSfjttUEUhXSk3h7JN6TmmZduCxn8RYcWdiNLkd1LVvW0QDxt+oAUb6CVxs5R07psf 9FecJq5EYvGdo/kt4i9PKffrTwt94X+BAdzvAPWFmUrYl0nZp/gPqSzTCQbD3Us7x3ok ctQFdAfxP5O9fk66OxcHZJhU5D2EVm+cr4ZK1rGJz115HX3af0s7U4oTcLiFVT16X2pH kzSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=zhKy/+ejuXue7alxdJMuNxsTX5eKJNWbTH8CrXSTa84=; b=lqasDEobxk97FczEJA5E2KyovZ92gyA0jT74x7e6O35ctf2nS+2EAnGd5L8HMCm2YK /MgufKnhv0PEk+udLocPtuHZJOT6wXjEnIKBvm6k5bqmW51Wek8Z0PAaH9CK14CLH/jj Reo4i2BL4//hShaHBYPDiQ/ZIvilqTAruT9qLGyNLw5joJBO6IwiQjis5rmnun6tWkC5 eK5YocWuF+GpD/L+EpVcUJ9kiMrHZGir87Th9Qx3MjSMGHfUYUWLkMw6bXYQ97RUGlkJ 5JptECklbUwZbBWYIPXQhsJGMG2avkB9xulviojU4tt2FP+vHi+RE/WFW8jE5qE3tBBs w+fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FzWcsXkY; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a17090b011200b0024695095bb3si1302516pjz.189.2023.04.25.11.52.14; Tue, 25 Apr 2023 11:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=FzWcsXkY; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234541AbjDYSua (ORCPT + 99 others); Tue, 25 Apr 2023 14:50:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234879AbjDYStx (ORCPT ); Tue, 25 Apr 2023 14:49:53 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BECE17DE4 for ; Tue, 25 Apr 2023 11:49:25 -0700 (PDT) Message-ID: <20230425183313.724863461@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1682448563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=zhKy/+ejuXue7alxdJMuNxsTX5eKJNWbTH8CrXSTa84=; b=FzWcsXkY1rn6uaAzMResVDXYjyP3/75Gm3AlbAbLScxnrzNQbyeAyakrbAnFEXjoRxOiKR EQzIN5Dy516lyfpbSO5ze45rXikk7Wjz2CLM9gRRwjh0Di5+FHkq2vntYK+FYfvC445OCB lsKKzZUm5sRrIX3N/S0gnc8OfHc4WZZ0Cw+SkHUG6o2NPrkmIrSwMYqridkN0m95LXFsEm PvvieaC/KzoUhuSbMvngusxe8b6Uw7DfQ5uFS5di7HmLdrshUJ/lOGqJlMzLbfYgJepjSb ZgaKzxxQJq+hzuArqrdDG84kxZPSIR9RZNmdWdQHnwtf28TiFFfChAkof/2EBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1682448563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=zhKy/+ejuXue7alxdJMuNxsTX5eKJNWbTH8CrXSTa84=; b=DmBsE9o+vRUolZwlSEo+qjOxgYPNJwct0Q5CIFDNXIRpYEMpHwuOHxnLLr6wupwhsjrc5m Sgid4XCkrlMWq/CQ== From: Thomas Gleixner To: LKML Cc: Frederic Weisbecker , Anna-Maria Behnsen , Peter Zijlstra , Sebastian Siewior , syzbot+5c54bd3eb218bb595aa9@syzkaller.appspotmail.com, Dmitry Vyukov , Michael Kerrisk Subject: [patch 17/20] posix-timers: Clarify posix_timer_rearm() comment References: <20230425181827.219128101@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Tue, 25 Apr 2023 20:49:22 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yet another incomprehensible piece of art. Signed-off-by: Thomas Gleixner --- kernel/time/posix-timers.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -274,15 +274,9 @@ static void common_hrtimer_rearm(struct } /* - * This function is exported for use by the signal deliver code. It is - * called just prior to the info block being released and passes that - * block to us. It's function is to update the overrun entry AND to - * restart the timer. It should only be called if the timer is to be - * restarted (i.e. we have flagged this in the sys_private entry of the - * info block). - * - * To protect against the timer going away while the interrupt is queued, - * we require that the it_requeue_pending flag be set. + * This function is called from the signal delivery code if + * info->si_sys_private is not zero, which indicates that the timer has to + * be rearmed. Restart the timer and update info::si_overrun. */ void posixtimer_rearm(struct kernel_siginfo *info) {