Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230421040218.2156548-1-davidgow@google.com> <20230421040218.2156548-4-davidgow@google.com>
In-Reply-To: <20230421040218.2156548-4-davidgow@google.com>
From:   Rae Moar <rmoar@google.com>
Date:   Tue, 25 Apr 2023 15:11:04 -0400
Message-ID: <CA+GJov4+-u3fnqDWCgsp8EjGkm2efbqtaqMFq+_0pWpTnfkurw@mail.gmail.com>
Subject: Re: [PATCH v3 4/4] kunit: example: Provide example exit functions
To:     David Gow <davidgow@google.com>
Cc:     Benjamin Berg <benjamin@sipsolutions.net>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Daniel Latypov <dlatypov@google.com>, maxime@cerno.tech,
        Stephen Boyd <sboyd@kernel.org>, kunit-dev@googlegroups.com,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sadiya Kazi <sadiyakazi@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 21, 2023 at 12:02=E2=80=AFAM David Gow <davidgow@google.com> wr=
ote:
>
> Add an example .exit and .suite_exit function to the KUnit example
> suite. Given exit functions are a bit more subtle than init functions
> (due to running in a different kthread, and running even after tests or
> test init functions fail), providing an easy place to experiment with
> them is useful.
>
> Signed-off-by: David Gow <davidgow@google.com>

Hi David!

I have reviewed this patch and the overall changes to the cleanup
structure. It looks good to me (other than that kernel test robot
error). Nice to see an example of how to use exit functions in our
example test.

Thanks!
-Rae

Reviewed-by: Rae Moar <rmoar@google.com>

> ---
>
> This patch was introduced in v3.
>
> ---
>  lib/kunit/kunit-example-test.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/lib/kunit/kunit-example-test.c b/lib/kunit/kunit-example-tes=
t.c
> index cd8b7e51d02b..24315c882b31 100644
> --- a/lib/kunit/kunit-example-test.c
> +++ b/lib/kunit/kunit-example-test.c
> @@ -41,6 +41,16 @@ static int example_test_init(struct kunit *test)
>         return 0;
>  }
>
> +/*
> + * This is run once after each test case, see the comment on
> + * example_test_suite for more information.
> + */
> +static void example_test_exit(struct kunit *test)
> +{
> +       kunit_info(test, "cleaning up\n");
> +}
> +
> +
>  /*
>   * This is run once before all test cases in the suite.
>   * See the comment on example_test_suite for more information.
> @@ -52,6 +62,16 @@ static int example_test_init_suite(struct kunit_suite =
*suite)
>         return 0;
>  }
>
> +/*
> + * This is run once after all test cases in the suite.
> + * See the comment on example_test_suite for more information.
> + */
> +static void example_test_exit_suite(struct kunit_suite *suite)
> +{
> +       kunit_info(suite, "exiting suite\n");
> +}
> +
> +
>  /*
>   * This test should always be skipped.
>   */
> @@ -211,7 +231,9 @@ static struct kunit_case example_test_cases[] =3D {
>  static struct kunit_suite example_test_suite =3D {
>         .name =3D "example",
>         .init =3D example_test_init,
> +       .exit =3D example_test_exit,
>         .suite_init =3D example_test_init_suite,
> +       .suite_exit =3D example_test_exit_suite,
>         .test_cases =3D example_test_cases,
>  };
>
> --
> 2.40.0.634.g4ca3ef3211-goog
>