Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa38f7a8e6f60753d5cb7f8949263f435cf613ec.camel@kernel.org>
Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode
 i_m/ctime
From:   Jeff Layton <jlayton@kernel.org>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     NeilBrown <neilb@suse.de>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dave Chinner <david@fromorbit.com>,
        Chuck Lever <chuck.lever@oracle.com>, Jan Kara <jack@suse.cz>,
        Amir Goldstein <amir73il@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        linux-nfs@vger.kernel.org
Date:   Tue, 25 Apr 2023 15:12:30 -0400
In-Reply-To: <ZEgUSw15g4Wbo91Z@casper.infradead.org>
References: <20230424151104.175456-1-jlayton@kernel.org>
         <20230424151104.175456-2-jlayton@kernel.org>
         <168237287734.24821.11016713590413362200@noble.neil.brown.name>
         <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org>
         <168237601955.24821.11999779095797667429@noble.neil.brown.name>
         <aa60b0fa23c1d582cfad0da5b771d427d00c4316.camel@kernel.org>
         <ZEgUSw15g4Wbo91Z@casper.infradead.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-04-25 at 18:56 +0100, Matthew Wilcox wrote:
> On Tue, Apr 25, 2023 at 01:45:19PM -0400, Jeff Layton wrote:
> > Erm...it may be an unpopular opinion, but I find that more confusing
> > than just ensuring that the s_time_gran > 1. I keep wondering if we
> > might want to carve out other low-order bits too for some later purpose=
,
> > at which point trying to check this using flags wouldn't work right. I
> > think I might just stick with what I have here, at least for now.
>=20
> But what if I set s_time_gran to 3 or 5?  You'd really want a warning
> about that.

Ugh, I hadn't considered that. I don't see anyone that sets an odd
s_time_gran that isn't 1, but OK, good point. I'll change it.
--=20
Jeff Layton <jlayton@kernel.org>