Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7417771rwr; Tue, 25 Apr 2023 12:40:44 -0700 (PDT) X-Google-Smtp-Source: AKy350YDTd3kslLFonuWm7lHWoWuu7RGo278pdeIfZAssrDKl1lhK+fp6bEDGVg5oh926GPHK1aE X-Received: by 2002:a17:902:d549:b0:1a6:b191:9208 with SMTP id z9-20020a170902d54900b001a6b1919208mr19073763plf.10.1682451643664; Tue, 25 Apr 2023 12:40:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682451643; cv=none; d=google.com; s=arc-20160816; b=ooCPzIw7Oh3pDB5C3TJwi/ha8PUcEeC2h/otEp2wIOHnNQ5rJLt9Xo5jhgyVH+SkWt yZ1+YjkCQf7huqvGnxX75GrNGyhLPTTwn5KgaN+CIBn/zyJOHHg/IAR2DbnDSmK/IdYP QfflJ+nsjek9Hp6GRlqGw8P3v8/nDRVT3y8qsJoYeEvW5t5HBQsEpjbyyJbBaBTenisN vTviQq/fExHrdcc3099euSaasu4xsyAec6kfyC5CYfNpZriqKVoFlam2mM4hNYU5mVOQ qaPnoOjr03lWlknGQvb8T7rzwVwqvOFPjYWEXSO8IosuVAtL9UCvYC1Wo3WGOwRnyZDK 46Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dtDpwhH/eF7nujITf5tyXIA/HB8iR8Wmip3v0q2BBSY=; b=HaYZR8gVIGJ2AHbgRuhfn4BjYMWo5e74E8TVOmim5HzJw1WDWIENT4MgYK0nqqZIPn xKAc8760ud5oqj+16dm39/oNyzGj2ZEZXDDkP/GA6CX/dlJpvXTsb0+/I4FH1NxHDZWo zJHQ7F5mbLijGkOodaeehApQH66ltAIw8x6nva3U2OT9LnUwhq4TRupq+oxa7cWnRv7h /w3qms/Y0EiVQYif7TXLidSOmoh7Fg8xtUOSZ3NAnpgi1CMvktsaDsoTgiPbNcy9yqbx hGg8EFAHL+spu8m/FoXUpLrfR8lhdH0qxVDL7dIADwXiYvQmx3hP6iYAXbb+Rtbnjkr+ 9e9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NZ1kbLWi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u10-20020a17090341ca00b001a63d8efabasi15046930ple.445.2023.04.25.12.40.20; Tue, 25 Apr 2023 12:40:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NZ1kbLWi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234754AbjDYTjq (ORCPT + 99 others); Tue, 25 Apr 2023 15:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234523AbjDYTjT (ORCPT ); Tue, 25 Apr 2023 15:39:19 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4211A72A9 for ; Tue, 25 Apr 2023 12:39:18 -0700 (PDT) Received: from zn.tnic (p5de8e8ea.dip0.t-ipconnect.de [93.232.232.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 82E981EC04CC; Tue, 25 Apr 2023 21:39:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1682451556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=dtDpwhH/eF7nujITf5tyXIA/HB8iR8Wmip3v0q2BBSY=; b=NZ1kbLWitUL7dZCwT98uleHuQpLdEpKwrZvGhXP3lvgx1stZMKWG7QFSUF1ToRRw0T9GLf gGUxHzxNgonV1Tigds6meySi+463XrAGXaYfUnS6RkJQI0zn2EB8FUeB1Y3ccaluYahtTu w4zIYqJ8bHDP3UkQka58P5djpNtGVF0= Date: Tue, 25 Apr 2023 21:39:12 +0200 From: Borislav Petkov To: Tony Battersby Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mario Limonciello , Tom Lendacky , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC] x86/cpu: fix intermittent lockup on poweroff Message-ID: <20230425193912.GEZEgsYDAsLn0EBAcH@fat_crate.local> References: <3817d810-e0f1-8ef8-0bbd-663b919ca49b@cybernetics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3817d810-e0f1-8ef8-0bbd-663b919ca49b@cybernetics.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2023 at 03:26:53PM -0400, Tony Battersby wrote: > In stop_this_cpu(), make sure the CPUID leaf exists before accessing the > leaf. This fixes a lockup on poweroff 50% of the time due to the wrong > branch being taken randomly on some CPUs (seen on Supermicro X8DTH-6F > with Intel Xeon X5650). Please send the output of cpuid -r from that machine. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette