Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230425202848.261139-1-amiculas@cisco.com>
In-Reply-To: <20230425202848.261139-1-amiculas@cisco.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Tue, 25 Apr 2023 22:37:57 +0200
Message-ID: <CANiq72kXa-SgRiVhvjU7X4fa8XSJB4po9xf_V4L6Gn2o+t6T+Q@mail.gmail.com>
Subject: Re: [PATCH] rust: Sort rust/helpers.c's #include directives
To:     Ariel Miculas <ariel.miculas@gmail.com>
Cc:     rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
        boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
        benno.lossin@proton.me, Ariel Miculas <amiculas@cisco.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ariel,

On Tue, Apr 25, 2023 at 10:28=E2=80=AFPM Ariel Miculas <ariel.miculas@gmail=
.com> wrote:
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@cisco.com>

First of all, thanks for the patch!

These tags look OK, but if you want to attribute the patches to your
Cisco address, could you please send them from that address?

Also, the commit description is missing. In the kernel, we give the
rationale for a change and describe what the patch does for every
commit.

Please take a look at `Documentation/process/submitting-patches.rst`
and try `scripts/checkpatch.pl` -- it can point some issues like this.

> +/*
> + * Sorted alphabetically.
> + */

Please join this comment with the top one, i.e. please do not open a
new /* */ block, like it is done in the other file mentioned in the
linked issue.

Cheers,
Miguel