Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp28783rwr; Tue, 25 Apr 2023 17:03:40 -0700 (PDT) X-Google-Smtp-Source: AKy350ZGm/6DiaMy8jfe7xtATCpK+HIM7B86yWkiNxz4KwaRQkEq8alO9vDOCeFIqULl52Fx/dtD X-Received: by 2002:a17:902:cec9:b0:1a9:581d:3efb with SMTP id d9-20020a170902cec900b001a9581d3efbmr16980339plg.6.1682467419827; Tue, 25 Apr 2023 17:03:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682467419; cv=none; d=google.com; s=arc-20160816; b=bKdePQwWRObGWYpKagfTIKiugeekIXk+xMS1Msin8Gqam8pQnjQQ0HMcg/kDytaBBS +5kOiEyNzOnT7JgZx6oFeRDO7WhSOGENXuZjrHG3+9lA/dCmBCENlmsDqXWwBgxPDTVO 6dj3a9eUncG84vUGLjCZV8v3ggFq7zk+uFS1ykQrkaR7z/LKSqDbywq57n2E+8K2RqKE dyh3JjckXyuzhKMyRGzSBZwu3B8AMhRfJTOcJ6ASl/90I7/FY3J3uuhbnT5D/gemVHs+ G6VHqOwqUHdtII/IMlL93Gmqye3m68PV4IrWFGnViB3fmdLG6eNju+LiA5MWnHOaZQXt phiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=yRVhWkMKZivSpY0wYZD5uOa2bgROjQL/7zymO21uVoA=; b=JOpV2Y3n9kDtSKJLnmJ3hXXcIdiUsdYgacxMsmuXHp945ZtijzIrApzEy/2GCdC7JX 4aLMwqoYd9uqzCTYfMB4bx3119jVG6DRyd3/m4YG5/n15xTbxyrHnpkTEFx7yV52O4WV lJ3BUNrSV6rsAyK5h4twJ7APkMNkk3f0wqz1EDD2DbALsV6kJclGRHf7ZRdtGWXXVm9r DaXqySNz38Kbx0TxIJDMG2FN0DJMG2wttXP9Oxwi1AdHNK/VLg7RSKIAY1MgFlI4g75z P7gs2kQYhC2r9d4Xpi7VeHtLR/axaxl9+wgSd01KflEHAgPea+RFj7uShUu3C+gUIl9/ hI6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q392l+x2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a170902f2d100b001a80c0abba4si13677531plc.184.2023.04.25.17.03.25; Tue, 25 Apr 2023 17:03:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q392l+x2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236800AbjDZADV (ORCPT + 99 others); Tue, 25 Apr 2023 20:03:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238022AbjDZADT (ORCPT ); Tue, 25 Apr 2023 20:03:19 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 903C9B238 for ; Tue, 25 Apr 2023 17:03:18 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5051abd03a7so9559800a12.2 for ; Tue, 25 Apr 2023 17:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682467397; x=1685059397; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yRVhWkMKZivSpY0wYZD5uOa2bgROjQL/7zymO21uVoA=; b=Q392l+x2KFNeu6328CzD7ySXVmsmaQZSDPTzVKkT5LIuOezJrWV9PDyEMrxKw0YxPE HSxgggHrHReqIDvIZwqAHVj7I1O0J9AcPOksU1hapxAimTs0a5bgaCKXE0c/X5KND4yV Lpkr8Hiz8E+VA3rsCwHn5H3xDdT2ZU4Mpb/uPcDR6FhG/D8jvyugBzvRVe+bAKh66Cpa QKqn+ZERvvV6irIYXlXn03VmobsoaIERy4fTMvfyOhPI/JVQWSG/9SmqBbUYqnbn2zBx 3UI/mDvQTGmjnhMNABfDyLcan0yQasK/8UIACwilLkh+B+wWxMUyejpXcFWO/9IqJvu8 x0iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682467397; x=1685059397; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yRVhWkMKZivSpY0wYZD5uOa2bgROjQL/7zymO21uVoA=; b=EU3fMbvS2fmhBlhSKAC9b5QwMzmt+q/hzn4Qe+CLHwejuPT7crJcFHXIq3Aiuko+ND 1z56Mc1uGm+Kgx1nt0TXtEp92wWA6DY4dfbWr30QYTjinNroo+h8Hg3ZGFnDgbOp9+s+ /1oGdvPMcliV8TifJ9oEnm4Y2aIgG9+vHkHgivquAnqHLOUJhJ5/M74g4ii+AWTtQjt9 m6W95XwfQX3aqkBRaAsf0hsJY1iBJMXidb7fX+iXUywYoyWn1qcHNqyeJHW7ycvQhN8Z WCYwd7+gdur8ZRDTWUK31q27L+BbcSq9MtdGcTsQpS42BH8N0gEV3bzpLQakrVV8FopP C6dA== X-Gm-Message-State: AAQBX9dCaVcne/EcCQYGVJ9ut+XoC/o8/Zq79Ov/Iu4Ez1zaOQ6s10yp Y1sgWhNo2+OvUikZ70Jn9LPaJA== X-Received: by 2002:a17:907:7888:b0:94e:6f2d:d1c9 with SMTP id ku8-20020a170907788800b0094e6f2dd1c9mr14666185ejc.68.1682467397106; Tue, 25 Apr 2023 17:03:17 -0700 (PDT) Received: from [172.23.2.4] ([31.221.30.162]) by smtp.gmail.com with ESMTPSA id kw15-20020a170907770f00b0094f8ff0d899sm7294372ejc.45.2023.04.25.17.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 17:03:16 -0700 (PDT) Message-ID: Date: Wed, 26 Apr 2023 03:03:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 10/21] drm/msm/dpu: Take INTF index as parameter in interrupt register defines Content-Language: en-GB To: Marijn Suijten , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Adam Skladowski , Loic Poulain , Bjorn Andersson , Kuogee Hsieh , Robert Foss , Vinod Koul , Neil Armstrong Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Jessica Zhang References: <20230411-dpu-intf-te-v3-0-693b17fe6500@somainline.org> <20230411-dpu-intf-te-v3-10-693b17fe6500@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20230411-dpu-intf-te-v3-10-693b17fe6500@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2023 02:06, Marijn Suijten wrote: > Instead of hardcoding many register defines for every INTF and AD4 index > with a fixed stride, turn the defines into singular chunks of math that > compute the address using the base and this fixed stride multiplied by > the index given as argument to the definitions. > > MDP_SSPP_TOP0_OFF is dropped as that constant is zero anyway, and all > register offsets related to it live in dpu_hwio.h. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Marijn Suijten > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 156 ++++++++++------------ > 1 file changed, 72 insertions(+), 84 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry