Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp146042rwr; Tue, 25 Apr 2023 19:17:53 -0700 (PDT) X-Google-Smtp-Source: AKy350YigHeKY6gwTPLar7QqiR5XqQTCcgu3bV8tapjDx5411/z7/mv/n+qmI6U8YAwuYhMmhWAw X-Received: by 2002:a05:6a21:33a2:b0:f4:7cbd:c236 with SMTP id yy34-20020a056a2133a200b000f47cbdc236mr12873766pzb.54.1682475473515; Tue, 25 Apr 2023 19:17:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682475473; cv=none; d=google.com; s=arc-20160816; b=h6P5KxxiZ0xQHifwCi9MhmafkyaBAId8X7fNKewH8vH4RsYzdFKssgskY7LkkE618I NW20XVX8ie1aykH1VRZk80Nlct30n1LCtN1fRI9btKc/FI6XEp4aSCNeQJEIJL6Zc6KY RR03MFsI2Zr+fbY10qIbXboCOLJ1LPeoBdj4Ra3b19cBPMvyMAi9Sfd5snmyamxNPRpR bXK7jQFggIoGbGxXwH93qtyY5YU0gpds4yJED8oIVPLOQo3qMWPJIppI/lp0Hr4JBvlc PxlM/omswCMGtB9kNPjSZaqk9bVy888D1tK1LwEexkfmzFYQlPIIvYzU2s06J25CHUNk owRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=ZXJMaNtnClCBQl2QpWiYVcrZCXn/yphN5DEoDwXoEGY=; b=iqlU3bjix7KCAreMywcX+WSItgCqyxmoSkonETxe4o1+wH/7xy0mLEeaSvNAZwjx8J KxWfQGnJqp+XJ9xPrrQoXCLfIIxaIgYiocdnQepFOtok2me+KczVFRnZs9Yt5IOg1K5i U9FkjYVDUi9HytTpBqelwkp8ql2O6FojyO2omeduA0ofy4+yWh8i7icRRVRmq5c+wjLk 8EnlG1bdPIta9KxgNzCggjZyv1puc6SEO8kt3Ik1T8Ru0qlcDblx9YjDzc2A6g8n9vCg Sg7AV/Z2cazQlCCiuGnVfiTzWjGIQQBcj1/Lf0OS8blahRFlnr0kabkNigWCCgocXg+n 4syw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x64-20020a626343000000b0063b84b28922si10374713pfb.153.2023.04.25.19.17.40; Tue, 25 Apr 2023 19:17:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239089AbjDZCLz (ORCPT + 99 others); Tue, 25 Apr 2023 22:11:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238440AbjDZCLy (ORCPT ); Tue, 25 Apr 2023 22:11:54 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 295868699; Tue, 25 Apr 2023 19:11:52 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id B16BC24DF03; Wed, 26 Apr 2023 10:11:50 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 26 Apr 2023 10:11:50 +0800 Received: from [192.168.125.106] (113.72.145.137) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 26 Apr 2023 10:11:49 +0800 Message-ID: Date: Wed, 26 Apr 2023 10:11:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support To: Conor Dooley CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , "Krzysztof Kozlowski" , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> <0988495f-b87a-7f69-f222-37c67d6eae23@starfivetech.com> <20230425-resale-footrest-de667778c4fe@wendy> <663e9933-b9b3-a48f-98b6-2207215a8ed7@starfivetech.com> <20230425-commotion-prewashed-876247bed4ab@spud> Content-Language: en-US From: Changhuang Liang In-Reply-To: <20230425-commotion-prewashed-876247bed4ab@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.137] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/26 0:56, Conor Dooley wrote: > On Tue, Apr 25, 2023 at 08:26:35PM +0800, Changhuang Liang wrote: >> On 2023/4/25 17:35, Conor Dooley wrote: >>> On Tue, Apr 25, 2023 at 05:18:10PM +0800, Changhuang Liang wrote: >>>> On 2023/4/25 16:19, Krzysztof Kozlowski wrote: >>>>> On 25/04/2023 09:57, Changhuang Liang wrote: >>>>>> Yes, "starfive,jh7110-aon-pmu" is a child-node of "starfive,jh7110-aon-syscon". >>>>>> In my opinion, "0x17010000" is "aon-syscon" on JH7110 SoC, and this "aon-pmu" is just >>>>>> a part of "aon-syscon" function, so I think it is inappropriate to make "aon-syscon" >>>>>> to a power domain controller. I think using the child-node description is closer to >>>>>> JH7110 SoC. >>>>> >>>>> Unfortunately, I do not see the correlation between these, any >>>>> connection. Why being a child of syscon block would mean that this >>>>> should no be power domain controller? Really, why? These are two >>>>> unrelated things. >>>> >>>> Let me summarize what has been discussed above. >>>> >>>> There has two ways to describe this "starfive,jh7110-aon-syscon"(0x17010000). >>>> 1. (0x17010000) is power-controller node: >>>> >>>> aon_pwrc: power-controller@17010000 { >>>> compatible = "starfive,jh7110-aon-pmu", "syscon"; >>>> reg = <0x0 0x17010000 0x0 0x1000>; >>>> #power-domain-cells = <1>; >>>> }; >>>> >>>> >>>> 2. (0x17010000) is syscon node, power-controller is child-node of syscon: >>>> >>>> aon_syscon: syscon@17010000 { >>>> compatible = "starfive,jh7110-aon-syscon", "syscon", "simple-mfd"; >>>> reg = <0x0 0x17010000 0x0 0x1000>; >>>> >>>> aon_pwrc: power-controller { >>>> compatible = "starfive,jh7110-aon-pmu"; >>>> #power-domain-cells = <1>; >>>> }; >>>> }; >>> >>> I thought that Rob was suggesting something like this: >>> aon_syscon: syscon@17010000 { >>> compatible = "starfive,jh7110-aon-syscon", ... >>> reg = <0x0 0x17010000 0x0 0x1000>; >>> #power-domain-cells = <1>; >>> }; > >> I see the kernel: >> https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/mediatek/mt8167.dtsi >> this file line 42: >> it's power-controller also has no meaningful properties. >> What do you think? > > I'm not sure that I follow. It has a bunch of child-nodes does it not, > each of which is a domain? > > I didn't see such domains in your dts patch, they're defined directly in > the driver instead AFAIU. Assuming I have understood that correctly, > your situation is different to that mediatek one? > > Cheers, > Conor. I think there child-nodes just need to operate some clock signals. Maybe we don't need to discuss other platforms. If Rob's method is confirmed. I will try it next version. Maybe like this: aon_syscon: syscon@17010000 { compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"; reg = <0x0 0x17010000 0x0 0x1000>; #power-domain-cells = <1>; }; Rob and krzystof: And I think patch[1][2] need to change. Right? [1] https://lore.kernel.org/all/20230414024157.53203-6-xingyu.wu@starfivetech.com/ [2] https://lore.kernel.org/all/20230414024157.53203-7-xingyu.wu@starfivetech.com/