Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp194252rwr; Tue, 25 Apr 2023 20:20:34 -0700 (PDT) X-Google-Smtp-Source: AKy350ZuVTwtlhANqIvoi+PXisNVTClAoxke8d0SNHEcvAvx5Oi4RzAdgIffFoK+5FKgp7t+ANwp X-Received: by 2002:aa7:88d1:0:b0:63b:89a9:529f with SMTP id k17-20020aa788d1000000b0063b89a9529fmr25803370pff.14.1682479233845; Tue, 25 Apr 2023 20:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682479233; cv=none; d=google.com; s=arc-20160816; b=yAxmZhyt6kNKtR91o945qhkJ0+PNigAFGYa6UM7IYY2uDLoY8MpI143q2a5VuRq/dl tl5mzoWLLc54huonuehlo2g98KyL7A7F7qpuIDbRrTXQ6q1MVHsKvSlrSfkqJ5b5HN1M 0yhq99pg54Y+PVotkzI8D9fcFwDvdPmTPwMdU+6QM2HAAy+krChNI09C7hgj2dmmxA+u P9Lz0/dilwXAYWQwGZBuAFYChrXeEyLc7f0ULakdExhTiTwbACBs3fesE9/ZsZ5m1We3 iAKAHkOIQhetH+SuCb2ODP+i0goYxKzB5HxbH6np2ezNC/YIQO9lKDDNAokk4R81wBX8 EBdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mLbw8h8f7wqiF4USb8jBZXhWjOdVD5lS3bdaC03Zf48=; b=oOpOK4+eM+2yfV6pVG0itwMHqXA7ANGvOkYVRW1ui+Am/HZIUtgyYSDbJzxfQtNS1W mGAOWTpJKNcVVkropI4CHwGakDXdsZnV5mMIMy1rnS4WTzZFSlhjiS9nV6IxDKMBS53v zn/P/BswVuPNjNQACspfW1PDrCaN5de2JHygPQLJwhr3b5GBhrdsIMevxRtWE/5Mp9Yj DpEqdeZNvQEkxmFSdUgF9/a498H+P+koHO73PMjUaJm82iGUJEtJW8hk3R7+vn/x5OYS 2MDLmwpiLtRz/f9RrF65P4GUfsCwP736BK729toNqkyne8dKIQ3HQofazywZS+3Q24OA pd8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b0050bebc3e35bsi9969856pgq.766.2023.04.25.20.20.17; Tue, 25 Apr 2023 20:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239026AbjDZDSo (ORCPT + 99 others); Tue, 25 Apr 2023 23:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238440AbjDZDSl (ORCPT ); Tue, 25 Apr 2023 23:18:41 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE300E8 for ; Tue, 25 Apr 2023 20:18:40 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id 4F0E0E1CFB; Wed, 26 Apr 2023 11:18:39 +0800 (CST) From: Yang Yang To: mingo@redhat.com Cc: surenb@google.com, hannes@cmpxchg.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, yang.yang29@zte.com.cn, peterz@infradead.org Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger Date: Wed, 26 Apr 2023 11:18:39 +0800 Message-Id: <20230426031839.14910-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=3.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_NON_FQDN_1, HEADER_FROM_DIFFERENT_DOMAINS,HELO_NO_DOMAIN,NO_DNS_FOR_FROM, RCVD_IN_PBL,RDNS_NONE,SPF_SOFTFAIL,SPOOFED_FREEMAIL_NO_RDNS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Mon, Apr 17, 2023 at 1:12 AM wrote: >> >> From: Yang Yang >> >> Psi_group's poll_min_period is determined by the min window size of >> psi_trigger when creating new triggers. While destroying a psi_trigger, >> there is no need to reset poll_min_period if the destroying psi_trigger >> not had the min windows size, since in this condition poll_min_period >> will keep the same as before. > > Nice optimization. > >> Signed-off-by: Yang Yang > Acked-by: Suren Baghdasaryan Hi, would you please take a review? Thanks!