Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp197597rwr; Tue, 25 Apr 2023 20:25:03 -0700 (PDT) X-Google-Smtp-Source: AKy350Z+8/vFISjMdnkQc5yCgd4RK5nxtzUx1YWNLU+VOuRAjbmPlltJ4mmM2QoVhy9j40wMKWAB X-Received: by 2002:a05:6a00:c85:b0:625:efa4:4c01 with SMTP id a5-20020a056a000c8500b00625efa44c01mr28434278pfv.3.1682479502955; Tue, 25 Apr 2023 20:25:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682479502; cv=none; d=google.com; s=arc-20160816; b=dnxfsXupZF8iv4FUncA7SaaMQqECLKF1m8bisPU6jeCzaC+sJHDWZ2muVw3ZxJ0YaO YEdAMN2YyjCvaOqu8aBiWSc9yq7kd637wNlA7F4od5jZbb2D3SxWLHfLksevkSbyJnzN 5sBFsRmxO6nHqeiFHQ6THY/WONlbDF+nTu6hEA+xyQ51zFBFn3FkjblAMavbbZO3QK+U 4N7JLKUjIVT+6h6FtDGo1MKkBtUZ3ddYqLXCnV/2x8uACXzCbUkWW+awLsUa+JvRUqUJ +v18StJ+0gE6sYVvdJbC/IOPJYkoLsq+r2YgADAFUEMhTKc8rSlvolh88nqikHtAu7XG /tdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mLbw8h8f7wqiF4USb8jBZXhWjOdVD5lS3bdaC03Zf48=; b=oQJdrqEM+ewADJ8Oo7djq7c+X0oId1m7qYzkHK9chVzy83Tc1VM2hbEcaoELW4Xlyr imyHRK7A0KaNKEmBvpm+yPxoMYYywhnJ0D059scBE98q7DxApOLhcHNewQGd4W+IAhSz viZXG0bHd/kLjxp8uFb14MPTXh5cNZEydpuv0htkdDJi603Y90KBZReaO/68oAggwxGM p3zpmjh472NJbee9NhuGX0q8fccCSObCh4RrjHQHGxEV83Ud6csNyNY+oSLFHawiqEa5 VPke+IiIK8jAKRxdrqZcC53Y1tmB9nvv1oh1iWeqpegnp/+iBwVqcrP2Kl2FFMl+UFft k5fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020aa79493000000b005e1cabb612fsi15159185pfk.67.2023.04.25.20.24.50; Tue, 25 Apr 2023 20:25:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238586AbjDZDXG (ORCPT + 99 others); Tue, 25 Apr 2023 23:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbjDZDXD (ORCPT ); Tue, 25 Apr 2023 23:23:03 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D310E5E for ; Tue, 25 Apr 2023 20:23:02 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id D0EE8E1CFB; Wed, 26 Apr 2023 11:23:00 +0800 (CST) From: Yang Yang To: mingo@redhat.com Cc: surenb@google.com, hannes@cmpxchg.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, yang.yang29@zte.com.cn, peterz@infradead.org Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger Date: Wed, 26 Apr 2023 11:23:00 +0800 Message-Id: <20230426032300.14980-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=3.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_NON_FQDN_1, HEADER_FROM_DIFFERENT_DOMAINS,HELO_NO_DOMAIN,NO_DNS_FOR_FROM, RCVD_IN_PBL,RDNS_NONE,SPF_SOFTFAIL,SPOOFED_FREEMAIL_NO_RDNS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Mon, Apr 17, 2023 at 1:12 AM wrote: >> >> From: Yang Yang >> >> Psi_group's poll_min_period is determined by the min window size of >> psi_trigger when creating new triggers. While destroying a psi_trigger, >> there is no need to reset poll_min_period if the destroying psi_trigger >> not had the min windows size, since in this condition poll_min_period >> will keep the same as before. > > Nice optimization. > >> Signed-off-by: Yang Yang > Acked-by: Suren Baghdasaryan Hi, would you please take a review? Thanks!