Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp232892rwr; Tue, 25 Apr 2023 21:13:38 -0700 (PDT) X-Google-Smtp-Source: AKy350ZNkfUu7zSPLZ8AH5MSvgbh8etfvO/tqBlrvvxZv76MXnTt+hA8+/k2smD3QvOQ7Ld5d3Nl X-Received: by 2002:a17:90a:b398:b0:24b:5bea:410c with SMTP id e24-20020a17090ab39800b0024b5bea410cmr18037621pjr.7.1682482418273; Tue, 25 Apr 2023 21:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682482418; cv=none; d=google.com; s=arc-20160816; b=kwanOCZa5eIWLoXO/354L+bftGlGm5T3xTDdefhSepOazI2bfimcY7BUsvhp2F+57l BrbEoSLJ8h/DraIF7Y5X1G9LTqoOCsdfQzVYukf2Tq3uaWngi+ITT2X/zcG/pdqXf3qL Y+cF77TJgD36qJgvVuYfl1Jvu7J7sbIvBUb3QbOBxjIZ5JMNGMnCgWj0dZa4/LimTnEh xz+hXhlkJS8TyisAqgbB5AhzcY859Tr/BjHgEFy2+lIsqfnoU/lZ4BeV6eShbEuczOqZ /je4P3fYfCu58ThRIVgsY1uD+HWbM23zI9a2So8TPoyMj4YVER00e8+Pr8+S6GnoK6zB 66lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=W99rPUCYlG00bJwRAw5TP1hzeJQnq5TF0t/UIVJTxB8=; b=KRQUJUMIMZyzRi4irUv6kGRx5fga4Ax5Vgv6oCpv4pXpUUsHvZpRFmRvjSv5ye2vU8 vEiHVevva4OFH3nmySzV5wmsRiIZ1p41BrxnSFjUJQCtvk3yQfm1gSJQRm7o5K/E+A/T 1fqw3EItarGnqhBQBytkGhVk5D/+GhnHp/UL190ibg/FBcwEpa0eIA3FctuZ8E1wwjWR NBqiy4owpQ3c9lCEv+C4ZLpU8fgc3yVgcRP4uapAd664efmQl2uvubpcBesJkmW2FyoI HOTa3i6/h2DbaIX+ZQn1DQ8eUZqMd1kTfUVHEJdNfsq04mr1cmqjzNIV3GKwLnn9iNTo IeIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a170902cccb00b001a506617ab4si14888659ple.27.2023.04.25.21.13.24; Tue, 25 Apr 2023 21:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239321AbjDZDcG (ORCPT + 99 others); Tue, 25 Apr 2023 23:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239185AbjDZDcC (ORCPT ); Tue, 25 Apr 2023 23:32:02 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C911BE6 for ; Tue, 25 Apr 2023 20:31:45 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id 8B592E1CFB; Wed, 26 Apr 2023 11:31:44 +0800 (CST) From: Yang Yang To: mingo@redhat.com Cc: surenb@google.com, hannes@cmpxchg.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, yang.yang29@zte.com.cn, peterz@infradead.org Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger Date: Wed, 26 Apr 2023 11:31:44 +0800 Message-Id: <20230426033144.15106-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=3.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_NON_FQDN_1, HEADER_FROM_DIFFERENT_DOMAINS,HELO_NO_DOMAIN,NO_DNS_FOR_FROM, RCVD_IN_PBL,RDNS_NONE,SPF_SOFTFAIL,SPOOFED_FREEMAIL_NO_RDNS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Apr 17, 2023 at 1:12 AM wrote: >> >> From: Yang Yang >> >> Psi_group's poll_min_period is determined by the min window size of >> psi_trigger when creating new triggers. While destroying a psi_trigger, >> there is no need to reset poll_min_period if the destroying psi_trigger >> not had the min windows size, since in this condition poll_min_period >> will keep the same as before. > > Nice optimization. > >> >> Signed-off-by: Yang Yang > > Acked-by: Suren Baghdasaryan Hi, would you please take a review? Thanks!