Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAJuCfpFiW7z01FTC2q3hR+h=MhWLwKj96U+MF3s_FjX-9JEqfw@mail.gmail.com>
 <20230426033144.15106-1-yang.yang29@zte.com.cn>
In-Reply-To: <20230426033144.15106-1-yang.yang29@zte.com.cn>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Tue, 25 Apr 2023 22:08:24 -0700
Message-ID: <CAJuCfpF88Xu_Xf3w5oM4xRmXphwGjMaLhusEHV7gtAFNXXnP2A@mail.gmail.com>
Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min
 update period when destroy trigger
To:     Yang Yang <yang.yang29@zte.com.cn>
Cc:     mingo@redhat.com, hannes@cmpxchg.org, juri.lelli@redhat.com,
        linux-kernel@vger.kernel.org, peterz@infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 25, 2023 at 8:32=E2=80=AFPM Yang Yang <yang.yang29@zte.com.cn> =
wrote:
>
> > On Mon, Apr 17, 2023 at 1:12=E2=80=AFAM <yang.yang29@zte.com.cn> wrote:
> >>
> >> From: Yang Yang <yang.yang19@zte.com.cn>
> >>
> >> Psi_group's poll_min_period is determined by the min window size of
> >> psi_trigger when creating new triggers. While destroying a psi_trigger=
,
> >> there is no need to reset poll_min_period if the destroying psi_trigge=
r
> >> not had the min windows size, since in this condition poll_min_period
> >> will keep the same as before.
> >
> > Nice optimization.
> >
> >>
> >> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> >
> > Acked-by: Suren Baghdasaryan <surenb@google.com>
>
> Hi, would you please take a review?

I guess this is a ping for PeterZ to queue this patch in his tree.
Peter, any issues with accepting this patch?

> Thanks!