Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <478d993b-3011-f335-139e-1f98db6f6b00@marcan.st>
Date:   Wed, 26 Apr 2023 14:21:45 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] ACPI / property: Support strings in Apple _DSM props
Content-Language: en-US
To:     Lukas Wunner <lukas@wunner.de>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, asahi@lists.kernel.dev,
        Linus Walleij <linus.walleij@linaro.org>
References: <20230424-acpi-prop-v1-1-ffa9a300b1cd@marcan.st>
 <20230424202030.GA19243@wunner.de>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20230424202030.GA19243@wunner.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/04/2023 05.20, Lukas Wunner wrote:
> On Mon, Apr 24, 2023 at 03:46:57PM +0900, Hector Martin wrote:
>> The Wi-Fi module in x86 Apple machines has a "module-instance" device
>> property that specifies the platform type and is used for firmware
>> selection. Its value is a string, so add support for string values in
>> acpi_extract_apple_properties().
>>
>> Reviewed-by: Lukas Wunner <lukas@wunner.de>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
> 
> I was about to review this when I spotted my Reviewed-by tag above.
> Turns out this was first submitted 16 months ago.  Wow, time flies!
> 
> https://lore.kernel.org/all/20211226182012.GA5527@wunner.de/

Yup, the original series was never merged and I've been pushing the
brcmfmac bits piecewise over time instead... and then I completely
forgot about this patch, which turns out to (now) be the last missing
piece for WiFi to work on Apple T2 Macs :).

- Hector