Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp410316rwr; Wed, 26 Apr 2023 00:41:05 -0700 (PDT) X-Google-Smtp-Source: AKy350baD6BQngomyiySJaMwPkxbHVjxXls4azLe2biLFi4uIPzIhwbGeuDfowqUXPPVvhABfUI4 X-Received: by 2002:a05:6a20:1449:b0:d6:91f5:2b10 with SMTP id a9-20020a056a20144900b000d691f52b10mr24419387pzi.58.1682494865072; Wed, 26 Apr 2023 00:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682494865; cv=none; d=google.com; s=arc-20160816; b=O4XgMWDHFRsrNaOZuozW2eQuryyTWagJKlKYm3NsmJkEK0cfEUBA2qgp1OoEGmo833 RkozsnMhj/PTcr/si8BYZOno6w+MVhL7SMQ6oiExGdzlNRARQCzttsQq1Ljhkf3oG8tB /MXzEmv/9oXTNDjBe/8/f03cw/VgEmCBHvhENSALocQi9BYUga2b5NX7/awHkvHRBA7I wDQld9ui5tWnNGZS4XujslIDJ3+QPu70PTfPaOQvl5wwCaKoYbAlCNg1azEcjcXBYWDC me4tgYbsqeVV/Iyd6TCovaBE7lj4GsSzlsZFRXCA/092heOCw3jv4pnKFGG/cN9wOMBf FXUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=RM8ysrYAecOJGrV4zwIlRbC929/Az6b+AMVj39NICDA=; b=o/x3VXDdlXenBHyHvnOjHIx3jMerBpYllnAySXVhNWmyXEINAKxfV1z9Cnm8BMksQB shoQ7QzksAT2DBKLMw0LHjTwnV+Y+BWn3W4pLPBr25VgUrV+w8s9jVhuttgmmepM2Z0G /4HDn4TJuDyGl06pbDcBVSkPUiOY78kNo47NQoMT6KyNftwFzf4JwgeT2/qAb90L5fJI FlZ9PuX8MXx2Eyz+Knkt2swU4XtFOJ96cGj5p4tJ7FT07JsFjGus+/d6csL5H3BBqwo8 fohkbg0EPlJGDxtEIHKi0xyAfSh5yn6ZKBfDocYtNmqGcmOXXqzWHfFbkW0RfGfiUbwr jJbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d24-20020a656218000000b00509461bbf1csi15759266pgv.79.2023.04.26.00.40.51; Wed, 26 Apr 2023 00:41:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239645AbjDZHcy (ORCPT + 99 others); Wed, 26 Apr 2023 03:32:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239379AbjDZHcw (ORCPT ); Wed, 26 Apr 2023 03:32:52 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35282701 for ; Wed, 26 Apr 2023 00:32:50 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prZds-0000C9-I5; Wed, 26 Apr 2023 09:32:44 +0200 Received: from pza by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1prZdr-0001IB-4x; Wed, 26 Apr 2023 09:32:43 +0200 Date: Wed, 26 Apr 2023 09:32:43 +0200 From: Philipp Zabel To: Christophe JAILLET Cc: Wim Van Sebroeck , Guenter Roeck , Steffen Trumtrar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH 1/2] watchdog: dw_wdt: Fix the error handling path of dw_wdt_drv_probe() Message-ID: <20230426073243.GA4724@pengutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: pza@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, On Wed, Apr 26, 2023 at 08:52:48AM +0200, Christophe JAILLET wrote: > The commit in Fixes has only updated the remove function and missed the > error handling path of the probe. > > Add the missing reset_control_assert() call. > > Fixes: 65a3b6935d92 ("watchdog: dw_wdt: get reset lines from dt") > Signed-off-by: Christophe JAILLET Reviewed-by: Philipp Zabel regards Philipp