Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp449305rwr; Wed, 26 Apr 2023 01:22:46 -0700 (PDT) X-Google-Smtp-Source: AKy350aztMvvopgTWNANDS7FeNTmLIBBFIj4P6dMBHHBcObcUXKfmJzSROj8woB3oW+Z2xLeWLp8 X-Received: by 2002:a05:6a20:d38c:b0:ec:7c4f:ed7a with SMTP id iq12-20020a056a20d38c00b000ec7c4fed7amr23338593pzb.34.1682497366627; Wed, 26 Apr 2023 01:22:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682497366; cv=none; d=google.com; s=arc-20160816; b=uLmwIOMUumbvKOqXFUbQ2XaUh5mHFPu+q4Ahez51CF54S5hfoWcFqn3M2z0tOD8F/4 T/iSVko8DsuMJgmVV++r5j/V/INBGr1KZ8VzvztmnZUMbEJG8gEAK3FbiccqUb2fpOpY RQfuqyCyEFalWeEEj1A9sIb2yhnm1F/HM4WfeonzXBUrTxM1BHr3uN57ZaeytWsJJ0cY XmwP3Y9OVJAHS3nRIsYRRoy0pTERwZno1flmVkPYbXp7D/asrNfN9aVFT3KdlwQuUEua N/T2kbSG8PeIMHOt+9epwORzc7+FxEgQJ/pPFqTIQ/QBzlhrDBaTc9Qev46Nhq+ArYLp At2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date; bh=o8WWAZWAG5f95RKmeZbqW4Ji9JUwfCQ9iJ9HhuQEg9c=; b=pXBlN4UcWnGjxaEmn4GinxU42GvP8CM/gxDoqli1HKzKU7c5JeMxoJYODT3XINDX5M FAxZr1HwnY5SSM+PWuAK7+MxTd0nE5iDmJUWQ89WI/rD8DwmYxzw5rn9kq/lFv9JsnEA nmOa8jYA6utpkyt19HXKTYD4OtNnEon+qxp3vZ35a3xgjRF2InPDr8dT0gq7HV+PKBpQ q/dmkBPcX1+7cww9v8okr4Z4dNcXE5L8BKs9sUsi0RC9uLVmpaoa8EstbkfYKYVJ6KGQ 0/TrK6N4jLodiC6gN5jezxBODZuwguI7mZxnD0u0jUGwRL28IaoZMHvQHVA5FnkMdO9p fcSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a631015000000b0050b51e62c1asi17104001pgl.63.2023.04.26.01.22.34; Wed, 26 Apr 2023 01:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239783AbjDZINf (ORCPT + 99 others); Wed, 26 Apr 2023 04:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239499AbjDZINd (ORCPT ); Wed, 26 Apr 2023 04:13:33 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA81510F8; Wed, 26 Apr 2023 01:13:31 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R861e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=wuzongyong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Vh2QehR_1682496808; Received: from localhost(mailfrom:wuzongyong@linux.alibaba.com fp:SMTPD_---0Vh2QehR_1682496808) by smtp.aliyun-inc.com; Wed, 26 Apr 2023 16:13:29 +0800 Date: Wed, 26 Apr 2023 16:13:27 +0800 From: Wu Zongyong To: lukas@wunner.de, sdonthineni@nvidia.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: wllenyj@linux.alibaba.com, wutu.xq2@linux.alibaba.com, gerry@linux.alibaba.com Subject: Re: [PATCH] PCI: Mark NVIDIA T4 GPUs to avoid bus reset Message-ID: <20230426081327.GA24855@L-PF27918B-1352.localdomain> Reply-To: Wu Zongyong References: <388bc353a5f88edb502ec04c0dc53ab62a526020.1680090885.git.wuzongyong@linux.alibaba.com> <2dcebea53a6eb9bd212ec6d8974af2e5e0333ef6.1681129861.git.wuzongyong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2dcebea53a6eb9bd212ec6d8974af2e5e0333ef6.1681129861.git.wuzongyong@linux.alibaba.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 10, 2023 at 08:34:11PM +0800, Wu Zongyong wrote: > NVIDIA T4 GPUs do not work with SBR. This problem is found when the T4 > card is direct attached to a Root Port only. So avoid bus reset by > marking T4 GPUs PCI_DEV_FLAGS_NO_BUS_RESET. > > Fixes: 4c207e7121fa ("PCI: Mark some NVIDIA GPUs to avoid bus reset") > Signed-off-by: Wu Zongyong > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44cab813bf95..be86b93b9e38 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3618,7 +3618,7 @@ static void quirk_no_bus_reset(struct pci_dev *dev) > */ > static void quirk_nvidia_no_bus_reset(struct pci_dev *dev) > { > - if ((dev->device & 0xffc0) == 0x2340) > + if ((dev->device & 0xffc0) == 0x2340 || dev->device == 0x1eb8) > quirk_no_bus_reset(dev); > } > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > -- > 2.34.3 Any further comments about this patch?