Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7a2c3f7-5a25-07ed-0c77-e87e40a7d88a@collabora.com>
Date:   Wed, 26 Apr 2023 10:46:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 3/4] arm64: dts: mediatek: cherry: Configure eDP and
 internal display
Content-Language: en-US
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     matthias.bgg@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, kernel@collabora.com
References: <20230424112523.1436926-1-angelogioacchino.delregno@collabora.com>
 <20230424112523.1436926-4-angelogioacchino.delregno@collabora.com>
 <CAGXv+5EHAGMYE7Z-n6Wtss-sXXa0Rvv=jkse2sqyTOtGYpqR-A@mail.gmail.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <CAGXv+5EHAGMYE7Z-n6Wtss-sXXa0Rvv=jkse2sqyTOtGYpqR-A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 25/04/23 10:24, Chen-Yu Tsai ha scritto:
> On Mon, Apr 24, 2023 at 7:25 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Add the required nodes to enable the DisplayPort interface, connected
>> to the Embedded DisplayPort port, where we have an internal display.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../boot/dts/mediatek/mt8195-cherry.dtsi      | 32 +++++++++++++++++++
>>   1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
>> index 4229f4f7dc2f..adbda4dccdd5 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
>> @@ -47,6 +47,18 @@ memory@40000000 {
>>                  reg = <0 0x40000000 0 0x80000000>;
>>          };
>>
>> +       pp3300_disp_x: regulator-pp3300-disp-x {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "pp3300_disp_x";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               enable-active-high;
>> +               gpio = <&pio 55 GPIO_ACTIVE_HIGH>;
>> +               pinctrl-names = "default";
>> +               pinctrl-0 = <&panel_fixed_pins>;
>> +               regulator-always-on;
> 
> I think you missed my comment on v1 about this regulator's supplier and
> enable delay.
> 

Sorry, it wasn't my intention to ignore that. Will check that out and
push a v3 asap.

> ChenYu
> 
>> +       };
>> +
>>          /* system wide LDO 3.3V power rail */
>>          pp3300_z5: regulator-pp3300-ldo-z5 {
>>                  compatible = "regulator-fixed";
>> @@ -288,6 +300,20 @@ port@1 {
>>                          reg = <1>;
>>                          edp_out: endpoint {
>>                                  data-lanes = <0 1 2 3>;
>> +                               remote-endpoint = <&panel_in>;
>> +                       };
>> +               };
>> +       };
>> +
>> +       aux-bus {
>> +               panel {
>> +                       compatible = "edp-panel";
>> +                       power-supply = <&pp3300_disp_x>;
>> +                       backlight = <&backlight_lcd0>;
>> +                       port {
>> +                               panel_in: endpoint {
>> +                                       remote-endpoint = <&edp_out>;
>> +                               };
>>                          };
>>                  };
>>          };
>> @@ -927,6 +953,12 @@ pins-cs {
>>                  };
>>          };
>>
>> +       panel_fixed_pins: panel-pwr-default-pins {
>> +               pins-vreg-en {
>> +                       pinmux = <PINMUX_GPIO55__FUNC_GPIO55>;
>> +               };
>> +       };
>> +
>>          pio_default: pio-default-pins {
>>                  pins-wifi-enable {
>>                          pinmux = <PINMUX_GPIO58__FUNC_GPIO58>;
>> --
>> 2.40.0
>>
>>