Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp564832rwr; Wed, 26 Apr 2023 03:24:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4IdZk40hYnjJuJNfxqBNSdYc+teQ7dB20BNCmz5/Ez4bvgT+rlIn5tBe0dFe1xRcHmFaCD X-Received: by 2002:a05:6a00:1945:b0:640:defd:a6de with SMTP id s5-20020a056a00194500b00640defda6demr11140790pfk.5.1682504655436; Wed, 26 Apr 2023 03:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682504655; cv=none; d=google.com; s=arc-20160816; b=fka2wMMllfCpp9ZILBaGbQaXyu2zN7bjVsVzjAGdRS8u6P4kr93UjI6XejAskyCNu2 YKooCxL53RmQA4ooyLtpygiSk7Nzn9CMV1SWy4DnFGtlqsJpGtq/Y6gtL6MI8aCruPfT t3OS+WPOkBz1EudUuYwDqzDRTZ2TBMwKKwerK8ieHl4wnZ8tDYrY3kjXcTZFWa8tbaYN wETTm6vSwwnhj6x0ngQc1W8OuDsK8T+PMEDWWYaV8kV584rqjqNx6tCqNDgGrZLiPqkr bsRrCDQHcEiU9WxSKOzXuHwoxeLF2uC9wDd+dkJsymlOGyyZnbWtkfbGh0tCZo/wjckx /PKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BzFp9UTkit55n4G1B1tLt+bHSM18YHNZYgQD7TIcCfw=; b=prYOsrnezK2s3ukBeOWoRKNY932V4X60Tns5pdwGy47TdBdFBy+T+GU7ZdBSiUe5Ae mQW9p/3ubEL4hVQFhhqreSbPumPKkShq8bSNvV7tpYZZpoZagOkNOd9KNWHOOU4JZzDl gQ4HntUK/xTby1a1OGiz7xeMmeRXub0oPOtHWTk+x5bJ4zk3ninewiI7stIWFBWAmzNE Zx59B2vvKNTPTgc49X2RehQ0Sx9gbBUvmoclEfitgBT0MhDXG06eVXgYhrTiiN95KSCf 2Ch51yWwBaevWVeCDL6vBVRTAypN+kkTFzlVxK+QsF1cktox1KYnwD+CeadpQAFcxbC8 dT9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ExC7kmQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v17-20020a634811000000b0051358b5c887si14757239pga.843.2023.04.26.03.23.59; Wed, 26 Apr 2023 03:24:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ExC7kmQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240418AbjDZKSD (ORCPT + 99 others); Wed, 26 Apr 2023 06:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbjDZKSB (ORCPT ); Wed, 26 Apr 2023 06:18:01 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86ACC35AC; Wed, 26 Apr 2023 03:17:59 -0700 (PDT) Received: from zn.tnic (p5de8e8ea.dip0.t-ipconnect.de [93.232.232.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0ECD81EC0666; Wed, 26 Apr 2023 12:17:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1682504278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=BzFp9UTkit55n4G1B1tLt+bHSM18YHNZYgQD7TIcCfw=; b=ExC7kmQdSNPRo+YUhZwnm1FfqsRQoNAgdZ1TeOelIKOhMdcLXiua9EYw+HR/gmWQLSjQeW xvZzPs0c+E6SH5MUE7NLn6JpYqGOWRr/NiYzcGUoUAaDpSrlkx0ruabJ7TxWDGpoNRrtFa j/7ufgwq4afdwzHPw016WeO8cMIHvLI= Date: Wed, 26 Apr 2023 12:17:54 +0200 From: Borislav Petkov To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Evgeniy Baskov , Andy Lutomirski , Dave Hansen , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexey Khoroshilov , Peter Jones , Gerd Hoffmann , Dave Young , Mario Limonciello , Kees Cook , Tom Lendacky , "Kirill A . Shutemov" , Linus Torvalds Subject: Re: [PATCH 0/6] efi/x86: Avoid legacy decompressor during EFI boot Message-ID: <20230426101754.GBZEj6Un+ahT4iZ9fs@fat_crate.local> References: <20230424165726.2245548-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230424165726.2245548-1-ardb@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 06:57:20PM +0200, Ard Biesheuvel wrote: > arch/x86/boot/compressed/efi_mixed.S | 55 --- > arch/x86/boot/compressed/head_32.S | 24 -- > arch/x86/boot/compressed/head_64.S | 39 +-- > arch/x86/boot/compressed/misc.c | 44 ++- > arch/x86/include/asm/efi.h | 2 + > drivers/firmware/efi/libstub/efi-stub-helper.c | 4 + > drivers/firmware/efi/libstub/x86-stub.c | 360 +++++++++++++------- > 7 files changed, 279 insertions(+), 249 deletions(-) Upon a quick scan, I can't argue with that diffstat and would prefer a lot more if we did this instead of Evgeny's pile which touches a lot of nasty and hard to debug code which gets executed on *everything*. So if people agree with that approach, I'd gladly give it a more detailed look. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette