Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Apr 2023 14:10:04 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Harini Katakam <harini.katakam@amd.com>
Cc:     robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
        linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
        edumazet@google.com, pabeni@redhat.com,
        wsa+renesas@sang-engineering.com,
        krzysztof.kozlowski+dt@linaro.org, simon.horman@corigine.com,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com,
        michal.simek@amd.com, radhey.shyam.pandey@amd.com
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: mscc: Add RGMII RX and TX
 delay tuning
Message-ID: <20230426111004.56tq4rzbnndxrsnf@skbuf>
References: <20230426104313.28950-1-harini.katakam@amd.com>
 <20230426104313.28950-3-harini.katakam@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230426104313.28950-3-harini.katakam@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sgAZd+E4BdWy4cLvSDg44OBx91P36kUvaFBUKKcbOwPnKaptCH39T53W0FbM?=
 =?us-ascii?Q?kBd+UTQMD9pcFQp/+XsUQYzXdwamS3gg+snsy2elUkI50/uJfbHCrAPSRqwq?=
 =?us-ascii?Q?R3o8HUVpzodHFZm1TxtrGdtj5bBw38A84+RDCSRsKqMnGu9vS5MsQGKqMMnS?=
 =?us-ascii?Q?2fpmAka2ARuWCmlVo2pdmpZpWoXjhu56irOolkXCbu2rIRK0tU4CEkKP51Rg?=
 =?us-ascii?Q?X6UHkirrxXpATVZAU5bjZbioOh+bEzfTe8IpnllOmvUlLDImbS+Ub21btBD9?=
 =?us-ascii?Q?2hHJg5fG+UsCcBPG5W8Nob4AzDgtqSf12u1FcOI15wN4YCstE9OpCQCyp6AS?=
 =?us-ascii?Q?A8OTRy+YF7te06Wyu7yzAg2ccU6jnKDyQ3uAgLyicWjdws6wTEIsjPwusRUF?=
 =?us-ascii?Q?Rfm7ow5XIfljkTc49tMqoKTr1Zg1L/qO7ag1+vFfhh8OX3+2gjHH5oG0Y+gI?=
 =?us-ascii?Q?aRiM/u649JZDK8qMlcZIEwTq4Vxlhr5qxVhQIIX+sWKsc098Ulnf9FIMbWNx?=
 =?us-ascii?Q?ItuGBHzErNDl5GD6Fmu6QXZEcraotTwLCbKs1xCQgxc73+ls0XOzUbX9rUHB?=
 =?us-ascii?Q?Mi1FccT96Rcush7ea4cCAZTdakWdmdc+Y02AiSCF4pbA2Q4n3erZn/ak3P//?=
 =?us-ascii?Q?8eqDS58nbgiIT2yXK0aj2Gr3nvXGk8yIr3O9N+sCvr+KJ+HmEjbQhFB5xYeK?=
 =?us-ascii?Q?583pZrRrBJRKmoKtbJaUQ/iLoiCCZapIg8v2mxL+0396Cft6pCtnH5hJ3pUz?=
 =?us-ascii?Q?9C6jcCWg2N3MXh3rsttxOxxme/gr023vWMyeiD/7xh8lY6hczbWNGlnutybN?=
 =?us-ascii?Q?Fyye2SO66mtDnIbSkxsoO9KTvIvoLmnevecEh30g1CqIi9wpsDPnlav5xwkM?=
 =?us-ascii?Q?+e6Teks3ke/ailg/iy20xmnm1X3t21FDKH/jCWHLB6p3rnNg8Pz68JANWzb+?=
 =?us-ascii?Q?G/CgF0gxrZjM+uxm67METMrKwyNU0N9aeCjek/nyhfTN7SxvW51QKs1CasNu?=
 =?us-ascii?Q?0VlIbvA4J23KV3p4bKbsdGhQEvb8P8qkUjp3WOQjGrg8wlmeY/WzgRQ1MQJb?=
 =?us-ascii?Q?Nm5jKaYnJeer7B6QqulmX+2y1h5TY07PL5G5aDjo4VZNUr9aKyHBG6lgOhvY?=
 =?us-ascii?Q?nyDSCeIxdJks3JHRhCfQxD+1QhcaUG3bIlbU3xL7f8HaiBT/eos7ewANnyz6?=
 =?us-ascii?Q?vKJKOPAAKjO5Q27vWTCaATWFTmF/x26n9knOGpRbPGXTIKP1MlTfAP6WSurd?=
 =?us-ascii?Q?M2YyPKiiQmlTElEWDpsvjdmTOkWYgwRIdbNba9tC/ZW6CwGa2Y0VJWhkZq8T?=
 =?us-ascii?Q?VW3Ee96y02L1Y5Ls5HPF4H9UM9d/EltHJZOhZZeZEEdvwjRvdOiCa+JHCuMD?=
 =?us-ascii?Q?4u+SUscYjmg4gY4vP4Q5lbOIPb9cBBElL29sICxC+afkL+dwzCpLnuyDpqMr?=
 =?us-ascii?Q?0vALPvVAEf8mHVDRh0R43abwmLoAJBnsDaJq9IzaPgvLoBHF8ui3KqbKT+rx?=
 =?us-ascii?Q?8xMo9k2R/po4OWWOWCVT2wxhMTVojDq02Eo50aFF5HYml/K4CZvTuFUujFdI?=
 =?us-ascii?Q?D4l23neY/xEVWKYyqMgCkduCQ2gdOGRGf/D//CsNwgBeVFrxTw0XzIUB8SVW?=
 =?us-ascii?Q?cg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 786e9085-c43a-4e75-e89f-08db4646cba5
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 11:10:08.2836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CXF3NNHJEi335y4OCfxXTJSLvo9lfp9NcLt5d4WDEQoCBbmeXtHzgnGCDfl8OfftuyhZLeQ63jn4oppF6R4DUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6854
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 26, 2023 at 04:13:12PM +0530, Harini Katakam wrote:
> From: Harini Katakam <harini.katakam@xilinx.com>
> 
> Add optional properties to tune RGMII RX and TX delay. The current
> default value in the Linux driver, when the phy-mode is rgmii-id,
> is 2ns for both. These properties take priority if specified.
> 
> Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> v2:
> - Updated DT binding description and commit for optional delay tuning
> to be clearer on the precedence
> - Updated dt property name to include vendor instead of phy device name
> 
>  Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 0a3647fe331b..2b779bc3096b 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -33,6 +33,8 @@ Optional properties:
>  			  VSC8531_DUPLEX_COLLISION (8).
>  - load-save-gpios	: GPIO used for the load/save operation of the PTP
>  			  hardware clock (PHC).
> +- mscc,rx-delay		: RGMII RX delay. Allowed values are 0.2 - 3.4 ns.
> +- mscc,tx-delay		: RGMII TX delay. Allowed values are 0.2 - 3.4 ns.

We have rx-internal-delay-ps and tx-internal-delay-ps in the common
ethernet-phy.yaml, there is no need for a custom property.