Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <905bd588-38c7-e3ad-c201-534c4593aa51@amd.com>
Date:   Wed, 26 Apr 2023 14:06:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC v1 0/2] Introducing generic SCMI pinctrl driver
 implementation
Content-Language: en-US
To:     Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        "sudeep.holla@arm.com" <sudeep.holla@arm.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
References: <cover.1680793130.git.oleksii_moisieiev@epam.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <cover.1680793130.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDByMlNnTjNuaDV5eWViaUN5WG4vNndYM2lkVXRMejUyRFFzb0QxZUV0RmNK?=
 =?utf-8?B?eGozT0pBMHdYcDIzYlY2Y2Y0ck5VQ0lsK0E5bkFFdHg3TXhWK3ptbCtkdU45?=
 =?utf-8?B?V0xKWnpYMW5PY05jckJpS1ExOU8yZFNGMGJ0V0dDSmt3NjE0czRyeE5DM2VR?=
 =?utf-8?B?VnBUQndsY05WR1JpSHNsS0Y4RmduSnhkdlJOYnFoVUVXK0RrZHorZ1BuNDdM?=
 =?utf-8?B?SmJQQ1EySERNcGNrbXY1YytmUTYyaVdXQ2VVaUtVYmlBQ2VZN0ZVYWVPY0RQ?=
 =?utf-8?B?RTZ3dHBSRVVZOGE5dFdvOXA0TC9GZUZyaHBlZzN5d1VHOHIrT2pqajBna21t?=
 =?utf-8?B?MzRTdDFTQld0N3hpL0hnOFpRWmdvcE9pcVhROS9jQ2RxZVBMSDdVVTNTenZS?=
 =?utf-8?B?QnNUSHpPUjh5OWs5U1oxRU5wcW1pdXhHQzRrelBraTJJYWpTL3FCUlI5TVh4?=
 =?utf-8?B?KzJ5TlQ0WlRoL3dQeVE5NmgyQW9JOUJ3ZHV1SWxlL09Nc2h1dWNnQUdaSHdh?=
 =?utf-8?B?L1FQcUdNa1JSL3N0SG5NVzRpQ3ZVSXBnZHNFM09aeGtxR29TSDhzQzNDa0FQ?=
 =?utf-8?B?ZndJZjgvZzFpZmQ2a3ZUSDZDVUxqZjJNYi9KQWdZUGVXWlVRSWwrWmU5cWxR?=
 =?utf-8?B?aDd5a0tkVlFBSjFjRzJLRTd4eklVZk1lSFFobUh3Y2V3WCtGTnFyVEZhdURM?=
 =?utf-8?B?ajlwYVoxWlJyQS96YVgrckJsYm9SU01kNE1RZDZVdmhtR2VHcmRHcis4ek5m?=
 =?utf-8?B?ZVAweVdtUStxc1dWeDZ2MzRkT2VXbjNlTjFyTVdlRExmV2k1Q0ZoTy8xaXNr?=
 =?utf-8?B?dDdUQ2d6NXRITFJtQXpKREVKbWtZMDlad24vWERzc0ppcktPLzNjVVVFYlRT?=
 =?utf-8?B?R1NBMlV6d1Y2SzM2SnVMWXFiNHlXTmlKVXRiTXFDVmJMRVRCdkVwckdnektq?=
 =?utf-8?B?ZFJod1Q4am5hZHM2Yng2dk1HZUIzWTNISEsrNVAybCtpZndhVzdkZmJlYVNE?=
 =?utf-8?B?Rjl6dk9lUXJHRnkzc2RrejZ3VDMyVXJ6ZDVIVHA0ZVU2WHB6aDNxYmlScVFv?=
 =?utf-8?B?TlNtMitHY1dadks2NkYrQ3BiSndQVHB0RmxEZ21nTUd3MTRjNTJGRUVETUxy?=
 =?utf-8?B?RmxZakpVREtaTyt3OHpvN0JpZnV2ZzVoUDVqdlhCQUNHTU9QUDhQK3QyVmYz?=
 =?utf-8?B?d1FycGFjdnVBTXlVQmhDNjhRQ3hFSHJKVkovS1Z4UzBKazN2K2E3bG5HOHhi?=
 =?utf-8?B?SW5OYkthLzU2SytSelI1RWxlc0xxM3BnZU1ucXc3VlQwSFVxVFdYQ2Q3ZkFK?=
 =?utf-8?B?RGY5VDcyS29yZE9TR0w4R2x6VU83eVlaUzdxcWVmei9ZN0FLVHdoZU91cDRJ?=
 =?utf-8?B?UGQ0TDhCZzJ1RDVDZDJvbWE4dnZKblArMzl2aHFsUWR5TkdabFJ1UVh3N0ty?=
 =?utf-8?B?UklhRS9QV0o4d0h4YzNyMlZ2WGNMMFFaRmI1aHFQZWU1VWRNRlZLK0VROXRK?=
 =?utf-8?B?Sm5UeFNua2lOY3dOa0VGVGg0WGlEb0NCWGY1d0N2NTZBT1lPUHhXTWszVmtP?=
 =?utf-8?B?bzRkQnJNK3Z0MERsSzdsU2pLOGdEMk1IdVNWdERBMFdRN2JnWTMwdmhHKy9E?=
 =?utf-8?B?VVlOTjc5UGN3K05tN0FlY2hPcWhVVUxxaW95S0pyMUJYc0FrdU9ncE9uTGNR?=
 =?utf-8?B?Y1NGNlc2USswMDFZM2lmcEtVaStTalNjLy9kTGtMM3kvbE10RFl4NGhqNUpH?=
 =?utf-8?B?VEl3RHNaTjRUZkJlZHBBQkU2R0tHSk8vcStKVktveWxYaDFadEIybXdKRFFI?=
 =?utf-8?B?a0JPbU9ROVJRb1V1eVYwQ0dYMm85eVczdHlQZXRicEU5NWE2NmRtOFFPaU4x?=
 =?utf-8?B?NXcyS245eSsxWTR3c05YUytQaTIxbzNndWJuZHZvUWN3ckZxSjhKOUFnMmxY?=
 =?utf-8?B?Y1kvR1dCQXc3M281YkRIcDdEeXg3Yi9mWXQ3TDk2dlJ5eThQWGFYZ0U1KzBT?=
 =?utf-8?B?MHQyWmRXNUV1RlpXVlBndmxnR1YzRVZpWWhTb0l0U1UySG12WGdQWDRsdXFh?=
 =?utf-8?B?MFVrL3VDRWxGRzBUV1BVdEErVWZXb0d3czJlRGZ3L3pLLzRRaDVOaEFtUDla?=
 =?utf-8?Q?BNF2zxqOGyFFTUVNQMmmoB14j?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d20c741e-0ae0-4ca2-019a-08db464ea4e8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 12:06:19.2736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sVzZTgKJORIXnu3narce1DvevMtiq52buQlexQ5TxdPChx7EOJ/8jP4GO50vj6s1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5749
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 4/7/23 12:18, Oleksii Moisieiev wrote:
> This RFC patch series is intended to introduce the potential generic driver for
> pin controls over SCMI protocol, provided in the latest beta version of DEN0056 [0].
> 
> On ARM-based systems, a separate Cortex-M based System Control Processor (SCP)
> provides control on pins, as well as with power, clocks, reset controllers. In this case,
> kernel should use one of the possible transports, described in [0] to access SCP and
> control clocks/power-domains etc. This driver is using SMC transport to communicate with SCP via
> SCMI protocol and access to the Pin Control Subsystem.
> 
> The provided driver consists of 2 parts:
>   - firmware/arm_scmi/pinctrl.c - the SCMI pinctrl protocol inmplementation
>     responsible for the communication with SCP firmware.
> 
>   - drivers/pinctrl/pinctrl-scmi.c - pinctrl driver, which is using pinctrl
>    protocol implementation to access all necessary data.
> 
> Configuration:
> The scmi-pinctrl driver can be configured using DT bindings.
> For example:
> / {
> 	cpu_scp_shm: scp-shmem@0x53FF0000 {
> 		compatible = "arm,scmi-shmem";
> 		reg = <0x0 0x53FF0000 0x0 0x1000>;
> 	};
> 
> 	firmware {
> 		scmi {
> 			compatible = "arm,scmi-smc";
> 			arm,smc-id = <0x82000002>;
> 			shmem = <&cpu_scp_shm>;
> 			#address-cells = <1>;
> 			#size-cells = <0>;
> 
> 			scmi_pinctrl: protocol@19 {
> 				reg = <0x18>;
> 				#pinctrl-cells = <0>;
> 
> 				i2c2_pins: i2c2 {
> 					groups = "i2c2_a";
> 					function = "i2c2";
> 				};
> 			};
> 		};
> 	};
> };

Spec itself has as the part of pinctrl also gpio support.
Here the example there is no gpio-cells property that's why I am curious if you 
plan to also add it here.

Thanks,
Michal