Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fb6638f-1e99-a1c1-3fa1-f814d08d2659@suse.com>
Date:   Wed, 26 Apr 2023 20:25:14 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] btrfs: parent bytenr must be aligned to sector size
Content-Language: en-US
To:     =?UTF-8?B?0JDQvdCw0YHRgtCw0YHQuNGPINCR0LXQu9C+0LLQsA==?= 
        <abelova@astralinux.ru>, Chris Mason <clm@fb.com>
Cc:     Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
References: <20230426115323.9455-1-abelova@astralinux.ru>
From:   Qu Wenruo <wqu@suse.com>
In-Reply-To: <20230426115323.9455-1-abelova@astralinux.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXNJanBaeWRPajlqMGNCNlQ3THJ5SU50TExreDk2bDh2OGZIbC9Rcyt0YTJu?=
 =?utf-8?B?Y1UrcEdWTUU5cGRNYU9HOHlOTFRhWHhsZTZCdS9CRDg4cXVIR0hKVG8zS1JW?=
 =?utf-8?B?QUd5c3JTdE8yZEJra2pLU3lmR2JhMVA5ejZ5eENlUm9xRSt4SGlsbEhEWTJ1?=
 =?utf-8?B?WHBnVWRXR3cvS3l3M2JZMTIyNlA1bmpVbkN3UzlsQW9kckhnM1ozUkdyalhQ?=
 =?utf-8?B?UHkzb1NTY2NDV0xvNGFoZENNNGFsUjBWTzRiRTFvK1BQT2dzem8yaE9jeHg4?=
 =?utf-8?B?dmhCbDU5YUNQSXp0UjRrK2ZJWFVuNE1QdVZGTXNxS3Y5ODFhODhKTGFKVXo3?=
 =?utf-8?B?N3hlRXgxZE1iWlVuNUN0ZW16K1QrNG9vUnZReHp5UDhtajlhM1NpNm5hakw4?=
 =?utf-8?B?VncxTU5wY05Cb0FDeHFQZG1ZTi9PVzJnc1RqSm1NVlhkazY5SVQ1R0pnZWh5?=
 =?utf-8?B?Qm92TnZlNVpRTlBSNklMdk9wVTdFcnFpZ1Z4eGE1aExoOWhza2xGZ1I2dSt4?=
 =?utf-8?B?WWF5L1d1bWsveFdpQzFGNVZ5K045cFdyeUpJb1ZEdnNJYWpoSVJlbnlEU0Ru?=
 =?utf-8?B?Tk0xSGFSQjFKMkQzdUFVelk1NTkxL0VpdmtiRGpLSEhjK1FBR3hrQ0tzWWFY?=
 =?utf-8?B?ZnYwM3g1TFQ1VnY0Wjcyek16c0FZSThRM3JuU21pakRxWnAzT1Z1dXdmbWZt?=
 =?utf-8?B?Y3FMSnRicWhkRUVlQlV0NHpJdHFZWE1haGQ5TE55N1NEYlJIOVEwVGZOcGxL?=
 =?utf-8?B?TitIZHFLcy92cnRGUm5EUldRNzRDOFgxMWoyUVFwZ3c5Wm5TczlNVjdwY2do?=
 =?utf-8?B?UklTbStQeFhtOEdKd2FPRDY0Z3g4VGdwYWFIM1BOYU5LT201MmVyWXZiWmti?=
 =?utf-8?B?dHMra3Ewb2ZQenpIUkpEd1JhdXVVTmdoNjVlUm5RcVVXVjBpbG9HbE5SbzZX?=
 =?utf-8?B?SFgwV05wdjNmZzdTOFRFajdFRGhReXVScWk5YUZ0WmpUcVQ2NkxOQnVDN29s?=
 =?utf-8?B?ckhkeFl0czhFS3hlS2ZYSFllbUFRdlQ5U0NDdSs1TWVRa3puOWIxM1c0WWJ2?=
 =?utf-8?B?cE5OQnhjWlZObGpVU1pObHJuOUFUNDFPczFDM0swVHdOc3ErejUxVWhLd1hM?=
 =?utf-8?B?SW8xT0hjZjVWSHZaN25lcG93NlRkRFZjczRzRmtqMDVDeHo2YmdzR25Dd0lj?=
 =?utf-8?B?bng0Y0FZZHVmMUI1bmJyOExiL0pZeEk4cUE0VjNPaEZHZ29PQUVTOFJ1UVRU?=
 =?utf-8?B?Q1RvbHBmMFhKUmcwYUpxY0dLK294SWNMS1g4N3NzdXVVR3k4NUtCdmMxdVFJ?=
 =?utf-8?B?RU5iTVlFQk94NjRuSWthWFpIRWVESzlrUW01TDR1VlJOVUVtUDlpdTBzUGxO?=
 =?utf-8?B?dlJiVElnam14K1ArbjZLNXp2amJEREZJQzRONEhuNGozdzRGcFVQZzdqSjE5?=
 =?utf-8?B?cCsyTjBLdDYrZytpeTQzRmtnbWpUcUtaV3Y5SHlpVWpUMERQVE94WDBTRTU2?=
 =?utf-8?B?YnRkY3I2YkROYkR2YTlpKytJbFlDY3ZMc2JhcW5qcWdlRlFmc0lIdXRYTjRs?=
 =?utf-8?B?VlUzUS9heFpENU1PaFU2eVJIejlrc2dvVWswVXlmT2QxaVFad1duT3ZhOUZF?=
 =?utf-8?B?aHlWQ0NYdlhaOUkxU05oRFFsQjhuMVU5bWgvWE5jMHBsanF3SzJNUko4L1FV?=
 =?utf-8?B?NHl4M0ZxbkUvL2wrUmEyd3JwbWpFMkFhd3A1c3NvNjJpb3YzTUMxTk5WYXM0?=
 =?utf-8?B?TCsybEptZVFITVIvUElxcVZFODVaMEtsdlJCQ3cvRjJUNVAyV3JQbmF3VG5G?=
 =?utf-8?B?YngyckF3TkJmalhoVnFobWoza0dRcktad1Z6M0Rib0ZlNno5Q3hUWmRUOGRj?=
 =?utf-8?B?eVhpNlNWM2Z1R2hqbnp6N2xQdExEQ2RyckRENWg4NzMzREREemJFdml0N2dK?=
 =?utf-8?B?L2ZjR0t3a1U1bTg4Q2NkcW9ldUhtWWVDbWxWa1hUcmh5TTNqc2JRRXNRS1BG?=
 =?utf-8?B?MHZRWEhnWXZGQURmdkNaRVpla3pxa2RqOFpaTUNFVG00Q2tQSUx5ajRkajVo?=
 =?utf-8?B?VTZ6VUR5WW1Zdjg2SnZzRS83dENwMEFrV3kzWWt0TFZiVTM2MDdVdU54ZStJ?=
 =?utf-8?B?WjBnQjU2WFA0aERqWTJzKyt1UGFQZDFCZjZrYWlZT1UrY3pQUzQxNjhHNDhH?=
 =?utf-8?Q?dixojdejeeD5QajzEokGGOA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04112229-4613-4b8d-b558-08db46514efc
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8465.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 12:25:23.7398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5BCKZcwtCoFHpk+LLatYGtzLDaXnwSbHwKXEM8qPMHOPbJfzYeAi+6Ug+NN52p+u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9405
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/4/26 19:53, Анастасия Белова wrote:
> From: Anastasia Belova <abelova@astralinux.ru>
> 
> Change nodesize to sectorsize in alignment check
> in print_extent_item. Change requirement in comment.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: ea57788eb76d ("btrfs: require only sector size alignment for parent eb bytenr")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>

Reviewed-by: Qu Wenruo <wqu@suse.com>

A little surprised that a static checker can even find such hidden problem.

Thanks,
Qu
> ---
>   fs/btrfs/print-tree.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/print-tree.c b/fs/btrfs/print-tree.c
> index b93c96213304..cee005fb8209 100644
> --- a/fs/btrfs/print-tree.c
> +++ b/fs/btrfs/print-tree.c
> @@ -152,9 +152,9 @@ static void print_extent_item(struct extent_buffer *eb, int slot, int type)
>   			       offset, btrfs_shared_data_ref_count(eb, sref));
>   			/*
>   			 * offset is supposed to be a tree block which
> -			 * must be aligned to nodesize.
> +			 * must be aligned to sectorsize.
>   			 */
> -			if (!IS_ALIGNED(offset, eb->fs_info->nodesize))
> +			if (!IS_ALIGNED(offset, eb->fs_info->sectorsize))
>   				pr_info(
>   			"\t\t\t(parent %llu not aligned to sectorsize %u)\n",
>   				     offset, eb->fs_info->sectorsize);