Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230426124948.1072216-1-zhanggenjian@kylinos.cn>
In-Reply-To: <20230426124948.1072216-1-zhanggenjian@kylinos.cn>
From:   genjian zhang <zhanggenjian123@gmail.com>
Date:   Wed, 26 Apr 2023 21:02:25 +0800
Message-ID: <CAOd03yQ98st7KvAkwfFqFvXGBdmWmOZZ-kWAH5DAi7gLd=ngaA@mail.gmail.com>
Subject: Re: [PATCH] fix ___SYNC () build error when PROFILE_ALL_BRANCHES is enabled
To:     tsbogend@alpha.franken.de
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Genjian Zhang <zhanggenjian@kylinos.cn>,
        k2ci <kernel-bot@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 26, 2023 at 8:51=E2=80=AFPM Genjian <zhanggenjian123@gmail.com>=
 wrote:
>
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> compiler error (mips-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110):
>
> {standard input}: Assembler messages:
> {standard input}:171: Error: found '(', expected: ')'
> {standard input}:171: Error: found '(', expected: ')'
> {standard input}:171: Error: non-constant expression in ".if" statement
> {standard input}:171: Error: junk at end of line, first unrecognized
> character is `('
>
> Preprocessor expand ___SYNC () macros.However,'if' will be wrongly
> replaced by C code when PROFILE_ALL_BRANCHES is enabled and ___SYNC
> is used in inline assembly.This leads to syntax errors in the code.
> Compilers report a lot of errors like the above.
> Move '.if' into quoted strings to fix it.
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
>  arch/mips/include/asm/sync.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/include/asm/sync.h b/arch/mips/include/asm/sync.h
> index aabd097933fe..d9f5a87424e7 100644
> --- a/arch/mips/include/asm/sync.h
> +++ b/arch/mips/include/asm/sync.h
> @@ -175,7 +175,7 @@
>   */
>  #ifdef CONFIG_CPU_HAS_SYNC
>  # define ____SYNC(_type, _reason, _else)                       \
> -       .if     (( _type ) !=3D -1) && ( _reason );               \
> +       ((_type) !=3D -1) && (_reason);                           \
>         .set    push;                                           \
>         .set    MIPS_ISA_LEVEL_RAW;                             \
>         .rept   __SYNC_rpt(_type);                              \
> @@ -192,13 +192,15 @@
>  /*
>   * Preprocessor magic to expand macros used as arguments before we inser=
t them
>   * into assembly code.
> + * In addition,=E2=80=98if=E2=80=99 can not be substituted when CONFIG_P=
ROFILE_ALL_BRANCHES is
> + * enabled.
>   */
>  #ifdef __ASSEMBLY__
>  # define ___SYNC(type, reason, else)                           \
> -       ____SYNC(type, reason, else)
> +       .if     ____SYNC(type, reason, else)
>  #else
>  # define ___SYNC(type, reason, else)                           \
> -       __stringify(____SYNC(type, reason, else))
> +       ".if"   __stringify(____SYNC(type, reason, else))
>  #endif
>
>  #define __SYNC(type, reason)                                   \
> --
> 2.25.1
>

Maybe the readability of this modification is not very good. Any
comments and suggestions are welcome. Thanks.