Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230425110859.1757001-1-masahiroy@kernel.org> <20230425180802.GA2881732@dev-arch.thelio-3990X>
In-Reply-To: <20230425180802.GA2881732@dev-arch.thelio-3990X>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 26 Apr 2023 23:12:29 +0900
Message-ID: <CAK7LNARyW56E=RC_23NuEr7ZYi-iuxo6CvKfrPcCxJXcAF3ngg@mail.gmail.com>
Subject: Re: [PATCH] kbuild: deb-pkg: specify targets in debian/rules as .PHONY
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 26, 2023 at 3:08=E2=80=AFAM Nathan Chancellor <nathan@kernel.or=
g> wrote:
>
> On Tue, Apr 25, 2023 at 08:08:59PM +0900, Masahiro Yamada wrote:
> > If a file with the same name exists, the target is not run.
> >
> > For example, the following command fails.
> >
> >   $ make O=3Dbuild-arch bindeb-pkg
> >     [ snip ]
> >   sed: can't read modules.order: No such file or directory
> >   make[6]: *** [../Makefile:1577: __modinst_pre] Error 2
> >   make[5]: *** [../scripts/Makefile.package:150: intdeb-pkg] Error 2
> >   make[4]: *** [../Makefile:1657: intdeb-pkg] Error 2
> >   make[3]: *** [debian/rules:14: binary-arch] Error 2
> >   dpkg-buildpackage: error: debian/rules binary subprocess returned exi=
t status 2
> >   make[2]: *** [../scripts/Makefile.package:139: bindeb-pkg] Error 2
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Applied to linux-kbuild.


>
> > ---
> >
> >  scripts/package/mkdebian | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> > index a4c2c2276223..b6cb95473548 100755
> > --- a/scripts/package/mkdebian
> > +++ b/scripts/package/mkdebian
> > @@ -269,6 +269,8 @@ cat <<EOF > debian/rules
> >  srctree ?=3D .
> >  KERNELRELEASE =3D ${KERNELRELEASE}
> >
> > +.PHONY: clean build build-arch build-indep binary binary-arch binary-i=
ndep
> > +
> >  build-indep:
> >  build-arch:
> >       \$(MAKE) -f \$(srctree)/Makefile ARCH=3D${ARCH} \
> > --
> > 2.37.2
> >


--=20
Best Regards
Masahiro Yamada