Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp862883rwr; Wed, 26 Apr 2023 07:18:07 -0700 (PDT) X-Google-Smtp-Source: AKy350ZlfukfTwi2pNDitZj1Fzc6tax5/mPhqokyUk08q+n9S+E08sNf/d5ZViUDzzqr65tmkflY X-Received: by 2002:a05:6a00:17a9:b0:63d:2f13:1f3 with SMTP id s41-20020a056a0017a900b0063d2f1301f3mr33389750pfg.33.1682518686798; Wed, 26 Apr 2023 07:18:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682518686; cv=none; d=google.com; s=arc-20160816; b=O4Z+zIyBLf554qJsIlURnh47jpuhiLcAajXFGA1zUqkuPst0R19x/tLIKYd49G6HHS zxE4EiCxPOyRw+VNR2mDbf7Tg9gbiXVn1P0lJ4AtO+XNjg/csdsjBMKLya5CgDtn/2cX iP/ngODmP0MU0+QFx94w9w5w8mXyW/OEbVwBPYPvgl+zC4d4utlz38T4ynxWxK+I991i hUMdvmso1sPhGezxjMx6OXyC5jEzqmo6c13iZ5la/qxSJvIHgSu1zS05RTExSFjdAdSZ 8sVdrnIX4+3YPanGNd2FQJfB2fbkmP5YEEgpYBsvDd8U6tUeYe/x2Sf1ArmVyRS73kVN DvfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WJTlFq/pgFOuWhhYpAMgkhN3+RocMGSerj7R9QczxdY=; b=HfZ2vYpzTQ6ito6qv5+hfY2DH++4WD1ObOsnghKWKhHAp0OFGOkYQxHDuZHs43DZpC QzM/StFHTuVIXp4z41EFKGa0youvOzBNiKde2aOIOn+Y6nFhSiHy8cXpbMBKNY7ckO/S CpSap0pMu65qvQxLTcro0YRxLUJnVdF5yvnIQqWwsMyRF9w8wh92+uXWFyV0CRmAPTqP YHozI4cHWb2bQ3MRbquaRni8jjRnnlOiIonDDlC66jLEsfH4O0scQdGEmRXfACd/yryv oTREfQB7gT4zGR9DVQBOfLtegAbVruvaeRnLfLV9uIYNis0lAuN+L9K/wYUbHXDLjXT6 p/wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f4Sckc1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b66-20020a62cf45000000b0063b7bbeb33esi16075441pfg.137.2023.04.26.07.17.54; Wed, 26 Apr 2023 07:18:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f4Sckc1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241189AbjDZONi (ORCPT + 99 others); Wed, 26 Apr 2023 10:13:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240789AbjDZONh (ORCPT ); Wed, 26 Apr 2023 10:13:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D7716A70; Wed, 26 Apr 2023 07:13:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2E5C60FFA; Wed, 26 Apr 2023 14:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1876C4339B; Wed, 26 Apr 2023 14:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682518416; bh=FGzEvw9TbVU4T3e26lHuswObY6PfV6RZ4w7PVZz4AXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f4Sckc1gV0y+6gByaTDKrw3r1jyCDAO5rEijIAFivAFWrEsgtcXgkUsqZT2U8W0zk t93z4Zk0jrT1K/0VaUkkBwrfgbx0y9TakXUMTQ6f3mv8AWCayCR3TVAQer80Wvyays rTP+oXkU9hwPXEqkCCTiWOy5LzU5JXSYuGaOv5LnxQuw4Zqy2BhayBPu4a8D5dEwhG onrMoG371i1qUYlWcO74Qp2AeenrQPuN/YtTmlLc4aJS1Z59rFyqfyx8BY2HUILKDY JEQ/+l78mw8JzA9oUwUYHQKOrgp7ZAjVsywR7x18nNNtnlvJkmOp3tSDGPT0A0ofn9 B7dit+o6WdUZw== Date: Wed, 26 Apr 2023 15:13:31 +0100 From: Mark Brown To: Dongliang Mu Cc: Li Ningke , hust-os-kernel-patches@googlegroups.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()` Message-ID: References: <20230423032446.34347-1-lnk_01@hust.edu.cn> <46299274-d827-279f-cadf-020e93296c13@hust.edu.cn> <1488abfa-9a0e-970b-e074-11842a6c6413@hust.edu.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Od8kKp2gYUL6gufg" Content-Disposition: inline In-Reply-To: <1488abfa-9a0e-970b-e074-11842a6c6413@hust.edu.cn> X-Cookie: Drilling for oil is boring. X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Od8kKp2gYUL6gufg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 26, 2023 at 09:50:26AM +0800, Dongliang Mu wrote: > Second, from code review of platform_get_irq / platform_get_irq_optional, it > would warn IRQ 0 as an invalid IRQ number. > out: > if (WARN(!ret, "0 is an invalid IRQ number\n")) > return -EINVAL; > return ret; Like I say I'm not sure that's actually accurate for all architectures yet. --Od8kKp2gYUL6gufg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRJMYoACgkQJNaLcl1U h9C2lAf9GVQt82EKlECp9WbwEG+hwJjul3gLVids2AwP3aiURs70c1x2jUFqHvdf zlZkjjNOK4TEwy4TiUjws5Ep5rnAv1bUQ46rn9wZN1njGpCrAcSxKBLPBug4XlbJ FZcvjrI0mcgX7ZsPNm8Phyggy585Vys2eipru31AnNooURTZDeWf8cZikcofb/n3 7E6hdhrKyfbvKHwX3D7P/HVcd/appSvwBYAUVS7qxMqowdlkh+3un1Ei+VWMDHcK HV8vvO6dfNrMJiVODYR45X61cgtEbAhUeZQ9nae8qExhTyJwWs/XWRWrlgQf4U99 RteubIvOsSglFeh2vJsvkg58IM4MXQ== =bX6c -----END PGP SIGNATURE----- --Od8kKp2gYUL6gufg--