Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <abe1301a-8bdf-3e5f-9e52-71f0f77d519b@roeck-us.net>
Date:   Wed, 26 Apr 2023 07:38:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 0/2] Hwmon driver for MAX31827 temperature switch
Content-Language: en-US
To:     Daniel Matyas <daniel.matyas@analog.com>
Cc:     Jean Delvare <jdelvare@suse.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
References: <20230426124049.258359-1-daniel.matyas@analog.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230426124049.258359-1-daniel.matyas@analog.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/26/23 05:40, Daniel Matyas wrote:
> Removed of_match_table and kept only id_table. Removed other device id's
> from id_table (I have them only in the devicetree-binding).
> 

Please explain. Without of_match_table, it is not possible to bind the driver
using devicetree data. What is the point of that ?

Guenter

> Added mutex protection where it was needed.
> 
> Daniel Matyas (2):
>    dt-bindings: hwmon: add MAX31827
>    hwmon: max31827: add MAX31827 driver
> 
>   .../bindings/hwmon/adi,max31827.yaml          |  54 +++
>   Documentation/hwmon/index.rst                 |   1 +
>   Documentation/hwmon/max31827.rst              |  83 ++++
>   MAINTAINERS                                   |   9 +
>   drivers/hwmon/Kconfig                         |  11 +
>   drivers/hwmon/Makefile                        |   2 +-
>   drivers/hwmon/max31827.c                      | 406 ++++++++++++++++++
>   7 files changed, 565 insertions(+), 1 deletion(-)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
>   create mode 100644 Documentation/hwmon/max31827.rst
>   create mode 100644 drivers/hwmon/max31827.c
>