Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4cdd1cd2-bf9a-ed55-946d-48f917f72342@hust.edu.cn>
Date:   Wed, 26 Apr 2023 23:07:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`
To:     Mark Brown <broonie@kernel.org>
Cc:     Li Ningke <lnk_01@hust.edu.cn>,
        hust-os-kernel-patches@googlegroups.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>
References: <20230423032446.34347-1-lnk_01@hust.edu.cn>
 <d29c4b3e-9e82-4ea9-9f0c-a8e2c7637eb9@sirena.org.uk>
 <46299274-d827-279f-cadf-020e93296c13@hust.edu.cn>
 <ed846afc-7155-4998-9a8d-e9d9e8aaf8e2@sirena.org.uk>
 <1488abfa-9a0e-970b-e074-11842a6c6413@hust.edu.cn>
 <dbcc6739-e741-495f-85f9-bac104647194@sirena.org.uk>
From:   Dongliang Mu <dzm91@hust.edu.cn>
In-Reply-To: <dbcc6739-e741-495f-85f9-bac104647194@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/26 22:13, Mark Brown wrote:
> On Wed, Apr 26, 2023 at 09:50:26AM +0800, Dongliang Mu wrote:
>
>> Second, from code review of platform_get_irq / platform_get_irq_optional, it
>> would warn IRQ 0 as an invalid IRQ number.
>> out:
>> 	if (WARN(!ret, "0 is an invalid IRQ number\n"))
>> 		return -EINVAL;
>> 	return ret;
> Like I say I'm not sure that's actually accurate for all architectures
> yet.

I see. Let's wait and see. When it becomes stable and universal for all 
architectures, we could clean up them all together.

Currently our team just works to make Smatch happy :)