Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Apr 2023 17:35:33 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Ding Hui <dinghui@sangfor.com.cn>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <keescook@chromium.org>, <grzegorzx.szczurek@intel.com>,
        <mateusz.palczewski@intel.com>, <mitch.a.williams@intel.com>,
        <gregory.v.rose@intel.com>, <jeffrey.t.kirsher@intel.com>,
        <simon.horman@corigine.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
        <pengdonglin@sangfor.com.cn>, <huangcun@sangfor.com.cn>
Subject: Re: [PATCH net v2 1/2] iavf: Fix use-after-free in free_netdev
Message-ID: <ZElExd5bAL2FCpIB@localhost.localdomain>
References: <20230419150709.24810-1-dinghui@sangfor.com.cn>
 <20230419150709.24810-2-dinghui@sangfor.com.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230419150709.24810-2-dinghui@sangfor.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?72ElfKa0uFm26n4CINGysmirZxRGmhU32SvyAPkCdvBf/Jr7VyYU+LHj5Ndp?=
 =?us-ascii?Q?cNrbQXGbn8iyvleXhP65OsxUE48mkM/OTM7BuTPBSXFoPj96ZQbYuwRbXs8d?=
 =?us-ascii?Q?nHG1T4SXdvm0abnmtQJz3yosrMoby5TZMblCO6HtU7vvWOc4mjFFanG/0UVY?=
 =?us-ascii?Q?iKUrebv/dQkooBkQ2DYv0wZ6+915SOx3zaLkBcV70HEIshVp2HWuhHzUX3hJ?=
 =?us-ascii?Q?luuCTUSWH+h0FNG+aZU77qAAG42bXwbEa7YNlpg6v+N1frGWJDFu3YaEaDqr?=
 =?us-ascii?Q?8QCo/uRzKLlB7vFQCld8ZKo+47tGC5eVPshm6yosvP/NelfGk+FJzxRiGHSB?=
 =?us-ascii?Q?ufy6GYjq+azhVkMo5X2RfdH3aIeXDJdj4zIWUmKUYrg+KeWKuF8aeCIlwDju?=
 =?us-ascii?Q?hr2rUaKVJfVTh8Hi1NobLL0jtbBZqNxKjMSQNRyjRBT6J/k88x+O85jxESt1?=
 =?us-ascii?Q?0usKO4yBb7i2Y99QztwT4KsjHFZonGp4xXMMbLpdtCcayKbpbTAvF8hPHoNO?=
 =?us-ascii?Q?ECAVX+maamR6eNSlYJ97rXgcO/HHWWF+xgOfRq5wK1xe3HHKOSjFmzObPMqD?=
 =?us-ascii?Q?rv3iSofVDdmTML7/lp+wYhkS+X21qAaNBi0pcOruSWAHT/qyix9rCHom8K8e?=
 =?us-ascii?Q?eyPUPmWn+bTIOVybFhAUj6iYoblSXij5jx7Hn+Jr7AIt8WnuWE7gSz5ayOIK?=
 =?us-ascii?Q?GBDQtt3Myngq9pHxckJ7+ilDeASSS5MsaHVyyO6OYTObaalmhGqhKORcrCZo?=
 =?us-ascii?Q?ijHRLx5nRGqshR8bfU1N/jhVfcuFSpN0HZLv2qqdSrPyPqxOLBufH434+YJ+?=
 =?us-ascii?Q?6SkArgrKCeudhajY560X1aMgn2xp+uTkfcxk73LJIAkS/PJh131OyrO+Ymtu?=
 =?us-ascii?Q?QvEK3Pv38QqAOARxvcU5MuAnypVYOuKrsemaBIOj1eU450DFGXgSfk+jJ+yX?=
 =?us-ascii?Q?W4b1/UPK//QcOYPSqkWlYEYHQC+uoFeY8Rq2FVc0Zw4FQwUxZUQmokgWy040?=
 =?us-ascii?Q?XM2C6KCB6ptgIDjbVdjCIAVXY30GQUCBO/ya+3kYEUBvqyEuuENVU8zgcAp1?=
 =?us-ascii?Q?hBLGEgLIvv14Ej9pyPEXhOsnCEhb3JXmf1/xgIYQRjGkUIlathupKYWm7V+y?=
 =?us-ascii?Q?QeWbQdtx8w6ybxlDKjpOLByypiLe9DeuCYutlat+liyx/Sen5DPtahyGIdO4?=
 =?us-ascii?Q?gqBNB+BFGgWwWjfJy+rCNMHPggCfr4oVVhtbiuQC6EQYsohbCfxunH82MJa3?=
 =?us-ascii?Q?1U2xnrgujdxF2drAXs3jXFx+n/ukOnIp7OP8DRNHBXTRoE98GaS3295xbEcv?=
 =?us-ascii?Q?P6rCK9z3ljmmSLW25irngYxE2eeSiiBWcQC3WrlBGQxcYICnrwFRFzSXn9OO?=
 =?us-ascii?Q?vn1sKkYFY8ZRya1koCDqSXaHOBNZV9be7Iy70jQH/iFWt3xfS4DoT4sxdsDe?=
 =?us-ascii?Q?G7Jf4lo8znl05FvzBZ6gGYRdvnTFtP+YCmM5RjrHRcDRxUp7v+NH+jTV4kId?=
 =?us-ascii?Q?6/OzZ8zsJkrj9DF176vtkzRwKj7QKmvzzD3klCJc9uCEX6esdEZMVjd73Rnz?=
 =?us-ascii?Q?hoeHTj+mnsW6XNXk467SgtaHQsjOrHHe1YNmTFppVOCl3KR0qucQHuWdoKTi?=
 =?us-ascii?Q?Vw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 88ef5796-d4b6-43d1-1b27-08db466be45b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 15:35:41.3022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yfms469YAwXQlOeRfwLQHmXKD2anYOYcPv48Vb1chzjCSd95856s7NP4W6fd0VYcuFN/WxzfVpKhwuViy7hf2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6051
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 19, 2023 at 11:07:08PM +0800, Ding Hui wrote:
> Cc: Huang Cun <huangcun@sangfor.com.cn>
> Acked-by: Michal Kubiak <michal.kubiak@intel.com>

I'm sorry, but I don't remember giving "Acked-by" tag for that patch.
I gave "Reviewed-by" only for the v2 series.

We can't add any tags if they weren't given by the person himself.
Please fix that.

Nacked-by: Michal Kubiak <michal.kubiak@intel.com>

> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> v1 to v2:
>   - add Fixes: tag
>   - add reproduction script
>   - update commit message
> 
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> -- 
> 2.17.1
>