Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Apr 2023 20:23:39 -0700
From:   Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Stanislav Kinsburskii <stanislav.kinsburskii@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Chris Down <chris@chrisdown.name>,
        Helge Deller <deller@gmx.de>, Omar Sandoval <osandov@fb.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: asm/io.h: Harden virt_to_phys/isa_virt_to_bus
 prototypes
Message-ID: <20230415032339.GA8240@skinsburskii.localdomain>
References: <168146523405.6279.3632248068235163346.stgit@skinsburskii.localdomain>
 <7d0389aa-4fc0-499b-8f2e-5a96102efa24@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7d0389aa-4fc0-499b-8f2e-5a96102efa24@app.fastmail.com>
Precedence: bulk

On Sat, Apr 22, 2023 at 11:02:33AM +0200, Arnd Bergmann wrote:
> On Fri, Apr 14, 2023, at 11:40, Stanislav Kinsburskii wrote:
> > From: Stanislav Kinsburskii <stanislav.kinsburskii@gmail.com>
> >
> > These two helper functions - virt_to_phys and isa_virt_to_bus - don't need the
> > address pointer to be mutable.
> >
> > In the same time expecting it to be mutable leads to the following build
> > warning for constant pointers:
> >
> >   warning: passing argument 1 of ‘virt_to_phys’ discards ‘const’ 
> > qualifier from pointer target type
> >
> 
> The change looks fine, and this is clearly useful for spreading
> more 'const' annotations, but I have two concerns:
> 
> - I'd really like this to be done consistently across architectures,
>   so at least the asm-generic/io.h version should get the same
>   annotation, or ideally all of them in one patch.
> 

Sure, let me come up with the a series to cover other architectures.

> - I would not describe this change itself as "hardening", as it
>   also does the opposite, when you have a pointer that is actually
>   "const" but converting it through virt_to_phys() and back
>   through phys_to_virt() ends up losing the annotation.
>

Indeen, I didn't think about this way.
Let me then just state what the change does (i.e. "Make virt_to_phys to
allow unmutable pointers"), unless you have a better option to advice.

Thanks,
Stanislav

>      Arnd