Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1682327030-25535-1-git-send-email-quic_rohiagar@quicinc.com>
 <1682327030-25535-3-git-send-email-quic_rohiagar@quicinc.com>
 <ZEk9lySMZcrRZYwX@surfacebook> <66158251-6934-a07f-4b82-4deaa76fa482@quicinc.com>
In-Reply-To: <66158251-6934-a07f-4b82-4deaa76fa482@quicinc.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 26 Apr 2023 19:42:13 +0300
Message-ID: <CAHp75VcCAOD3utLjjXeQ97nGcUTm7pic5F52+e7cJDxpDXwttA@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
        manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 26, 2023 at 6:18=E2=80=AFPM Rohit Agarwal <quic_rohiagar@quicin=
c.com> wrote:
> On 4/26/2023 8:34 PM, andy.shevchenko@gmail.com wrote:
> > Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti:

...

> >> +#define FUNCTION(fname)                                              =
       \
> >> +    [msm_mux_##fname] =3D {                                          =
 \
> >> +            .name =3D #fname,                                        =
 \
> >> +            .groups =3D fname##_groups,                              =
 \
> >> +    .ngroups =3D ARRAY_SIZE(fname##_groups),                         =
 \
> >> +    }
> > PINCTRL_PINFUNCTION() ?
> Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP=
"?

Yes, please.

--=20
With Best Regards,
Andy Shevchenko