Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1103717rwr; Wed, 26 Apr 2023 10:05:50 -0700 (PDT) X-Google-Smtp-Source: AKy350aWt0MWgFUOZaMnPGsonnh8UZpktfRpjBZH3Z0s6hZXIOY0Y2qHjsD5LCG1tmF/TXARg+er X-Received: by 2002:a05:6a00:1301:b0:63d:2b95:5476 with SMTP id j1-20020a056a00130100b0063d2b955476mr31107436pfu.23.1682528749830; Wed, 26 Apr 2023 10:05:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682528749; cv=none; d=google.com; s=arc-20160816; b=vDLekvAtwr56c4A2GtjWPMRuKbe2A/Lv5aX0qEip1XCJaglwUEEufVMj6tlyV9Beby 5Vt8KRBz5fwHwEcmLpgS33lWGUSzf2sru82KywX9qK6ejlZsjlWiyQXwqrLXujCCSXBl Zzr4GN5yZwzl4FQzg6I3BO58raLcH3skSVldMOf8URmKLT6zq3Ws/TFicOoEO30Y8nB7 /8tZ5N67XpJuBZDBRTpbgMBl6K8hyG/wanm0WXS9GGYksrbJDzXlo3WW9QCS6M5LP1fx kGqw4SaRBJfsM8ZUVTveS3lvd282K0eaW8s0C5f5S2E286iP3n/a2jxDjR4Q2RfW6sh/ SRkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R8tFVruHCR7iqeUzX56V8O1iXguuJVdoNbWvHu2Vu1k=; b=Pd1LAJBQyvCuUbfAp1SIX8Ng9ANJpdgOfknKhsGUtxwSfTSWJQ0Ox/Pe0gnHYzRolM G4IyLhPGWrXyQFt8PmzGGkKlS5EIPJCH8WATE7i7vVsCaOoBDjMhtJzvgEB7aK9GwWQx iQT2d4/iPvGYXk/5muGa4Y84GkoJh9c2hXpLUfuvWJCAQUdc7t3ahEOcSdBXbBWa5Dds eUfGZ7lMc2EIAhed+0A+dOAfFobZwvmcaBrtWWm0Jlv4q+jMPu9T6YLzktOB+eryM9WF zUg80EMfjQoqNpUTso405GsdGgeS4xnkKwFf21n+KuEfxKBdUgtkCiNa6LZSZmpkxuvz OuOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nyu.edu header.s=20180315 header.b=z28v6kKl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nyu.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a63d641000000b0050b3083b64fsi15974335pgj.429.2023.04.26.10.05.37; Wed, 26 Apr 2023 10:05:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nyu.edu header.s=20180315 header.b=z28v6kKl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nyu.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233686AbjDZREI (ORCPT + 99 others); Wed, 26 Apr 2023 13:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjDZREH (ORCPT ); Wed, 26 Apr 2023 13:04:07 -0400 Received: from mx0b-00256a01.pphosted.com (mx0a-00256a01.pphosted.com [148.163.150.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDF57DAC for ; Wed, 26 Apr 2023 10:04:05 -0700 (PDT) Received: from pps.filterd (m0142700.ppops.net [127.0.0.1]) by mx0b-00256a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33QGvXVc007216 for ; Wed, 26 Apr 2023 13:04:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nyu.edu; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=20180315; bh=R8tFVruHCR7iqeUzX56V8O1iXguuJVdoNbWvHu2Vu1k=; b=z28v6kKl4SOzb+YllBcxteKDlF4KamWE3aM/D+/5zRJhEfxY5YRLcxZ4yFeswCe8VrW0 at7m6oCBFWzNV1DUD/QP64zUjkyMVYXdpPl2E13LDec0G5AGRceQ7g/VVy1px53sYzc1 SrZYJZxTMt4wFYpk8qxRw8ViiYfueQ7vjYNosIChHdj+R49nynkNIalPiKqr29G2o0OF wdg1wLGDmntoY3/lRXURZbz+SFhWReowgSs2pZTQfVejnd5bf0R8nG6YFaFDT5uvl3Em M0HTsP09uKeXF7x3kV+imGOgRL+TqQyffvG9S+/JzRfx0wwmEp7hKMFbusRTXOGuh7od tg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0b-00256a01.pphosted.com (PPS) with ESMTPS id 3q60k86j49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 26 Apr 2023 13:04:05 -0400 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3ef27f257d0so85447211cf.2 for ; Wed, 26 Apr 2023 10:04:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682528644; x=1685120644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R8tFVruHCR7iqeUzX56V8O1iXguuJVdoNbWvHu2Vu1k=; b=eW1u5zICDfyPG83dcgrNsN7RkS0dAtNwO24LW1njoEd1I9wqX1uzmRg92mtWto4Mgi FK8cgXEIsR3lgRrvL2OvceB9zgZlxuOSViYpRpDYSrmgasmAFS8uzNbuXW0p7Gq07wE9 EO2ZqWu6PrRVw9Qv+hOGIe7FJd3Q+2/jHQVoMTPvHyicweMecQWVwfQHngqSaq33aRHi Rl2jUPIGMWhGkXhyIxzCuxPuaDTSiWVvirN5wKEOuFY0B6hkw63J+BMDEPmccefqEzMa xVcR2/zDDSYc51NTIWwGMoewBV1DfO6CRKhgSCa/jE9Z8OX+SPonEb+ua6dU3DrDmHgE UeUQ== X-Gm-Message-State: AAQBX9ergO2egIHSUSQnaDCGy02/V6S/n8BXwxtVu2Rebuf7daxqsUBN 02zMztjvcGfkw1JOItxW0wf6+z4dBsmupuQI93b36grPgNjWtnm58VdmERMh/9PIiYcl/ONaQPN JmlQOgpeG/uGkhaJZzskRgWY= X-Received: by 2002:a05:622a:248:b0:3f0:a511:1762 with SMTP id c8-20020a05622a024800b003f0a5111762mr17625427qtx.18.1682528644139; Wed, 26 Apr 2023 10:04:04 -0700 (PDT) X-Received: by 2002:a05:622a:248:b0:3f0:a511:1762 with SMTP id c8-20020a05622a024800b003f0a5111762mr17625385qtx.18.1682528643790; Wed, 26 Apr 2023 10:04:03 -0700 (PDT) Received: from enviable.nyu.edu (216-165-95-144.natpool.nyu.edu. [216.165.95.144]) by smtp.gmail.com with ESMTPSA id v9-20020a05622a188900b003ef467f4fe1sm5466241qtc.88.2023.04.26.10.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 10:04:03 -0700 (PDT) From: Jonathan Singer To: hdegoede@redhat.com Cc: Mario.Limonciello@amd.com, jes965@nyu.edu, jorge.lopez2@hp.com, kai.heng.feng@canonical.com, linux-kernel@vger.kernel.org, markgross@kernel.org, platform-driver-x86@vger.kernel.org, rishitbansal0@gmail.com Subject: Re: [PATCH v2 1/2] platform/x86: hp-wmi: Add HP WMI camera switch Date: Wed, 26 Apr 2023 12:49:38 -0400 Message-Id: <20230426164936.8807-1-jes965@nyu.edu> X-Mailer: git-send-email 2.40.0 In-Reply-To: <0b609a22-5da3-8305-ac93-caf1a0265170@redhat.com> References: <0b609a22-5da3-8305-ac93-caf1a0265170@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: wnEsuLCn76LWovj489h3rfQN5aZ7l_Jd X-Proofpoint-GUID: wnEsuLCn76LWovj489h3rfQN5aZ7l_Jd X-Orig-IP: 209.85.160.200 X-Proofpoint-Spam-Details: rule=outbound_bp_notspam policy=outbound_bp score=0 mlxscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 mlxlogscore=649 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260151 X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On Wed, 26 Apr 2023 18:09:13 +0200, Hans de Goede wrote > I assume that event_data = 0xff happens when disabling the camera, so > we report SW_CAMERA_LENS_COVER 1 when the camera is disabled, right ? Correct, the 0xff event_data happens when the camera shutter is closed and the 0xfe event happens when the camera shutter is opened. Regards, Jonathan