Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04902f0f-dd67-64e7-4495-ae37ae1a8e01@amd.com>
Date:   Wed, 26 Apr 2023 13:15:12 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: set variable custom_backlight_curve0
 storage-class-specifier to static
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        qingqing.zhuo@amd.com, Josip.Pavic@amd.com, robin.chen@amd.com,
        alex.hung@amd.com, dingchen.zhang@amd.com,
        jiapeng.chong@linux.alibaba.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230426111838.728441-1-trix@redhat.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230426111838.728441-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk4zM2dSbjRNNUxxM3QxaXdOWm94L1lBdG9CYWF4aXNoVU5VYS8vVnlDMmhh?=
 =?utf-8?B?YkhtN282Uk1tTTZHSXdIc2ovbGpBd0JMcVBpVmhsWXhnVGVXM3d2WnhzY3hG?=
 =?utf-8?B?aUcrZkNoaWJsN05aWFo1QnhSelM3ekhjT2djRDRYSE8xRjVJYnBId0JHa01x?=
 =?utf-8?B?c1R3cVFrM3gxSFdpRkgwcUh5VW1uNGs2d3orS0xZNmdQUldvRGw1TFdTR0N3?=
 =?utf-8?B?NFFFamE3VDZvM0NnQ1FKT2x5MUNHWjAveVZiNTVhSUZOYVZYcDhkeW9acDRW?=
 =?utf-8?B?MFpuUDVUVHVLUXl1Wm81MEpWbURab2RSODRZenZBbWxJNXNQVHFvKzFCU2xJ?=
 =?utf-8?B?ZUNDc0lJb0J6cXRKM0VGY0JBRWZ3YVF5aE9QeVVKRjEvWnV6dmFjcDQ1ejE0?=
 =?utf-8?B?OGF1S0pUNTJ4QlJsSzhOYnhpRWwzazdzMjUzaVBka0xXcTdZMzVPa3RtNFVF?=
 =?utf-8?B?WDR2bUZHY2t0RzdrSVdEYWNpM1NpQlJuQngzUmo4N0o5ODR1cmx5eXZlbXRQ?=
 =?utf-8?B?STI2QnZ3WmwvK0tjeG9JUkF4REJVLzNLeEJUczhTaVJad0tsamlzK3h0VS9n?=
 =?utf-8?B?UDVpQm11aGxUbkMveG85LzFaME5kWnF4WUd3ODVvTlZ1KzVLemYxeENZckJN?=
 =?utf-8?B?Z1BJSW11YUlzeFVLTkhISzhCS2Z5Z0kveGdhazVReXNEZ3BMT2tHc2llcS9p?=
 =?utf-8?B?WHVMcnczbVMwYWw2OTY3RVh0V1l1UHVaYkp3NmtUM0pqR01NNjdtb0laeW52?=
 =?utf-8?B?RnRNY0I5MTc1cTg0Q2lBdjZXL1dJTlNaMzlIL1FYWVJod1U0bDYzSWNoNElU?=
 =?utf-8?B?SEpkT3dLSkx2WkJoZm90VTczVlhlbXU0T1hEWVZveHYyWU5rWTNWQUVQZHpW?=
 =?utf-8?B?dHdLNHpPRGpUTmxvY2RTQ05QN0hibzZaQURvVFJmZVJzNFdiYXlPRXBnSkZ2?=
 =?utf-8?B?NWpISmRGUUZhVjdmS0U1ZWsyK09UWU0waTE4dnp0TnFEVXMwamVzWFpOV1cv?=
 =?utf-8?B?MlpqZXdobDJZMFl5alNtRXR6TVZ4YVdJLzQzSDBEQ3hiQkRKRW5rNlNGV0d3?=
 =?utf-8?B?SGp3OSs3SmEwTk1tcWtSTUJ6NmJVeWFuMVNuYmZNZFBrejFTQVlJNkdDc2Uy?=
 =?utf-8?B?WHJkQmgrQjBobWNDSUtVUmZxaUk1U0dFVzFIRUZFYk9qb1J2QzRlUENHeE9U?=
 =?utf-8?B?L2p4WHczSWEyRDA4WFU1Q0FXUzJRVSs0S3hQbFI2eXZWd3ZhcGxXWVdrYmFM?=
 =?utf-8?B?amVvdENCczdCY3h2VWtEVDYvSTJCWUd2aU9vMkljSkdUcWVlOFNCc3ZZVnRD?=
 =?utf-8?B?bEVFL3R5Y0VlWC9oSFdOck5reURTS0FQWHUyUFRkTE13b1AvVUR5TWEzRjFX?=
 =?utf-8?B?MjZJMWlNeVRoRnROeXhWTzhoek9yaXZPd3lHRWUwVHRwZGdjTmdQc2JRVzhJ?=
 =?utf-8?B?THpmU3UwZHNJSHpqUVRKaWZLQkdrMHhENVRZNEl2SDJ4M2sydDVYUGdGTXdK?=
 =?utf-8?B?d0YwUmZsblVFQ1hwdGlGcnoxM3RWeXV3Y1hQOEErUDN6cTR3UllZTll4cXJx?=
 =?utf-8?B?V0lObzhGSnN1MzdPNzVGVFdMbjdkNTlKZm1Kc1hYZGdqcjFXZ0dNa1l3VFBs?=
 =?utf-8?B?K3ZLUXRENmRqdjVxZVdWT21yTm4xcmJNTlNoRnU0UVVpaWtla1dUeHhMeGdX?=
 =?utf-8?B?WE94TmlTdDE1Tk01bTZpYVpwZjlwRUxvM205aU5Jc1h2b0pxd0d0ME1KaWxo?=
 =?utf-8?B?ZXhYckxCN3FFdDc2YTBZTDlwQnJSTFFHUm5UTndqSXVkeGVOdVFZdDhleC9Q?=
 =?utf-8?B?RWpiVk1JVHY4bk16N2lTaEo1TStldkdGRXZTWTBjUlJvMG9VSUtzR1hTK3RM?=
 =?utf-8?B?bllOSW9qNkhVSHN4ZWVhTlM1R1NKdkc0TDVxTUZNWTlQNFluRktpWjhoMGhT?=
 =?utf-8?B?UEpKN2o2N2FYQ1FRdkFqSGV4TVllc2ZEanEvZUU5R2QvYVpOWXBCTEVYM1VK?=
 =?utf-8?B?SUthRnVFUnRiRHdKN0N6VS90U1BtUitNWTZRb05KZDNzbXIyQWJXRDNWN2Nz?=
 =?utf-8?B?RU82Q0RiZHlaUWVONkF5bi9Pb2N2T0g3cUg0VmNjaXBxa3c0NVVOdExJT1A0?=
 =?utf-8?Q?VZTTOElnYA8tEmwKjhClP4YFO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fd39b0f-dbcc-42d6-bd77-08db46799892
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 17:13:47.0370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: syVCZ4by6RPf2YOJ9Ar5xmXEwTrGxdVOIqcc3sto0hqehYNlsihAAo+f64R+5qKgGiS3V1GQhfzoQXvuIHIURQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6816
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/26/23 07:18, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31:
>    warning: symbol 'custom_backlight_curve0' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> index 68d95b92df76..30349881a283 100644
> --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> @@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = {
>   	abm_settings_config2,
>   };
>   
> -const struct dm_bl_data_point custom_backlight_curve0[] = {
> +static const struct dm_bl_data_point custom_backlight_curve0[] = {
>   		{2, 14}, {4, 16}, {6, 18}, {8, 21}, {10, 23}, {12, 26}, {14, 29}, {16, 32}, {18, 35},
>   		{20, 38}, {22, 41}, {24, 44}, {26, 48}, {28, 52}, {30, 55}, {32, 59}, {34, 62},
>   		{36, 67}, {38, 71}, {40, 75}, {42, 80}, {44, 84}, {46, 88}, {48, 93}, {50, 98},
-- 
Hamza