Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Apr 2023 19:47:28 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     "Mendez, Judith" <jm@ti.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Schuyler Patton <spatton@ti.com>, Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v2 1/4] can: m_can: Add hrtimer to generate software
 interrupt
Message-ID: <20230426-engine-pueblo-9967197ace5a-mkl@pengutronix.de>
References: <20230424195402.516-1-jm@ti.com>
 <20230424195402.516-2-jm@ti.com>
 <20230424-canon-primal-ece722b184d4-mkl@pengutronix.de>
 <0261131b-35b5-4570-0283-651432a9d537@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sy6skchj6wehju3r"
Content-Disposition: inline
In-Reply-To: <0261131b-35b5-4570-0283-651432a9d537@ti.com>
Precedence: bulk


--sy6skchj6wehju3r
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.04.2023 11:11:12, Mendez, Judith wrote:
[...]
> > print a proper error message using dev_err_probe("IRQ %s not found and
> > polling not activated\n")
> >=20
> Why %s when MCAN requests 1 IRQ which is "int0"? If we want to print "int=
0",
> should it be hardcoded into the print error message?

I think I copied the error message from platform_get_irq_byname() and
extended it. Of course it makes sense to hardcode the IRQ name.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--sy6skchj6wehju3r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmRJY64ACgkQvlAcSiqK
BOg2Bgf/XL6ENIVYIeH/OuUT86EybAyKIzENCqwDozaSalVYGwgnuG3umI+/cLfW
Vw1/8IBXKkoC5YN8KPt+Kkjbc1FF8H1SC495I8qW2f2IJ605BArcF5/LZOqSB/s2
ekqNjshR9Y5EJBVa/Lmlskq/H2UuQI7+/Z47aEPyS3OpVNbvLktJkgdVjxQLJHa9
tFW28wcyBEvaM2lUaVnqYZ8lDmWp+poAEOBGxwGpX9OZjDGtzDwwEJysL4MsEkRs
PSt4a0m1MdjJvmsi3dIc7rIrMm5FEBYSNmBA4/btjkfx2HdyGhWTC3mDQHHLCCIx
zDaCyzB/YLEZmndoh0zOPK3uX6XwGQ==
=Z3Pe
-----END PGP SIGNATURE-----

--sy6skchj6wehju3r--