Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
        "Simek, Michal" <michal.simek@amd.com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
Subject: RE: [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_02
 with RGMII tuning
Thread-Topic: [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_02
 with RGMII tuning
Thread-Index: AQHZeCv6AGCFWckldUa9v4r2nKGr6K89cUQagAAJECCAAClIgIAANeFQ
Date:   Wed, 26 Apr 2023 17:39:43 +0000
Message-ID: <BYAPR12MB4773EC5AC6DBEEE7BF0E08239E659@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230426104313.28950-1-harini.katakam@amd.com>
 <20230426104313.28950-1-harini.katakam@amd.com>
 <20230426104313.28950-4-harini.katakam@amd.com>
 <20230426104313.28950-4-harini.katakam@amd.com>
 <20230426111809.s647kol4dmas46io@skbuf>
 <BYAPR12MB47738A21AE76E4CDEE28DFFF9E659@BYAPR12MB4773.namprd12.prod.outlook.com>
 <20230426141831.cxurksrsnj2c47vv@skbuf>
In-Reply-To: <20230426141831.cxurksrsnj2c47vv@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mO+snv3Hp5R6phLFJZr7PHHvqLa6gCQVAGNEDuj95gJ09DUAVHuQuRAoKoQU?=
 =?us-ascii?Q?iM6rqfUOVsh2Q2Xq7Xd60iRpWyWB81p/w7EQ+gkiAMQJa1YukK1+nWKuxf4c?=
 =?us-ascii?Q?QolygVF/R+3EtWudE/d180HUeRUvVitiCanfWJdO4x6pXH2fhHM9xJjmXtI6?=
 =?us-ascii?Q?51gW/UcyFhd5x99jJQjRznM8rtGyoDej+C38PVkr8Fid4/3vPP5nwY2o9EET?=
 =?us-ascii?Q?fzZMorePx/JM3/GdEn6qoa9eDknOQlUMr7MWRAnn/J2MWiUhOzdpOKL1AaqS?=
 =?us-ascii?Q?aa6bkRetnRvs/2ftXNK2M0udHN9wqEw1LHyGBzir291L+fErUMjbSPUK0otp?=
 =?us-ascii?Q?yE5M4hrfuIuGCovfVOidXAaYAPe6TS7VEbRiFQO+PQJk+mX+xLMxUnhzuEO0?=
 =?us-ascii?Q?SDAD12mpVWc4SQRI0p0NG2IHg77RHEUBM2RmFbz/SRPq7sb35yrD/5jAsRDk?=
 =?us-ascii?Q?jmE1XcP5ENuH321CMJZUJcbugm22dWmMbasqf47GaUkNOO/mgR8uyZtESuQ0?=
 =?us-ascii?Q?Un95H8RlWHl3KChAeH27cpP6vajgOp7RlZvupC4FCFSyV6shfVArQSeVIeLl?=
 =?us-ascii?Q?bzgZ8rYSWOgbvKpenrIInz5k8ZPTs+sMXOQuh9lJ4poWbJXI7kKlOTOLO1hZ?=
 =?us-ascii?Q?4p6YYl3jXzp5c2txOw9Tu7cZJbgS5OzsmeQ2eAVoIM0b4u2+sFlEC6uRCsnG?=
 =?us-ascii?Q?x40N2yBiOHyEBuaysK5d9i2tsPXqyyYMdXnT9+rlDAaGXuKNIlaL+MYxB1NQ?=
 =?us-ascii?Q?1IuVVWB5XKhuyzodDe3uSrkhjO40Oc6i8LLVRLAUOxzeGZsZalWD/Af2Ac9K?=
 =?us-ascii?Q?hQiKtgWO00oqVfy0xz4+fGGsarzbRvAt2NsuMSGZveQq5rKOzMb2GsGOmVtg?=
 =?us-ascii?Q?a9hMw6Gg7cgXt8PL/fAuMZXyY4JRWnHoIUbe/gIm7GjO+n/2GoC/qO4cP2lo?=
 =?us-ascii?Q?oyLmhBo8pdBbIH9j1dSExg6DA5vgPNL++/ygANPbgCo8DLlP8jhV9exLmxLK?=
 =?us-ascii?Q?sZMYznV+3K9YJ7UFhhIouou+K8ox4zmYXEMWpQdznL6gxMe/YZPq1wzPsNWn?=
 =?us-ascii?Q?CNaAXd+WQyDqoiUs1ksd4nLVMQvA/9nX85le+RLcPH6kvvy6VIIAvENcDAMA?=
 =?us-ascii?Q?Kzm1yPp2vUYeIw+Qv7eK7SWEqMMTHPu0s4IDt+Cl1hd4CHQgfdZG13JMdAhf?=
 =?us-ascii?Q?o3DGdNAFXHexTmnaoinbCLFDalH75mvgfV6MlCR1s/zsF1rE24WcwPsNAj4c?=
 =?us-ascii?Q?ouTV2NhRX7ZJ4OrNKEYO4JLXFl3bRRYh2OvyOhtR1fuy2j4j9NiytG4/G/h5?=
 =?us-ascii?Q?UctVmgI1GgMxqtE9S99meNyDcBbWR8X/yOeWCJBYoMLHF9Sm2NKBFtUcR5nT?=
 =?us-ascii?Q?EWVk9vriYGI4hkQbHTVmctAdSG9CiHim1vYUVxL03qttR/W7C0FWLxQsusll?=
 =?us-ascii?Q?Xj+J795/1kbLcWKNr1yp2K+XYfycQd3zNFMvv8u3/c75L0L5W8Yg9Cr4AnVX?=
 =?us-ascii?Q?cw62mDxtJj694M4R/s/z7b02SUbokLdtApyYhPswoDKu3p8TO1CKgSEPd/ew?=
 =?us-ascii?Q?o0/OwxWJCHrxL9R8NMk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 710c4a68-cdae-48a6-42d4-08db467d38bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 17:39:43.9375
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nht4MJojBTjI3eygKW+zPvPvxS9uIVevV82lMUmmjuUkLueR1+/Ik1wyWbgcOVVc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4580
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> Sent: Wednesday, April 26, 2023 7:49 PM
> To: Katakam, Harini <harini.katakam@amd.com>
> Cc: robh+dt@kernel.org; andrew@lunn.ch; hkallweit1@gmail.com;
> linux@armlinux.org.uk; davem@davemloft.net; kuba@kernel.org;
> edumazet@google.com; pabeni@redhat.com; wsa+renesas@sang-
> engineering.com; krzysztof.kozlowski+dt@linaro.org;
> simon.horman@corigine.com; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> harinikatakamlinux@gmail.com; Simek, Michal <michal.simek@amd.com>;
> Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Subject: Re: [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_0=
2
> with RGMII tuning
>=20
> On Wed, Apr 26, 2023 at 12:21:47PM +0000, Katakam, Harini wrote:
> > Thanks for the review.
> > The intention is to have the following precedence (I'll rephrase the
> > commit if required)
> > -> If phy-mode is rgmii, current behavior persists for all devices If
> > -> phy-mode is rgmii-id/rgmii-rxid/rgmii-txid, current behavior
> > -> persists for all devices
> > (i.e. delay of RGMII_CLK_DELAY_2_0_NS)
> > -> If phy-mode is rgmii-id/rgmii-rxid/rgmii-txid AND
> > -> rx-internal-delay-ps/tx-internal-delay-ps
> > is defined, then the value from DT is considered instead of 2ns. (NOT
> > irrespective of phy-mode)
> >
> > I'm checking the phy drivers that use phy_get_internal_delay and the
> > description phy-mode in ethernet-controller.yaml and
> > rx/tx-internal-delay-ps in ethernet-phy.yaml. It does look like the abo=
ve is
> allowed. Please do let me know otherwise.
>=20
> I understood what your intention was. What I meant was:
>=20
>  phy-mode                       rgmii                          rgmii-rxid=
/rgmii-id
>  ------------------------------------------------------------------------=
--------------------
>  rx-internal-delay-ps absent    0.2 ns                         2 ns
>  rx-internal-delay-ps present   follow rx-internal-delay-ps    follow rx-=
internal-
> delay-ps
>=20
> I agree with Andrew that probably there isn't consistency among PHY drive=
rs
> for this interpretation - see dp83822 vs intel-xway for example.

Thanks, yes I noticed the difference here and also in older PHY drivers tha=
t
used custom properties (see dp83867 which is what I originally aligned it t=
o).
But the table you mentioned above makes sense; I'll re-spin accordingly.

> My interpretation was based on the wording from the dt-bindings document,
> which seems to suggest that rx-internal-delay-ps takes precedence.

OK I understand.

Regards,
Harini