Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Apr 2023 20:29:08 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     andy.shevchenko@gmail.com
Cc:     Tony Lindgren <tony@atomide.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [BISECTED REGRESSION] OMAP1 GPIO breakage
Message-ID: <20230426202908.17b55974@aktux>
In-Reply-To: <ZEkCg-WqwBHVZwHC@surfacebook>
References: <20230425173241.GF444508@darkstar.musicnaut.iki.fi>
        <20230425201117.457f224c@aktux>
        <20230425183857.GG444508@darkstar.musicnaut.iki.fi>
        <20230425212040.5a4d5b09@aktux>
        <20230425193637.GH444508@darkstar.musicnaut.iki.fi>
        <20230425215848.247a936a@aktux>
        <20230426071910.GE14287@atomide.com>
        <20230426093920.3e9b5c61@aktux>
        <ZEkCg-WqwBHVZwHC@surfacebook>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 26 Apr 2023 13:52:51 +0300
andy.shevchenko@gmail.com wrote:

> Wed, Apr 26, 2023 at 09:39:20AM +0200, Andreas Kemnade kirjoitti:
> > On Wed, 26 Apr 2023 10:19:10 +0300
> > Tony Lindgren <tony@atomide.com> wrote:  
> > > * Andreas Kemnade <andreas@kemnade.info> [230425 19:58]:  
> > > > On Tue, 25 Apr 2023 22:36:37 +0300
> > > > Aaro Koskinen <aaro.koskinen@iki.fi> wrote:  
> > > > > On Tue, Apr 25, 2023 at 09:20:40PM +0200, Andreas Kemnade wrote:    
> > > > > > Aaro Koskinen <aaro.koskinen@iki.fi> wrote:      
> 
> ...
[...]
> > I think the reason for the patch (besides of cleaning up warnings) is that
> > dynamic allocation seems to start at 512, static at zero.
> > If both are there, like registering twl_gpio between omap gpiochip 4 and 5,
> > dynamic allocation seems just to start after the last static number,
> > calling for trouble.
> > 
> > If dynamic alloc would just start at 512 in that case too, no problem would appear.
> > As said I have not bisected it to an exact commit yet.
> > So if we need to move backward, we should IMHO first fix that allocation thing.  
> 
> I agree.
> 
> As PoC can the reported add the following lines
> 
> 	if (gdev->base < GPIO_DYNAMIC_BASE)
> 		continue;
>  
> after https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.c#L190
> and test your idea?
> 
> 
yes,
looking at git blame
7b61212f2a07a ("gpiolib: Get rid of ARCH_NR_GPIOS")

would probably have been the correct Fixes-tag for for that patch (and
will be for the new approach to fix it) and its intention was exactly
what we are talking about.

I will test.

Regards,
Andreas