Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07e05c57-feb7-5482-9c07-eb41f976f9fd@meta.com>
Date:   Wed, 26 Apr 2023 14:47:27 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH v2] libbpf: Improve version handling when attaching uprobe
To:     Espen Grindhaug <espen.grindhaug@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
References: <ZEV/EzOM+TJomP66@eg>
Content-Language: en-US
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <ZEV/EzOM+TJomP66@eg>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yy9XY1VRNEtHbGcvOXJYOXltV2lPM2JPVkJFKytxVVBPRmxFQVkzdlJWamJM?=
 =?utf-8?B?ODZMdGtsQ0h0cFhMNk5naVhoY1EvWFZtWGV5RldabUhZamtzL1lpSGpMRlR2?=
 =?utf-8?B?VGF6YU5iRDFCZ3RMdEMzSlpQaXBSWHRQM0RyakJpbkZGZFVjeEhkdG4veFRD?=
 =?utf-8?B?WGxrV1RIbCthVHVkVENCMHhJN3dXLys0d0FyVTQyNHBWTEMvSTZQN25vTXgv?=
 =?utf-8?B?RU15N3dwWXpnRHBXWkhheUtQSE5UNWhHUzJkSndlbVoyZTN0c1FpTldzK3VB?=
 =?utf-8?B?cGFoMFNOem55VGhLWFlZTURTdFo4MUdkUE1JRUZwdlNxdGFCSlBXdHhGOUFD?=
 =?utf-8?B?QjhRZ2hDUTV2b3dmMlUvM25kZHNBVEJpWE16SEpsZG5raXlrY3RHL3RmWFV6?=
 =?utf-8?B?Q0pBM3hXYmV3YXZuSi9lR0FBSmZjVTN1KzdSbW1XRWF4ZWF3TnQxZEV3aU40?=
 =?utf-8?B?SVI5Y1UySGFtVXlncVArU3VQRHJIUFU5OG1kYTN3VWk5YVNYZ09vZmVtNUNH?=
 =?utf-8?B?R3NKRUZHWnBWM0lzL2c3bjBaWm5ZenU1bjVBa2tGVnNOM1RNejFlSC9EcWV3?=
 =?utf-8?B?OXdmOVJJUU9Fd3cxTGhjNmpCMG5STTdmZk1GNkh3bnBXeHdFNnUyUjZuT3A4?=
 =?utf-8?B?NXI1Zk04ZXk4UldmbGRUQUF5eWltWm8vWGZhS1RBTnZCVjBLZlJjaWo4czhC?=
 =?utf-8?B?dUJYMVVlY3FPQStwdmdkdkpZOHp0dVJRbEVQYXRTWlIwVzJIdDBtNHJ4OEF6?=
 =?utf-8?B?M25yUE5EdDBkQ0kvdUc5R1N0dFVDZ3RiODQ1SHlSQ1VCWGRvRWM3QklHa0tU?=
 =?utf-8?B?eDVvTEU5US8yeXFhcElURGR0MXNPU3ZYUTBCblFsbzFFUGtVK2Roam94Q2NC?=
 =?utf-8?B?U3Q5aTdMTUZEMlFqc3BmSExSMTZmVTF6L0dYdk1iRGRFRnFFdUhwTEM3c1F4?=
 =?utf-8?B?SThxdStqeWZlL2VuT3J2dG1PMGkxdnluQzFhVkJVNEp4eUpVVDlYZ0FRb2g2?=
 =?utf-8?B?YUhLOUhvd2h6M2NZQVY5MWtwb2JQSkh4ZzRkZHY4SWdqUUxBMEdpVTVScnpP?=
 =?utf-8?B?NEJkNmpqUGNBcnZ4Rm02eFh6OEVvb09NWkc3clZTdjZuY2NDb1c1cFlnUUZH?=
 =?utf-8?B?Vk5jM1R1WlJzWStYRVV2eURJZmF0ejBlZU00aG9vd1ZWa1JLNFFYZGhOV1dJ?=
 =?utf-8?B?RVFaTlh1OURxYUd5aVdFWGs2em1WTFQvRDBmeS91eWNUcUY3cGlvd0gzR2J3?=
 =?utf-8?B?b3Fwa2g5V0VXcDNYSS9XS1VYbWlTV0Y0dkUyZDlOQTZJT0JhR1dqYmhKRE9x?=
 =?utf-8?B?dXJ3TGY0czRramNQSEg3QldZR2pMNFFucWFPN29GWW5TMXR5elJDK2FvdzE0?=
 =?utf-8?B?VUIreFljSWxBQzlGNXFWMEl2MlVodDk2V3JXbXVFUVVGZVRVZWtFbWt3aktz?=
 =?utf-8?B?ZWJsZzkrcFpLK2d4Y1pDZGhpMitxM1J5UGN1ckdhSnFpQXgrVDIzeEFQVmla?=
 =?utf-8?B?WGNnYU5WckM3TTlRQ09mM0ZkTjVnaXpsL2JVb2JJb0VmZXZKVmZ2dEIydWJB?=
 =?utf-8?B?cGpHMHRHQ2xZeDdsa2k4a3ZSSXVId2hFVmJxWmlmRFRzRERUQ0dna1BYUlB6?=
 =?utf-8?B?QXdETVk1bjVQRE9nbDdvN1RWWml4K1ZBYW9Ld3RWeUVFQUpKMGxrNWQ0M2RG?=
 =?utf-8?B?bjk5NUZNaGRQMFcreENsZ3dMVkthNC9PMnhsVTFRaXJHVDgyZzZDSW9GRDA0?=
 =?utf-8?B?U1k1ZkVpQVRNbTJYNmN1b01nb2dkUTByMTI5T2xDZzZDVjkvZ043MzZPOFBG?=
 =?utf-8?B?RVcwdU14UkxLa1Z0K3lrNWZ5U2k3c3lMQlUxcmo1Yyt0bXB2MHVhRElXaEdL?=
 =?utf-8?B?Vjk5RmtlU2RXR1M2d0N2S3BoeHpEeGlPam5JbmlNK2l1SkV0QzhOS3hTN2pY?=
 =?utf-8?B?WVYyMEQ5amhLWDljaTcvQVpzQkQvZVlsTkpkeTNaeVFqVTdFNXJCNTdZQlVq?=
 =?utf-8?B?d3NzYzlmQm9NdzFhUjd0Q0lQdndUVi9oeVc3NitUKy85RmowZ0IxZmwyb1dx?=
 =?utf-8?B?c3g5MHhtTXc1U3UwVVlMNlNJNnBkY004U0o2Y29nTWlVQjc4UDRBT2RobWha?=
 =?utf-8?B?UFlObEpOZmZoR1lVemlUa05FWUhsT2o2azYwUUdzeHA4UFc1VzNPRmZFUFpN?=
 =?utf-8?B?TlE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc6c0ada-419e-4b99-738a-08db469fd6b0
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 21:47:32.1487
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KkR4q45NeNpthnkxHGS0lNjAG1SD76qSA8nsCtb7ABrLB97vp7xlhfn4BWsmh9GN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR15MB5268
X-Proofpoint-ORIG-GUID: sOz-I6c_0tspLBeR7QXQFotuqwCtc1_6
X-Proofpoint-GUID: sOz-I6c_0tspLBeR7QXQFotuqwCtc1_6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-26_10,2023-04-26_03,2023-02-09_01
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/23/23 11:55 AM, Espen Grindhaug wrote:
> This change fixes the handling of versions in elf_find_func_offset.
> In the previous implementation, we incorrectly assumed that the

Could you give more explanation/example in the commit message
what does 'incorrectly' mean here? In which situations the
current libbpf implementation will not be correct?

> version information would be present in the string found in the
> string table.
> 
> We now look up the correct version string in the version symbol
> table before constructing the full name and then comparing.
> 
> This patch adds support for both name@version and name@@version to
> match output of the various elf parsers.
> 
> Signed-off-by: Espen Grindhaug <espen.grindhaug@gmail.com>

[...]