Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1496214rwr; Wed, 26 Apr 2023 16:23:32 -0700 (PDT) X-Google-Smtp-Source: AKy350bi07ry67Fn4aOpvJ3JDp89D9ZMBP99Mg6uTWKCheChE4RWRKPnS9U8PkPMaVbnw93KLr69 X-Received: by 2002:a17:903:1d1:b0:19a:b754:4053 with SMTP id e17-20020a17090301d100b0019ab7544053mr28516415plh.26.1682551411802; Wed, 26 Apr 2023 16:23:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682551411; cv=none; d=google.com; s=arc-20160816; b=xqRYHJ69Iwy/inzHukXT/3eKYZDLgPVfQmuu/r6kcNVXPQIOR0eIauGHE10l95qJg2 4OsSZ7xcTgz9NHief6kuzM1nU3io3NoNJfw6o02svyf7E+gmtTlcmtt48yN5AsodBx0Q 5s3HV4EJREc2txtAkEi7WFI9ECxOWFzxGYF8k/ReR1gcQcTV+LhdTTdNIifktZcIMyrE Ehxg/kQDMxv0git4IQCgF5PXvAnYqg87bksIWFNRYiO+6ofySc5P5fLA30uDThqNybVH 5Eh9akvM+fI5MhV/wcc6pjOGiXC5B14gQa9Cq9MbZM07d+azAOkfbs91ByHS3uMcuqgC Ptgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=KF3B8hCCEahyE94HKCr+ciYc1/C7c3zG8HUkJG8bWOE=; b=lvKti0qdKe1BKHJTwucxI68Uvv+F3mRbNcr+9UPM2s2sDTbUNibZ8d159LU9vivyev /jwZUMAvCZAUIk1WLAQKpO9iLGogyN/SpmQ6EcKOpodLWhk/mxmigOWol4GpxmsIBcPW nMaoXyrzq3DIih5JHpYu5PbmMjGwxj0N3uZFpbMZ7izfkPWaYXiPzHB9ke0GOt41DMFu mNHLgCC4G26Sc7q//WlsQ7iGhYWwKYtxi61FKv2r2XgblNLPyIXnVjXn2g3NPkY952/c xxJawugLHC4Wm1Gn6/HRTzhZ1Qz5Jrkb8DngsnjxVZ/Mc/XjyCv8IG+9wN0ylyOpeGhU nxug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=o6cohrkr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ik1-20020a170902ab0100b001a6dc4f4a7csi16858046plb.147.2023.04.26.16.22.52; Wed, 26 Apr 2023 16:23:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=o6cohrkr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239466AbjDZXMv (ORCPT + 99 others); Wed, 26 Apr 2023 19:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233381AbjDZXMt (ORCPT ); Wed, 26 Apr 2023 19:12:49 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 855EE358E; Wed, 26 Apr 2023 16:12:45 -0700 (PDT) Date: Thu, 27 Apr 2023 01:12:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1682550763; bh=PZpGk7rRCt4ehhsgRDpHyzzOzPQu1DqqumRtK7iBeaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o6cohrkryZuf2TEO3R1+ptwvr0tzx/Eruz4XzqF+/nOK+tLgT1+RZvdRwByxTaHkg xdfNIY8ols2G3HgPepKW+dphh6lUzcS9zAhjx/0jaddQsgOXXyy7/EMLSRu9hHpFKd jy1+G6JiX8uVeZlt6NUjISZTkOZK+dCIPUyo36ys= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: "Martin K. Petersen" , Jens Axboe , Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk Message-ID: <862c1901-ee6e-44e5-8906-4bb1c3893372@t-8ch.de> References: <20230309-kobj_release-gendisk_integrity-v3-0-ceccb4493c46@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, Christoph, Jens, On 2023-03-20 07:56:58-0400, Martin K. Petersen wrote: > > The embedded member integrity_kobj member of struct gendisk violates > > the assumption of the driver core that only one struct kobject should > > be embedded into another object and then manages its lifetime. > > > > As the integrity_kobj is only used to hold a few sysfs attributes it > > can be replaced by direct device_attributes and removed. > > Looks good to me and passed a quick test on a couple of systems. Thanks > for cleaning this up! > > Reviewed-by: Martin K. Petersen Am I getting some part of the process for block/ wrong? It seems my patches for the block subsystem are having a hard time getting merged. * https://lore.kernel.org/all/20221110052438.2188-1-linux@weissschuh.net/ * this series * https://lore.kernel.org/all/20230419-const-partition-v2-0-817b58f85cd1@weissschuh.net/ Thanks for any pointers, Thomas