Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Apr 2023 20:01:43 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Fei Shao <fshao@chromium.org>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: goodix: Add
 "goodix,no-reset-during-suspend" property
Message-ID: <ZEnJd5ph4LCGPBwF@nixie71>
References: <20230426144423.2820826-1-fshao@chromium.org>
 <20230426144423.2820826-2-fshao@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230426144423.2820826-2-fshao@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FQvi1j2XkgTFeMX4Btg2Rp/0P942nVpk46hwdSR58aNTAsaWan2u49r7JwXg?=
 =?us-ascii?Q?aSWGBmXQva2D4PCqfHLkapsqhNXj22dj8BNJkvs6bxY9V838i3+z7t2kn4A+?=
 =?us-ascii?Q?Jfrsd6SdHEZd9ZyVaNeSHu9hdN054lqwjEEATJ5oPofwCRbd8MIl/mo8tgXY?=
 =?us-ascii?Q?zOEIwPpy3DjRCkKdsnqazSYS1Mmh/G/CjZ9UVvOMfLn6fRB8RgdNQWYsa/jE?=
 =?us-ascii?Q?VWuOX4ejn7BQelLPAq2vsPf2T60b4KpSuXTMEQLHIqYp3gdlduIE4vjlGZXe?=
 =?us-ascii?Q?gWWZ/rykWyMDNyVwLx7MC30Hr7skiadKg6HwBCi9DEWaZzpqH6hfF7Kt572o?=
 =?us-ascii?Q?77CO9ptsZr6UEko3KCQAJTqSlYmvyVwypTqxD8OGMSmC4ye6DwLEOy2kjElG?=
 =?us-ascii?Q?dBoKvWJDlMKpCvZBHO1YSLf5GklWNY2Srj5iEN+gHkDwbtlt3wpsVpaY6LdJ?=
 =?us-ascii?Q?kykczeprV21T4/OZnWA8Vl6L4iUwed6K/IhwROag8n1Ok076cpIsAGroyYo6?=
 =?us-ascii?Q?mUvqCZCXGukIk2Ok/4DK5YOL48gkbNRBNsw6hs8MMTyf8qbOtfiJok6CYtSM?=
 =?us-ascii?Q?ylsoKbst8u7vqbW/cH1WrTKn/7ijS/XlHC9OpHlTi8r24eEVg2AX+kQg0Rms?=
 =?us-ascii?Q?AtVyq63cvJkAEADvF6O1XI1y8U/ZqMQyjxnILGQJVjUVXUqQP9QwZdoy81S6?=
 =?us-ascii?Q?yYgld10lziBkgC2bt5ACWbXxeJb1xqSxeoC/aYh4pKEg9fItfJdZUWCM8cxC?=
 =?us-ascii?Q?+cPK3mxjY5B8C6QJqljOonmSWlqJtA7sW13Gc2OeWbzET3QHr7I32uChrqoX?=
 =?us-ascii?Q?yxMuAfOr0+FU3m5QSYEP4uAHzLz3+q07eTM/vB+OJVJbYTSeWkPNgjQJj3Tn?=
 =?us-ascii?Q?2AwkKaKTPyMW+bPr3tLFAfF6L2jlCg5T3AjoRxyCWyNUjVngQaDGxuK8aXW0?=
 =?us-ascii?Q?+A1otKmgXNN7/pj4DoaIaQjwl2Vg/rjD8U+gfAS9LAIfj+YmBbCGGm4OMAeZ?=
 =?us-ascii?Q?nPVXKuGndZZDFR7NUKiL6Rnel3jciplKxeGAS3YQsaQR9xPZAxh+HSBCEsom?=
 =?us-ascii?Q?V6w0nlXPMKv0YYOqWrTuqazqm2oAMMXwuUfucGVBjaY/UFAnFWofMqLfI+40?=
 =?us-ascii?Q?2VXmVW4so6HbZ8HHbYbarBWJkbid0+NwLK0Gq4dU8s1KuYXiRYQ9Lnu2xBhq?=
 =?us-ascii?Q?DaBwWhcaSpTugAnCg+pTetRYvFJ25bkSb40obEo9S4akAqrFmB8TBKlA40Tn?=
 =?us-ascii?Q?q6SdqVQC/iv8r6pyHWurpM2Gage7XPeS27a3j1n7ZY8mcJVBCXRwtp/SLMAP?=
 =?us-ascii?Q?2aDuyEukuBekxNILZLa8mUWDtAlIFComcRifLwUpAWElDQXFbfrCZKGPUpfT?=
 =?us-ascii?Q?Yh8o67xZaFnPC6orOzGTN4Wpk2YPDuK2gXg9NdMEoSh6UvxqxvMNXQVfm1ag?=
 =?us-ascii?Q?0o+LsbdZ72rBPLXf0I+VKVJdECR8tU35wwT+wXKz8iUJSE+AuaQAWB20qVt2?=
 =?us-ascii?Q?Butyyatc2Ak3cXI9+NhEtDJmhsPc8duuupKYmWPRXh2+Pqldt03bLya4B6yx?=
 =?us-ascii?Q?+ExJUfj39gdIw0NigVXtFXt7/Nfn0Cf+jpApA+N7?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f36838a1-a2e7-4e25-cfeb-08db46bafa94
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0801MB3767.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 01:01:48.7939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5KkBapo2dR/DBk96RZmE//+qMIxaPhMYbfHrFS+I1Fp8GQoeJsKOPNl+2/c3E535MkzCwcWFdquGDtqf9zpKqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR08MB7767
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fei,

On Wed, Apr 26, 2023 at 10:44:21PM +0800, Fei Shao wrote:
> We observed that on Chromebook device Steelix, if Goodix GT7375P
> touchscreen is powered in suspend (because, for example, it connects to
> an always-on regulator) and with the reset GPIO asserted, it will
> introduce about 14mW power leakage.
> 
> To address that, we add this property to skip reset during suspend.
> If it's set, the driver will stop asserting the reset GPIO during
> power-down. Refer to the comments in the driver for details.
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---

Reviewed-by: Jeff LaBundy <jeff@labundy.com>

> 
> (no changes since v2)
> 
> Changes in v2:
> - Use a more accurate property name and with "goodix," prefix.
> 
>  .../devicetree/bindings/input/goodix,gt7375p.yaml        | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> index ce18d7dadae2..1edad1da1196 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -43,6 +43,15 @@ properties:
>        itself as long as it allows the main board to make signals compatible
>        with what the touchscreen is expecting for its IO rails.
>  
> +  goodix,no-reset-during-suspend:
> +    description:
> +      Set this to true to enforce the driver to not assert the reset GPIO
> +      during suspend.
> +      Due to potential touchscreen hardware flaw, back-powering could happen in
> +      suspend if the power supply is on and with active-low reset GPIO asserted.
> +      This property is used to avoid the back-powering issue.
> +    type: boolean
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.40.1.495.gc816e09b53d-goog
> 

Many thanks to you and Doug for the informative discussion.

Kind regards,
Jeff LaBundy