Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 10:07:07 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON()
Message-ID: <20230427010707.GG1496740@google.com>
References: <20230425140955.3834476-1-Liam.Howlett@oracle.com>
 <20230425140955.3834476-19-Liam.Howlett@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230425140955.3834476-19-Liam.Howlett@oracle.com>
Precedence: bulk

Cc-ing Petr

On (23/04/25 10:09), Liam R. Howlett wrote:
> +	if (MAS_WARN_ON(&vmi->mas, vmi->mas.node != MAS_START &&
> +			vmi->mas.index > vma->vm_start)) {
> +		printk("%lx > %lx\n", vmi->mas.index, vma->vm_start);
> +		printk("store of vma %lx-%lx", vma->vm_start, vma->vm_end);
> +		printk("into slot    %lx-%lx", vmi->mas.index, vmi->mas.last);
>  	}

[..]

> +	if (MAS_WARN_ON(&vmi->mas, vmi->mas.node != MAS_START &&
> +			vmi->mas.last <  vma->vm_start)) {
> +		printk("%lx < %lx\n", vmi->mas.last, vma->vm_start);
> +		printk("store of vma %lx-%lx", vma->vm_start, vma->vm_end);
> +		printk("into slot    %lx-%lx", vmi->mas.index, vmi->mas.last);
>  	}

Any reason for "store of vma" and "into slot" to be two separate
printk()-s? It's not guaranteed that these will be printed as a
continuous line. A single printk should work fine:

	pr_foo("store of vma %lx-%lx into slot    %lx-%lx", ...);

The line probably needs to be terminated with \n unless you expect
more pr_cont() printks after this, which doesn't look like a case.
Additionally, do you want to pass a specific loglevel? E.g. pr_debug()?