Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <252ee222-f918-426e-68ef-b3710a60662e@bytedance.com>
Date:   Thu, 27 Apr 2023 15:02:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs
Content-Language: en-US
To:     Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc:     virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
References: <20230427043433.2594960-1-wangwenliang.1995@bytedance.com>
 <1682576442.2203932-1-xuanzhuo@linux.alibaba.com>
From:   Wenliang Wang <wangwenliang.1995@bytedance.com>
In-Reply-To: <1682576442.2203932-1-xuanzhuo@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/27/23 2:20 PM, Xuan Zhuo wrote:
> On Thu, 27 Apr 2023 12:34:33 +0800, Wenliang Wang <wangwenliang.1995@bytedance.com> wrote:
>> For multi-queue and large rx-ring-size use case, the following error
> 
> Cound you give we one number for example?

128 queues and 16K queue_size is typical.

> 
>> occurred when free_unused_bufs:
>> rcu: INFO: rcu_sched self-detected stall on CPU.
>>
>> Signed-off-by: Wenliang Wang <wangwenliang.1995@bytedance.com>
>> ---
>>   drivers/net/virtio_net.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index ea1bd4bb326d..21d8382fd2c7 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -3565,6 +3565,7 @@ static void free_unused_bufs(struct virtnet_info *vi)
>>   		struct virtqueue *vq = vi->rq[i].vq;
>>   		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL)
>>   			virtnet_rq_free_unused_buf(vq, buf);
>> +		schedule();
> 
> Just for rq?
> 
> Do we need to do the same thing for sq?
Rq buffers are pre-allocated, take seconds to free rq unused buffers.

Sq unused buffers are much less, so do the same for sq is optional.

> 
> Thanks.
> 
> 
>>   	}
>>   }
>>
>> --
>> 2.20.1
>>