Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "leon@kernel.org" <leon@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net PATCH v4 10/10] octeontx2-pf: Disable packet I/O for
 graceful exit
Thread-Topic: [net PATCH v4 10/10] octeontx2-pf: Disable packet I/O for
 graceful exit
Thread-Index: AQHZeNfiI+FROnMtV0yeyz9Ad45/9w==
Date:   Thu, 27 Apr 2023 07:14:20 +0000
Message-ID: <BY3PR18MB470730CFAADC80CE5BF6A7BFA06A9@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230426074345.750135-1-saikrishnag@marvell.com>
 <20230426074345.750135-11-saikrishnag@marvell.com>
 <ZEj3jK639HNVN/ks@corigine.com>
In-Reply-To: <ZEj3jK639HNVN/ks@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6Qd3AWp1uSYB/YlJK8AGYSESL7xkLTJbCQ5kdWw99pFFlQuc5P7Fs71J/j9Q?=
 =?us-ascii?Q?CRPp6M+XgCMeIfGwgauD9YgRafGNmVLNHmvlDXjzTmC/+ERua8nD3tLMfLG6?=
 =?us-ascii?Q?UwbcpKhjkeFXdtSsfCTAWGbUKJa26qv0u9K0pVzv14FmIv4NsS5qBT20FhGY?=
 =?us-ascii?Q?bA3dLWePOfDMka0TYZWL+2ffO+HTGIru0l3nE8lVnPhOs7n654Qbrc443xyW?=
 =?us-ascii?Q?+Z1ADBKcce3LmD8ob72VPOjFRsrcP9pufv0UuPw+wkCpTqaxDVYznJ6J/Xr6?=
 =?us-ascii?Q?lPIhFEgOzyqppqLqp3jUWMK8C9GvwABC5YrwOJ6+I2qSsGdCp5SJBhFuASHY?=
 =?us-ascii?Q?64ijDFhc0BWNeVgqsvlzyJVkZNfivtS0PJiYdLNzpuhdrXA3IKkq61hj/Mhx?=
 =?us-ascii?Q?FniS68gfb++K+hNpXhNdT4eT0+QhcuV8CRVlEbFimI0lRCS8SBP+RAcn78OH?=
 =?us-ascii?Q?10flVA2CT+MV23oAjnaVaR0Ag2eD8IL4uAiach+sryLJdCgE6keNEQIlmHO5?=
 =?us-ascii?Q?ruMzWXZpU3oDcVzbegyhMbOo5uyuJYuUrpJyWj9iBohVq1vCIPoNcvLoli4L?=
 =?us-ascii?Q?Gs7Eomwp83zljPSer6HKpcMbAjeHqeK4/9DIpM89ijhHs40/MFMQNPKWmCrP?=
 =?us-ascii?Q?2MTv3WnHoM5C9da0qHjFqt6w8fZPyr3k2TgUESnp+f4yjFDXjO9rzlW1sDOK?=
 =?us-ascii?Q?LwiTutS7EsCnKZ65Xuy1fWpjhQW6g0QhjbGbsYpGix+R4/Om4kcsaZyRkrVB?=
 =?us-ascii?Q?U22nAQDjBXZwor/Hb6+BICpjnlWbOO7qLKtIohvyKoOUHNoc6ym+tISYD8a5?=
 =?us-ascii?Q?0P3tpGY3ZH1XnDZamS/Y9Yy0tX5z4ZkgGlCyvpuL9I+3RivVmT0grMRwrxg1?=
 =?us-ascii?Q?3nGcRNWFLtouI7dQRPGUHZjoirLGUSipyyNqdfIpZ7gRXA6H74vz80WXNFY2?=
 =?us-ascii?Q?bn5cvclHgCh9cGT4vvAHYcmIfKMRbw1o/Vrt4gMiKvl2jF0ujUwRssyDEotR?=
 =?us-ascii?Q?xk6y1ZHIG7mDyWX4x/TivUdOlXIqFStzaq33poTPZpl8DJVpSdXKqmqSGSmW?=
 =?us-ascii?Q?VQeb9oVBmdSgB5uCpEprAHGo93mZdYJw/7iSSqUgc3PGkFML2D3ITLcIpLI9?=
 =?us-ascii?Q?OOR2FW+ECb45NHvUieOg1haQ4j1jg5GzVuaznwm7WkHZRxXjjp4G715LW8tR?=
 =?us-ascii?Q?J0JexXtg0UvOGcT9F9UH5bLtwzXcrKN6rbwvsEOPPQsDQvgBtmTQGTIVxiS2?=
 =?us-ascii?Q?BYPps1mGnRUKAAf1r/S2Yw+EvC6P9K2qzom2kjGvrSHGTy4HGPybe3gYukvV?=
 =?us-ascii?Q?bOs3uFmCuz+FK1SmUKftDzyGfcMiAGLJc2tVh/euQNLiHfw4h7dqCie1M1eY?=
 =?us-ascii?Q?GMHjohoc4A5Jo+LKS3sT+dIDy8K5twxYBT55Wz/0GVq93G9CFhYU/sOGfwXz?=
 =?us-ascii?Q?XxrD6Z+jxWMo4RWS/anzER/bXhr0Me+4tSRXJYkICFdfVbUpEbhIdytUVGEZ?=
 =?us-ascii?Q?aj33kWIFPXojPC6WwRDvWFmijCG7MbIm/zCahQRFrjtMXNKj/2g563eB+fHI?=
 =?us-ascii?Q?rjIVTg0c+M1AzuO50PSPOHABxKFphRHCm6NspGRR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b67a8cbd-adeb-4c5e-380e-08db46ef0528
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 07:14:20.0101
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H27W0gvXOV//byzI5afZjA7T4UXpGO/JyfDontLrGy9dpLZALEsB2fQNZV//8PSx6dpDZyDeSdNRML3+ZQv2tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3605
X-Proofpoint-ORIG-GUID: XY07OmvjyUq0AOoDm7el-nA3_2n6v8T7
X-Proofpoint-GUID: XY07OmvjyUq0AOoDm7el-nA3_2n6v8T7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-27_05,2023-04-26_03,2023-02-09_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Wednesday, April 26, 2023 3:36 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; leon@kernel.org; Sunil Kovvuri Goutham
> <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net PATCH v4 10/10] octeontx2-pf: Disable packet I/O for
> graceful exit
>=20
> On Wed, Apr 26, 2023 at 01:13:45PM +0530, Sai Krishna wrote:
> > From: Subbaraya Sundeep <sbhatta@marvell.com>
> >
> > At the stage of enabling packet I/O in otx2_open, If mailbox timeout
> > occurs then interface ends up in down state where as hardware packet
> > I/O is enabled. Hence disable packet I/O also before bailing out.
> >
> > As per earlier implementation, when the VF device probe fails due to
> > error in MSIX vector allocation, the LF resources, NIX and NPA LF were
> > not detached. This patch fixes in releasing these resources, when ever
> > this MSIX vector allocation/VF probe fails.
>=20
> It seems to me that the issue in the 2nd paragraph / hunk is different to=
 that
> in the first. And thus it seems to be appropriate for it to be in a separ=
ate
> patch, possibly with.
>=20
> Fixes: 3184fb5ba96e ("octeontx2-vf: Virtual function driver support")

We will separate this VF patch and send it in V5 patch series or as a separ=
ate patch.

>=20
> > Fixes: 1ea0166da050 ("octeontx2-pf: Fix the device state on error")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 11 ++++++++++-
> > drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c |  2 +-
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > index 179433d0a54a..52a57d2493dc 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > @@ -1835,13 +1835,22 @@ int otx2_open(struct net_device *netdev)
> >  		otx2_dmacflt_reinstall_flows(pf);
> >
> >  	err =3D otx2_rxtx_enable(pf, true);
> > -	if (err)
> > +	/* If a mbox communication error happens at this point then
> interface
> > +	 * will end up in a state such that it is in down state but hardware
> > +	 * mcam entries are enabled to receive the packets. Hence disable
> the
> > +	 * packet I/O.
> > +	 */
> > +	if (err =3D=3D EIO)
> > +		goto err_disable_rxtx;
> > +	else if (err)
> >  		goto err_tx_stop_queues;
> >
> >  	otx2_do_set_rx_mode(pf);
> >
> >  	return 0;
> >
> > +err_disable_rxtx:
> > +	otx2_rxtx_enable(pf, false);
> >  err_tx_stop_queues:
> >  	netif_tx_stop_all_queues(netdev);
> >  	netif_carrier_off(netdev);
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > index ab126f8706c7..53366dbfbf27 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> > @@ -621,7 +621,7 @@ static int otx2vf_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >
> >  	err =3D otx2vf_realloc_msix_vectors(vf);
> >  	if (err)
> > -		goto err_mbox_destroy;
> > +		goto err_detach_rsrc;
> >
> >  	err =3D otx2_set_real_num_queues(netdev, qcount, qcount);
> >  	if (err)
> > --
> > 2.25.1
> >