Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 15:57:05 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Tim Chen <tim.c.chen@intel.com>,
        "Dietmar Eggemann" <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Honglei Wang <wanghonglei@didichuxing.com>,
        Len Brown <len.brown@intel.com>,
        Chen Yu <yu.chen.surf@gmail.com>,
        Tianchen Ding <dtcccc@linux.alibaba.com>,
        "Joel Fernandes" <joel@joelfernandes.org>,
        Josh Don <joshdon@google.com>,
        "Hillf Danton" <hdanton@sina.com>,
        kernel test robot <yujie.liu@intel.com>,
        "Arjan Van De Ven" <arjan.van.de.ven@intel.com>,
        Aaron Lu <aaron.lu@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] sched/fair: Introduce SIS_CURRENT to wake up
 short task on current CPU
Message-ID: <ZEoq0UXokdPG7i3n@chenyu5-mobl1>
References: <cover.1682060436.git.yu.c.chen@intel.com>
 <98257d0184b227cad8b4e947eedd9246d60191d3.1682060436.git.yu.c.chen@intel.com>
 <20230426140324.GB1377058@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230426140324.GB1377058@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lc8Q3TdMQwUsa+WpwadAfgy3J2uZ45mVaxx+3SPkAmJ8JV6LWLiul/fBg90m?=
 =?us-ascii?Q?6+LHqz1EqhmdDe4WElo4ZNVxxiIvOYwaBoNiPiTLXIpXde72ETsfv2naOCFy?=
 =?us-ascii?Q?+SFh9Sd4cMKWIK0iZyLqTDMII1fwV61AqZ6XpA/qWK6nY83EX56LFLgPXQOo?=
 =?us-ascii?Q?FQu3uK4yU9OT77u+ji6ARZZ4iA7bEAnR4jK6gHvR8MQ63m5W6dwwI8H7KNgT?=
 =?us-ascii?Q?FWWUIAo8iB4NB+9hTzWvWCE51U2g4RJtuASEeef8M2Qps/gVrARZI4EvvyXT?=
 =?us-ascii?Q?KodeebkLkwwL9+O7nv4VIA20Mo4Ioq4V2uT5GxmlJWyhooadzI5sy3QQRpbe?=
 =?us-ascii?Q?P80rdX2aQLo09viD0G5q7ZF64tXPtef6c56R0dupwpf0oeC4fs8hjex5jHbO?=
 =?us-ascii?Q?B4b0Tl1CCpYSt5HhyC6jZ5KRtIteOAB8R2eKnhtQsssC4vNEexMV4it5Gcfb?=
 =?us-ascii?Q?K/JNoWOmQ2UJfilSYZ5w/tJEdiMcWBjf98b+j5tktVDcEN79jy/4z5U91U8K?=
 =?us-ascii?Q?OxIbUaPVfxu2IP3qUpYBBcor4wK8J0GL2NLWcslOTxvLX0zc8aAAs4eksJ/P?=
 =?us-ascii?Q?NENJHufkL7r/tf9UPL9reI7dPDay4wHYx+0GIzot946drmh9Z80eKFhUDfIt?=
 =?us-ascii?Q?udw8INdD9IajzkW+4OGCU7oA1V4GQji7ng5b5p3QJVfWRI434XOse8OvoX/y?=
 =?us-ascii?Q?vjhI4xJfXHaU+7/B804u7wl38D010/xf9m8zHA8Dy6wh4Pg1V5omrVeL9C8A?=
 =?us-ascii?Q?WAoiXh8Ji14DLIzm1w6OY410mgTgezA0xqCbZ83sfYvpSO9GI8AKbu8Fb9PC?=
 =?us-ascii?Q?BDBXoicd657YrwYesgCxEgc+xp5muWJWk6JxbAIqPabX2BjlkdtGWYXqQtZh?=
 =?us-ascii?Q?Fy+eJapGnWtmvV7G6OBo1OJmlTsoA9O8dOKMk625d6HWocwR/Iabv2AWpj9m?=
 =?us-ascii?Q?iTYR46B0jz2jzqS37YcZDLy/EKeXnIgqIzSFXLA+ayP7twgTh+2G7l55LiEz?=
 =?us-ascii?Q?iNjSy0wMG+pJn31uASqyGEFj9SbDxe5RHlgfmm1IsxVsqPe+2SbeUNsQ5/gX?=
 =?us-ascii?Q?RadsbimfMymokK12+XN1IoJQ17MA/Bs6ZT3l2rJIKnlIdrSQT3DwB78t6MLI?=
 =?us-ascii?Q?so2npYKEJ56LW84jIUGxCF4SNWauc7yXssDb+p84K8TVm7yYilz1FNXjNMxj?=
 =?us-ascii?Q?V5mIBI3mr5ywKZNklSyFs5cLf9m0IxxK8MOVrUS6bSdXwX3vj8EQXpzUh5tA?=
 =?us-ascii?Q?uva8NRrtDDkaHHU+z1uKZ0ZV6ZQPaXrXElz608mFrIn6b4GG/JzNTYGII7Nt?=
 =?us-ascii?Q?xqFNk5VwQwNvoROhwKchtzaJJRGm22Ys2FkfqAEuutWo2ZPO2dfbQ75iisEZ?=
 =?us-ascii?Q?dMnu3xWsU8q4+31KSp9gEHnzSkARMekfChfNIiox2ZKCU377MtaIviUDZ3Hp?=
 =?us-ascii?Q?x+YZ9QwrqKWmVceO61lycB+9o3I8LCInAEo/edid82sCH+fKugxa8Om5mbrA?=
 =?us-ascii?Q?ghjLtN4I2OVvmuO1oRp4Fennahl6ym/CkAjAshAzTCRZKQZaF0QEe9N4BaU7?=
 =?us-ascii?Q?YTFYxQkHo+2HLL+eEqeofjvwxOZ4EcfW3G4c4Bau?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 861bda34-1824-4516-e5be-08db46f508ea
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 07:57:23.6721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBvU3nQd/EtZiAHXAk+xp7AQsLBdhV1VoKPBoIWnsnfDGBU2YBjbQjNdXWsTUXsX9JFO6P0TF/C6aXjbKcZxkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5674
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-04-26 at 16:03:24 +0200, Peter Zijlstra wrote:
> On Sat, Apr 22, 2023 at 12:08:18AM +0800, Chen Yu wrote:
> 
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 4af5799b90fc..46c1321c0407 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -6501,6 +6501,46 @@ static int wake_wide(struct task_struct *p)
> >  	return 1;
> >  }
> >  
> > +/*
> > + * Wake up the task on current CPU, if the following conditions are met:
> > + *
> > + * 1. waker A is the only running task on this_cpu
> > + * 3. A is a short duration task (waker will fall asleep soon)
> > + * 4. wakee B is a short duration task (impact of B on A is minor)
> > + * 5. A and B wake up each other alternately
> > + */
> > +static bool
> > +wake_on_current(int this_cpu, struct task_struct *p)
> > +{
> > +	if (!sched_feat(SIS_CURRENT))
> > +		return false;
> > +
> > +	if (cpu_rq(this_cpu)->nr_running > 1)
> > +		return false;
> > +
> > +	/*
> > +	 * If a task switches in and then voluntarily relinquishes the
> > +	 * CPU quickly, it is regarded as a short duration task. In that
> > +	 * way, the short waker is likely to relinquish the CPU soon, which
> > +	 * provides room for the wakee. Meanwhile, a short wakee would bring
> > +	 * minor impact to the target rq. Put the short waker and wakee together
> > +	 * bring benefit to cache-share task pairs and avoid migration overhead.
> > +	 */
> > +	if (!current->se.dur_avg || ((current->se.dur_avg * 8) >= sysctl_sched_min_granularity))
> > +		return false;
> > +
> > +	if (!p->se.dur_avg || ((p->se.dur_avg * 8) >= sysctl_sched_min_granularity))
> > +		return false;
> > +
> > +	if (current->wakee_flips || p->wakee_flips)
> > +		return false;
> > +
> > +	if (current->last_wakee != p || p->last_wakee != current)
> > +		return false;
> > +
> > +	return true;
> > +}
> 
> So I was going to play with this and found I needed to change things up
> since these sysctl's no longer exist in my EEVDF branch.
> 
> And while I can easily do
> 's/sysctl_sched_min_granularity/sysctl_sched_base_slice/', it did make
> me wonder if that's the right value to use.
> 
> min_gran/base_slice is related to how long we want a task to run before
> switching, but that is not related to how long it needs to run to
> establish a cache footprint.
> 
> Would not sched_migration_cost be a better measure to compare against?
> That is also used in task_hot() to prevent migrations.
Yes, thanks for the suggestion, this looks more reasonable. I'll tune on this
and check the result.

thanks,
Chenyu