Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp316298rwr; Thu, 27 Apr 2023 01:30:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ637nxoTPAORbYutdiii4ytebEECiOfMsJnLNKCZqM9DYa088q+bwXK4Gp6Ew5AqGfhEcgv X-Received: by 2002:a05:6a20:7f99:b0:f0:251f:f099 with SMTP id d25-20020a056a207f9900b000f0251ff099mr863990pzj.1.1682584227785; Thu, 27 Apr 2023 01:30:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682584227; cv=none; d=google.com; s=arc-20160816; b=TCBQFLzn4088GjluJ2SRVyUtaVmefzjax/6NvxoJAT8BwCFn0xYP++m90pxALRk7j4 Hlw2KyeftOaJR+7Di2WVzpFCNWNNg04TMHrfj7PSysZyO27De0JGOwTt1NfmifpU757s LmTpFQG9nkvIn1bmoLBoNFdl4sB67sY6bgzAM0lAFScAuPDeRdBWYCCpNC+zS3k1INb6 Qw9t9aI9ejqfvAcRTGLiaqAJSlxidN//JVOKR7BS13gRagA9f/9Vu4J6cemv1OD0xCoy 1ZIlTCa2ZmTPXkO7z0cTMh400Bme/wjFZ+EuLpFmguMdYnjUnGt/RFb1ZLWNu2rPpA6r 3deA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:cc:to:from:date:subject :message-id; bh=UEv2+FNtb3l5x6e5heDYX9Hks1bF1nxtaLTFfa5H9nc=; b=a/pgo3yJGP9mBcD7yktcutfH4wtf0S5dY3YZiCVSCezdd4Wozv5d2asHWib83S5M1/ DLqiiz/IHpiq41VYcht52gVwZYYIs0B/7oJv5lZnYGB/wtFJxINDFD9V1TKVJDRUl8ZR Ncw5j9nxKQLmFihw41F8HzkHKIkMK/yGYQ8AUHPWTAgAvDAGBk4oNsN2F2ZMayMU0lOL Afr7/x3H9dPcBf+nlP9i6WqkspVTeZP4GLkgrmMl2Cn60rbpc/EtF4Wya3bD2hmj+vZI QHqusedKtZiwnvXBKeDgjce1YvIVZ82LaWB2Gtt8zeVpeyLqfPQZJiLxUMo2hs7os5ec e91Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y15-20020a63494f000000b00524ca1b89f0si16225038pgk.596.2023.04.27.01.30.15; Thu, 27 Apr 2023 01:30:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243067AbjD0IUA (ORCPT + 99 others); Thu, 27 Apr 2023 04:20:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242701AbjD0IT5 (ORCPT ); Thu, 27 Apr 2023 04:19:57 -0400 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B2EF3A9A; Thu, 27 Apr 2023 01:19:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Vh6aTWS_1682583590; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0Vh6aTWS_1682583590) by smtp.aliyun-inc.com; Thu, 27 Apr 2023 16:19:51 +0800 Message-ID: <1682583225.3180113-2-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs Date: Thu, 27 Apr 2023 16:13:45 +0800 From: Xuan Zhuo To: "Michael S. Tsirkin" Cc: Wenliang Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jasowang@redhat.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com References: <20230427043433.2594960-1-wangwenliang.1995@bytedance.com> <1682576442.2203932-1-xuanzhuo@linux.alibaba.com> <252ee222-f918-426e-68ef-b3710a60662e@bytedance.com> <1682579624.5395834-1-xuanzhuo@linux.alibaba.com> <20230427041206-mutt-send-email-mst@kernel.org> In-Reply-To: <20230427041206-mutt-send-email-mst@kernel.org> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Apr 2023 04:12:44 -0400, "Michael S. Tsirkin" wrote: > On Thu, Apr 27, 2023 at 03:13:44PM +0800, Xuan Zhuo wrote: > > On Thu, 27 Apr 2023 15:02:26 +0800, Wenliang Wang wrote: > > > > > > > > > On 4/27/23 2:20 PM, Xuan Zhuo wrote: > > > > On Thu, 27 Apr 2023 12:34:33 +0800, Wenliang Wang wrote: > > > >> For multi-queue and large rx-ring-size use case, the following error > > > > > > > > Cound you give we one number for example? > > > > > > 128 queues and 16K queue_size is typical. > > > > > > > > > > >> occurred when free_unused_bufs: > > > >> rcu: INFO: rcu_sched self-detected stall on CPU. > > > >> > > > >> Signed-off-by: Wenliang Wang > > > >> --- > > > >> drivers/net/virtio_net.c | 1 + > > > >> 1 file changed, 1 insertion(+) > > > >> > > > >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > >> index ea1bd4bb326d..21d8382fd2c7 100644 > > > >> --- a/drivers/net/virtio_net.c > > > >> +++ b/drivers/net/virtio_net.c > > > >> @@ -3565,6 +3565,7 @@ static void free_unused_bufs(struct virtnet_info *vi) > > > >> struct virtqueue *vq = vi->rq[i].vq; > > > >> while ((buf = virtqueue_detach_unused_buf(vq)) != NULL) > > > >> virtnet_rq_free_unused_buf(vq, buf); > > > >> + schedule(); > > > > > > > > Just for rq? > > > > > > > > Do we need to do the same thing for sq? > > > Rq buffers are pre-allocated, take seconds to free rq unused buffers. > > > > > > Sq unused buffers are much less, so do the same for sq is optional. > > > > I got. > > > > I think we should look for a way, compatible with the less queues or the smaller > > rings. Calling schedule() directly may be not a good way. > > > > Thanks. > > Why isn't it a good way? For the small ring, I don't think it is a good way, maybe we only deal with one buf, then call schedule(). We can call the schedule() after processing a certain number of buffers, or check need_resched () first. Thanks. > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > >> } > > > >> } > > > >> > > > >> -- > > > >> 2.20.1 > > > >> >