Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 11:21:06 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Simon Guinot <simon.guinot@sequanux.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hans de Goede <hdegoede@redhat.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Xing Tong Wu <xingtong.wu@siemens.com>
Subject: Re: [PATCH 1/1] gpio-f7188x: fix pin count on nct6116d bank 7
Message-ID: <20230427112106.697dd352@md1za8fc.ad001.siemens.net>
In-Reply-To: <ZEoydXMDRONgbhY8@76cbfcf04d45>
References: <20230425153911.32135-1-henning.schild@siemens.com>
        <20230425153911.32135-2-henning.schild@siemens.com>
        <ZEoydXMDRONgbhY8@76cbfcf04d45>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PJ/8KYyHJonlv3TOp2YltjwZ85qshsNWgw9zKL54eZ7kCffqh7Km2IhwfS56?=
 =?us-ascii?Q?DuH2Gkq/HFteURAeVrc1RXiOIwDNjK4kfNovPz9HYtZq48ZxLOexQ5Au8zix?=
 =?us-ascii?Q?KgsnHVe8A8K/a8NwF+lFpvwAN7FOoVu3ywLYeclJvamPKlFFfADjcz0i4KiH?=
 =?us-ascii?Q?AAswXl87Aow+dOLESi4SqjliIFECvpNZlOhYtHnlXDL75xU8AdbHz9Wg/5Wt?=
 =?us-ascii?Q?gtRsVOZf2BG8Wu4RwbmUqaylyPfHgM3hzP3iEWdFhfEMFtW6kg9sZhq9d9Uu?=
 =?us-ascii?Q?NV74gZynYQo2wYS2SeD2zbtqoCImMdGxrome6FLf4Swzii8X5HerA9vkGwL3?=
 =?us-ascii?Q?Ir+iZd0nc5vZad8kPOqDKAYy88j6A7dNAjiLVII72xSYyyq+BcGcuVyHQbp4?=
 =?us-ascii?Q?NQzzzU2Qoe2lDvJLuvjDhwwUyPycG28aoY5zFD9r/2bXlr6OsrWWueA98opE?=
 =?us-ascii?Q?mGmpQmBj2THmwisuuFtulbykYlmTu3cYA2gsc14EMeUsJjvrZb1VGVP9O94u?=
 =?us-ascii?Q?OWYZbby4ybL0wy26gyRR4QTB59ZXiZY76bkHWRB5qs2INhja+Ns7/o/WthQn?=
 =?us-ascii?Q?AFlDVSK8wQUDUwbNQzMN3z1s1DslEaaN9uZ+DgwKMTjPrOchXWVOt9pAiXHl?=
 =?us-ascii?Q?dQIDkcREVH3isRkTyKFEoJgOQCFq7HQqDgxoTebzVg+c5sEGXJ4AZuabhPyI?=
 =?us-ascii?Q?fhbSLET6oMDNi0M4o434T008HzHKdYoQgkuj2Vvsp13Mrph64//3N2/QgxQw?=
 =?us-ascii?Q?HuHj8PnrMWQx/3OJWJXD0hYViRDJtNu7678rn2a90Qtt4vAmY8mdb5a+1ZKJ?=
 =?us-ascii?Q?uIhs8YcIMAJ7jHsQq67w7Tw48OuC43irTXyWSIHYofOQNLsRWxbGbl/+cSiq?=
 =?us-ascii?Q?uN2tkY8UIsaV4W704ElGX1aXfTYhmk4AgBm2I4z9vS3Eph5Ba9aSRZBx4Vuw?=
 =?us-ascii?Q?mcXRdCXelBU310KGyyffTki3P2/GVg0TRt5CT2c+FovWZgiIiJaVBJPLASYl?=
 =?us-ascii?Q?OMCwUf4xln91kIOzKqxaRqXQfWU/0T7tpBjqaSQHAUSYHk6gPRckK1jrYLT6?=
 =?us-ascii?Q?OK1YJK0rNOvsspKvLtQjF1hu7lEqiUaXTwVhld8OTNm403cFjUNf5D7FU9Ve?=
 =?us-ascii?Q?oeK8BneqXaLJAwFK79Vo3+0kI9qMqCk1bC3/cr2X4wbtUB9PpNr/cD6264WD?=
 =?us-ascii?Q?txNHnb1tnTqDhozVHM9hj6PfF7e76PtQkdtG+Z13B3l5jzjukAsQHqAKLh0y?=
 =?us-ascii?Q?m2er4em0jGUn1fBPCiHkemrwzuWjcabVXj6KZNXe10jOrWZ8uMst23ZkSYWS?=
 =?us-ascii?Q?Eu8GRA/KkJjzJ7U1Y89gncmH4ylGTJLIBoHwNi72v0Vj+nloBIYIP2Y+klNO?=
 =?us-ascii?Q?IBBgq5xIZkOpsoURipX3gwJEDFOyfv9ljYI/EzWsSbBjiutZT0TKuRbxrspd?=
 =?us-ascii?Q?fzU4Mf/gkE6BxX9Zqx4cMUY/p9dV7uF/42QhgtUhxh+e1A8RJ1hnAG8oFsTI?=
 =?us-ascii?Q?eHzKu6hLYMnnetwm9Z+i4DWcZDe2FKGWJj8gscS6XWXhhxSCN4KtQdqWjOW7?=
 =?us-ascii?Q?l0qFW6M4+Dpt2j9phBEGOwutPCPg67zaNIz2vwMTmm2/PrKWIbEg9bvME5Wn?=
 =?us-ascii?Q?YA=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d71c220-0f82-4edc-6684-08db4700bd7d
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 09:21:11.1439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JijGIgdgTaXT0xZP3i44srVcQiKzH4z0PVFV5NcW6hft6URVWkdyXTwqpl3JS2IKuzgxsb2DJ7xcB0OoxHRR8ALsibNP5YfnYkIWBz5YWeo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB7622
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 27 Apr 2023 10:29:41 +0200
schrieb Simon Guinot <simon.guinot@sequanux.org>:

> On Tue, Apr 25, 2023 at 05:39:11PM +0200, Henning Schild wrote:
> > The count was wrong because i looked at the wrong spec for the chip
> > in question. I now got access to the spec for that very chip and
> > group7 has all 8 pins, just like the other groups.  
> 
> Did you use the NCT6102D / NCT6106D datasheet in a first place ?

I do not remember which one, but one of the few one could find online.
Now i have datasheets for two chips directly from the vendor, both
files not publicly available and i am afraid i can not share.

> If the only difference with NCT6116D is the number of pins on port
> GPIO-7, then maybe we should handle it and claim support for this
> models as well ?

Please hold this patch back until i confirm again. It might be that i
got the model name wrong as well and might have to fix some strings. I
basically started my journey with a preliminary driver i got from
Nuvoton, which maybe made me think i was looking at a NCT6116D while i
was not.

At least that is what the chip IDs from the specs seem to strongly
suggest.

I am sorry for the confusion and will try to clean that up.

Now having access to some of those specs, i can offer to add more
variants without testing. Such support would be in patches on top, not
subject to fixing what we have in stable already. But i would only do
this on demand and have a weird feeling about it, the code might be
trivial but i have no means of testing.

Henning

> Simon
>  
> > 
> > Fixes: d0918a84aff0 ("gpio-f7188x: Add GPIO support for Nuvoton
> > NCT6116") Reported-by: Xing Tong Wu <xingtong.wu@siemens.com>
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  drivers/gpio/gpio-f7188x.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> > index 9effa7769bef..05c0edc4778f 100644
> > --- a/drivers/gpio/gpio-f7188x.c
> > +++ b/drivers/gpio/gpio-f7188x.c
> > @@ -282,7 +282,7 @@ static struct f7188x_gpio_bank
> > nct6116d_gpio_bank[] = { F7188X_GPIO_BANK(40, 8, 0xF0, DRVNAME
> > "-4"), F7188X_GPIO_BANK(50, 8, 0xF4, DRVNAME "-5"),
> >  	F7188X_GPIO_BANK(60, 8, 0xF8, DRVNAME "-6"),
> > -	F7188X_GPIO_BANK(70, 1, 0xFC, DRVNAME "-7"),
> > +	F7188X_GPIO_BANK(70, 8, 0xFC, DRVNAME "-7"),
> >  };
> >  
> >  static int f7188x_gpio_get_direction(struct gpio_chip *chip,
> > unsigned offset) -- 
> > 2.39.2