Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8cbc82f0-1ebe-b664-5d8f-98f1edff5842@amlogic.com>
Date:   Thu, 27 Apr 2023 17:25:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC PATCH 2/2] arm64: dts: add support for C3 based Amlogic
 AW409
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230419073834.972273-1-xianwei.zhao@amlogic.com>
 <20230419073834.972273-3-xianwei.zhao@amlogic.com>
 <4e6469e5-0f6c-4150-4709-7459597f06cc@linaro.org>
From:   "xianwei.zhao" <xianwei.zhao@amlogic.com>
In-Reply-To: <4e6469e5-0f6c-4150-4709-7459597f06cc@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0xtVzRBZFRqajYwczhaYVVQK2ZSMVNLakxvVE40VWRRL0x2OHFMTWFZeVQ4?=
 =?utf-8?B?aThXcHZ3b3FxVHFZSm93U3BGa3NiczQxbVF3Ymx1a05hMkVSR0NqdmVmOFow?=
 =?utf-8?B?bkZPaUtjbkdoejJBUzlubjlFbk5QK1JrZWFScDBNT0hSaTFBQXRrNXlscFZJ?=
 =?utf-8?B?bDJDZ3BPbVc1YjBYSWVLbnR5aXZ1OHFnTmVXSEhwQmlEN09NQmI4ekpRYnZ3?=
 =?utf-8?B?aW1aWmIzV0g5eHRNTVA1cVZkQlkxdXdJcmVTNlVzV0Q3MFFGenY4bTRRM1BQ?=
 =?utf-8?B?dHJ2VkRmeWpIcVJFdlcxZWRoWGtJL1krVWYwa0JmcFFBNldhaTFsakJRTktG?=
 =?utf-8?B?VEdvQTdTM1kwSTl2ZEhsV2YrdnQwaHZTRzJHWmNXeG9BVHJnTFdHTlRsb1c1?=
 =?utf-8?B?Q0JYOWQ5T3QyaVYvVEdObUI2eis4ejlZV3pUTDQ5T1RINmRKN0ljUndmVk9x?=
 =?utf-8?B?V3ZPRHVHem5pc2Q0bWhhcGoxTjJzYUVEQXpZTloyWlRyZ0p1dHMrd29Vanpy?=
 =?utf-8?B?dWhhNDV3WXFONG1IWGROTUNZN0hqWUxkVGd0ZkJROU5rRDRMY2lnS3ZaK09r?=
 =?utf-8?B?Vkt4Njl2Z3VORFgvN21yQThSeUJSQ2xMVVl0SWF0Vk5jQm9pZzVIeWUrdFFm?=
 =?utf-8?B?SjlCRFd2ek4zOVlxM1V3VEtqQVNmdkVYa09xbXBXVExWTWVKUUNUamlNYVFa?=
 =?utf-8?B?SU5mQVg3UVlVNEVOR05ZWGpxVVRQNzNsaG5rTDNnaXNZYVNBY3hVaFVmSVNC?=
 =?utf-8?B?U2puL1NaQjIrZDhkN3NJc09ubGNzNjNzbXFmNU41ZEVTbTh5dUxxWHNaTmF5?=
 =?utf-8?B?L002L2xVNnEveWl1aG5xQmYzYm5jZ1ZUajIyZXM5MEFzeEVYSURTeThwakI3?=
 =?utf-8?B?a2tKS0Q3K3JZNWdmeXowcUovdytEcDhLZjl2OHlIVzhzM2VBcHUyNTRleG5Y?=
 =?utf-8?B?RjFTUmZsSENyOU91QmRFbkZmYzJwclZWN2RMQWV3R1krbDFLNFp3ajNrTTB2?=
 =?utf-8?B?eFBNbGhyQ3JSNzltR1VkSHpZNGlJTG5FSGQ4TTV5bW4vMzdWclFEK3JiT3Nq?=
 =?utf-8?B?dDczcmNnZ0l1Z01kaEhqVFJ1NkRjRjAwaWQ1bGoyVzJwYThFa0MraEFqaExE?=
 =?utf-8?B?NzFEV0Q1dkhVNnFzSkI0NWNQTHlmcVdDSCt5MzQ4RFpjczB5a0l0Zkx4dzFV?=
 =?utf-8?B?UkFNTWFkc1VYY281UDY1ajhvK3VlQ1ZNem0yQS8rby8wSVNraUVkWFQxVVpx?=
 =?utf-8?B?Rm1JYzNWRlp6b2tFRGlUS1h6RHRvb0lTVXRXclp4bktaV2lseTVKUUdJcDJL?=
 =?utf-8?B?bEdWUEZpRXdmakRTNFRSNHh0VVdVN1daL21Yb2Jaek5OOGQ1U0M3ZDV3bzY4?=
 =?utf-8?B?MWxqZzN5Y0hjNC83dk1rWUxqQ3B5aW5lTnRDK3pnVVEzUGxzME5mY1hqOFJw?=
 =?utf-8?B?NWdWc0MzZVlMMnZGc2JGOXRocnQ0bm5BNFYxaVd2cUdPYzJhZnNlLzdCS01r?=
 =?utf-8?B?cjkvU0JxUDJTRTRyRjZMRUtZbHloMWprWE10d0t6WHlFUDNQaUk1a0ZhRldp?=
 =?utf-8?B?ZnkzY3pOc1l0MFVxeDRseFpwNk1NNVVDMjdyV3cwV3NuOC9tZHMxYU9HQVJH?=
 =?utf-8?B?R2ZDaVBmNjdPYk5OdkRmUUx1NTZCZDFlTy9pL1VCeEFTc1RNdVhZMllZWHR0?=
 =?utf-8?B?d3dFY0ppNEJoL3FiT29xVEhZeDh2dkNUUlkwS0NRaTMrbGliUkhtbXpSMFYz?=
 =?utf-8?B?c0NiTHRsWnk4bVNZRkt2WDFwbnBSQi9DYjZ4Mm1XSnl1REpxZ0IwUHZaZjk0?=
 =?utf-8?B?dFNUQkFEc05ndVF3QU00eEtEcERuYzVjcFJUdTdRQ1VDS1JFM2Rzby9remJC?=
 =?utf-8?B?MmRoRlFTMTJGVHdlSGpwd296UEJ4NDdNV1hNR1hOOGk0MXdrUGdNWlVZRWkw?=
 =?utf-8?B?U29pVEtZOFpUOFQ3cVpUdnB3bkZ5N1hyUUxTZ3piOE1JT3BIaEpaZi9BbEF3?=
 =?utf-8?B?aHdibzNiMGRhVnBiVEtIaklaZVhBcWJEcTY3N2RPSUFiNEF0L05lRjArWDc3?=
 =?utf-8?B?MU0vZ1FmdnpDS0lLUFVRWDJjZkozYWZZZlp3TUVKRDdWSUNvc0VyYlBqYU04?=
 =?utf-8?B?bEdnYzQwRzMxUGMxbGovWC9hWjJaT0RMV3BGVlNBU2JTNTlrTmJSR3ozYXY3?=
 =?utf-8?B?aGc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28787a74-de41-4695-59be-08db470153cd
X-MS-Exchange-CrossTenant-AuthSource: SG2PR03MB2734.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 09:25:24.2783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: opfjO0jKUk+9+1KlmzKsdvlwwT5i2TjPCXqhhKBhwJnLK55q9ML/dpqEKkdskatMISdXeASbeEdlZj0gEjwDhk1C4on5ny6VInFZFUnDuPQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0302MB5361
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,
             Thank you for your reply.

On 2023/4/19 15:48, Krzysztof Kozlowski wrote:
> [你通常不会收到来自 krzysztof.kozlowski@linaro.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
> 
> [ EXTERNAL EMAIL ]
> 
> On 19/04/2023 09:38, =Xianwei Zhao wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic C3 is an advanced edge AI processor designed for smart IP camera
>> applications.
>>
>> Add basic support for the C3 based Amlogic AW409 board, which describes
>> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>> booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>>   .../amlogic/amlogic-c3-c302x-aw409-256m.dts   | 30 +++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   | 87 +++++++++++++++++++
>>   3 files changed, 118 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>>   create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index cd1c5b04890a..d2b5d0d750bc 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb
>> +dtb-$(CONFIG_ARCH_AMLIPC) += amlogic-c3-c302x-aw409-256m.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>> new file mode 100644
>> index 000000000000..38ca98a32181
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c302x-aw409-256m.dts
>> @@ -0,0 +1,30 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-c3.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic C302 aw409 Development Board";
>> +     compatible = "amlogic,aw409", "amlogic,c3";
> 
> Undocumented compatibles. Run checkpatch and fix all warnings. Anyway, I
> am not sure this warrants separate architecture. Isn't C3 standard Meson
> SoC?
> 
The patch related to bindings is committed, see: 
https://lore.kernel.org/all/20230407102704.1055152-1-kelvin.zhang@amlogic.com/
>> +     interrupt-parent = <&gic>;
>> +     #address-cells = <2>;
>> +     #size-cells = <2>;
>> +
>> +     aliases {
>> +             serial0 = &uart_B;
>> +     };
>> +
>> +     memory@0 {
>> +             device_type = "memory";
>> +             reg = <0x0 0x0 0x0 0x10000000>;
>> +     };
>> +
> 
> Drop stray blank lines.
> 
will do
>> +};
>> +
>> +&uart_B {
>> +     status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> new file mode 100644
>> index 000000000000..c69072ac57f5
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
>> @@ -0,0 +1,87 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2021 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +/ {
>> +     cpus {
>> +             #address-cells = <2>;
>> +             #size-cells = <0>;
>> +
>> +             cpu0: cpu@0 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a35";
>> +                     reg = <0x0 0x0>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu1: cpu@1 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a35";
>> +                     reg = <0x0 0x1>;
>> +                     enable-method = "psci";
>> +             };
>> +
> 
> Everywhere...
> 
will do
>> +     };
>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>> +     };
>> +
>> +     psci {
>> +             compatible = "arm,psci-1.0";
>> +             method = "smc";
>> +     };
>> +
>> +     xtal: xtal-clk {
>> +             compatible = "fixed-clock";
>> +             clock-frequency = <24000000>;
>> +             clock-output-names = "xtal";
>> +             #clock-cells = <0>;
>> +     };
>> +
>> +     soc {
>> +             compatible = "simple-bus";
>> +             #address-cells = <2>;
>> +             #size-cells = <2>;
>> +             ranges;
>> +
>> +             gic: interrupt-controller@fff01000 {
>> +                     compatible = "arm,gic-400";
>> +                     #interrupt-cells = <3>;
>> +                     #address-cells = <0>;
>> +                     interrupt-controller;
>> +                     reg = <0x0 0xfff01000 0 0x1000>,
>> +                           <0x0 0xfff02000 0 0x2000>,
>> +                           <0x0 0xfff04000 0 0x2000>,
>> +                           <0x0 0xfff06000 0 0x2000>;
>> +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
>> +             };
>> +
>> +             apb4: apb4@fe000000 {
> 
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
will do
>> +                     compatible = "simple-bus";
>> +                     reg = <0x0 0xfe000000 0x0 0x480000>;
>> +                     #address-cells = <2>;
>> +                     #size-cells = <2>;
>> +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>> +
>> +                     uart_B: serial@7a000 {
> 
> lowercase for labels
> 
will do
>> +                             compatible = "amlogic,meson-g12a-uart";
> 
> So this is just meson? Drop new ARCH, no need for it. Anyway, you need
> SoC specific compatible.
> 
> Best regards,
> Krzysztof
>