Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "mani@kernel.org" <mani@kernel.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Alice Chao <alice.chao@mediatek.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/1] scsi: ufs: core: correct utp_transfer_cmd_desc
 size
Thread-Topic: [PATCH v1 1/1] scsi: ufs: core: correct utp_transfer_cmd_desc
 size
Thread-Index: AQHZeM2t/+gGXd+zuEe0BzdD7MDVNa8+600A
Date:   Thu, 27 Apr 2023 09:57:27 +0000
Message-ID: <DM6PR04MB65750D13F7417242DB51E98CFC6A9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <4b778dbcfd1fc40140292166834f13e8d5b8e4d2.1682575115.git.quic_nguyenb@quicinc.com>
In-Reply-To: <4b778dbcfd1fc40140292166834f13e8d5b8e4d2.1682575115.git.quic_nguyenb@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f2JzcUhmb+5Da3HipIeOCm/DV6RsWMgmZur9P1H/I61zkD0txQzz7cTn0jDx?=
 =?us-ascii?Q?MczzwETnMAmbJX0cou7LsaBp16t5ErVyAyVfO7dAh49eOk8ZydX1uvgD9F/i?=
 =?us-ascii?Q?oHsEW/2jEaibXJ4Ms+8Bo9b5I3p1u0DV3/BWArpFtgTZ1MpAvDhRfeKTvNlI?=
 =?us-ascii?Q?4fy9RIRn6jaEcGx3g2XXWV7UIqLIRWdWgO8HHfKJIFZG7tVQTjd1BQiKAmLq?=
 =?us-ascii?Q?E2/4ok6GRFqet29DnfuelUQmDIBsz6AEetrQ9mDvyBGqDyQMpqOHGPXxXt4E?=
 =?us-ascii?Q?XsJnoPfO+7F/S9N4sREifUA6faHSJsQaRu6QBC1ZnmgXcWSKHfAd1odVKmvq?=
 =?us-ascii?Q?VQcNDwn1XSmYK8s80iquBGEnsmiZRaHtFq6cpl3sk09/mOpXccusqQSEefqv?=
 =?us-ascii?Q?P9tIGNSL17t0mzd1hnOZi/a/bFT2SVqjTnjsgTGlhlpeLoTKbIO6pm7vKnwu?=
 =?us-ascii?Q?4l1JvA2PQQHHV6h+g/KGzPV7EYtdixtyIdN+Z9dc/xtuc9ofdoOEiz2iZ+MN?=
 =?us-ascii?Q?E01mZvLIfquYjgt/MoZGZ87UKhSPco188Tga2aEJ8QVWDseTDznssUBkg0eJ?=
 =?us-ascii?Q?UXxZp3LLORK+zDi51qGb9Ss/DVcC1q4L2EKHzqHluCZfT9tg0r7P01642c9v?=
 =?us-ascii?Q?+FnMdJC7b4iN8tBjZBri3mpPxfn2kEY/vmekju3Rwdbd1yiFdg/6u7uq34kq?=
 =?us-ascii?Q?ui5RgpsZhQXV7wA1NVmtDQbRJRCdrQwAivIfUWOahpSoCTPPHfWg5S6LslUJ?=
 =?us-ascii?Q?P4PrzfLfTiaRdncZdRetedYDDwJQ1EwDXI8+9FjRcqVJj4A9NFDndtMFs+XQ?=
 =?us-ascii?Q?vnQERDHBUtoGeYyvVpKGc44IQ88SVyTSzWB7wFXukHURbKGx+c7/1iQEBeZD?=
 =?us-ascii?Q?7mVB9y6D8jWbOtxnTpfj8WzoiVoCGfgBUcU3XAlFUr37YyhLWQCAimzktOuz?=
 =?us-ascii?Q?SdrODgBvDSgy3a84bVKoIf1ddSiJSu7fGyi6WUoPZNKW4xqFUg3zpd1rdqTg?=
 =?us-ascii?Q?4z7Lj00JhzbObSaG/qSh2Q2jNDGEOl5CD2DIdQTP3y6BB4slqcjQfnu2AW2T?=
 =?us-ascii?Q?4df3JmpB7Yt4lg4vmnRedkR+/8YW+SZZiHA5A209H/XFXo4KybyfGMP9ErSC?=
 =?us-ascii?Q?QhKvchb/2FtxqMUUuaL7GxhKP18Wk/V2NigXqNFEqdFTe0ro6rDToxjAZuIO?=
 =?us-ascii?Q?GYes+R+eNCoQuG4DDMmVyLExIzJb04VM+N0thS0Jg//QGZUZMGDJtez0mkyj?=
 =?us-ascii?Q?QP/1IgwCvQaxoMy14eUAZUjtXhKp+VuYOrNuQOnLiXpgvLoVltC5zYicf2Yz?=
 =?us-ascii?Q?UyK0HNarfzy4Q44r5KoD1jyETcP7kugw1Vc0Khr9WSyC9DdeCT8e4blc3FrT?=
 =?us-ascii?Q?pYM5jjpkcgPiEGU4mr3fBo03gaBVSa5Dwsbk0IHcgHR00IL4DxfFm54UGbZo?=
 =?us-ascii?Q?E5yCqqJCZJtjOruOkCw4jPH+lYTbudxX+QxLL083dHqeALS+V6XaYDWVvQwu?=
 =?us-ascii?Q?PtO3Rqz9lXWadS2RhpJ6sBlUVIbbVpCrKrit+xmCpNNNyc6hl8hq4qdxP51A?=
 =?us-ascii?Q?SPQ+f4vVG1oLwgxllP7hwqfa54NiGZefsJ7vnmL9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?jvZAl5N3rZ2TDSKo1cDWWsuuOi+lHjjd6OiuXmEpqdgZttyPs2WQjtu/gumW?=
 =?us-ascii?Q?utkcmvmuZjEu6kbIsW3Sgx2cibw6ojPouMz5EbAANmPDIu7mZoC1fKFeSCi8?=
 =?us-ascii?Q?cvaTW1W85MeC6jWGaxHwEpTk9Zoud213n4MgRBgw8/8FZzLdngBLjxVEhhhx?=
 =?us-ascii?Q?GlLkS8A3in2KdcHlVsDkoG0ElcuEmIgp5xba86g3XF3Iwe+OAHH49Q5Ei5vB?=
 =?us-ascii?Q?nS/gxqxP/ciSFVHTXeYsx2PS2EwhU7YqU3XShD1TOiODI9MXwBCJeyVizLmr?=
 =?us-ascii?Q?XdgFnlKWMu1FejJZA2Aem4zCj0GmJAvESGwRr+LTId1dV+skd75+n7wLZXjT?=
 =?us-ascii?Q?aIK0SKK4YGqY7dCDoM2ehuEid9MLTS7tST3Z6FjWhb7bgPiQBlv3d6WnoyAw?=
 =?us-ascii?Q?OyyVF4LuwhdCClVaBs6tecgCizNCNS/6tlHLh4sTBLLGaqiN+RYOoKODID9F?=
 =?us-ascii?Q?XMd1dcafJduwPHlNxCv0rOFFRZbDPhkB6i5EkBRWeENlqaGSDLLh94KU0d5c?=
 =?us-ascii?Q?toqWutpW+vObb1fQVbQiTSgtmYKjTnQismV1mGVas7qgNLJhwEoC/jcmTUMe?=
 =?us-ascii?Q?c2JrOdfjwWNDqYNfbgPt9pgFBGcIo154u7t72uTRaEPXNxaIY3TM070JPxq4?=
 =?us-ascii?Q?9oiAUOij5WqHtKHmVN1tGaJqrHJEu4aq3CB4wD5TdIsZwmP/Ta1o3igrTwif?=
 =?us-ascii?Q?JL8zHxXKWXueoVY5M2DnZqK7VvUQ9DAgE7by50HPDr6439dQfgUd6ZmDpRa3?=
 =?us-ascii?Q?cqfeWpMl5KBqExP/VwPK7Ci+8rWOu6RvJF3Qwb5fTm2rekjXMcbxPKk90jC5?=
 =?us-ascii?Q?yubk+LfvFmD4fzzZYHxcYrt6Zi1+TdGtaEg1OmOur/fRM1huY/xqiRhO//3o?=
 =?us-ascii?Q?ozgBpsE358nyHYbKhry07H78OUBzebnyRwNRnpmVZH5ZbiWhq8ffB3+9doCK?=
 =?us-ascii?Q?1eG0/5iuAPii/f3M8Z7/eQZz5UudD8PAtAwzgZxy/c54fZmzr0WlE2GdtcLp?=
 =?us-ascii?Q?ODf/s+jeRd2vDMTarTZqN5igMjp3IqVH5mlK7O3/xIi36dU=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f927cfa2-9999-49f3-5c39-08db4705cf17
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 09:57:27.7564
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X727XTaRVX3NfZGS0NouEcL/+KLGcfkDCcwoXrpYvkczE/3RmEiEn1oryrz1fwcX6fG9AHhGy3HTchzXLUzsLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR04MB7996
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> When allocating memory for the UTP Command Descriptor
> hba->ucdl_base_addr in ufshcd_memory_alloc(), the macro
> sizeof_utp_transfer_cmd_desc() is used to calculate the size of the memor=
y
> allocation. This macro includes the prd_table as part of the UTP Command
> Descriptor memory. However, when freeing this memory in the
> ufshcd_release_sdb_queue(), the sizeof(struct utp_transfer_cmd_desc) is
> used, and it does not include the prd_table size for the memory to be fre=
ed.
> This results in a mismatch of memory size allocated/freed.
>=20
> Similarly, the ufshcd_mcq_get_tag() incorrectly uses the sizeof(struct
> utp_transfer_cmd_desc) to find the tag number.
> This results in failing to probe.
>=20
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Looks like this fix is suggested here as well -
https://www.spinics.net/lists/linux-scsi/msg184092.html

Thanks,
Avri

> ---
>  drivers/ufs/core/ufs-mcq.c | 2 +-
>  drivers/ufs/core/ufshcd.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c inde=
x
> 202ff71..b7c5f39 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -265,7 +265,7 @@ static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
>         addr =3D (le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA) =
-
>                 hba->ucdl_dma_addr;
>=20
> -       return div_u64(addr, sizeof(struct utp_transfer_cmd_desc));
> +       return div_u64(addr, sizeof_utp_transfer_cmd_desc(hba));
>  }
>=20
>  static void ufshcd_mcq_process_cqe(struct ufs_hba *hba, diff --git
> a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 9434328..b009e55 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8444,7 +8444,7 @@ static void ufshcd_release_sdb_queue(struct
> ufs_hba *hba, int nutrs)  {
>         size_t ucdl_size, utrdl_size;
>=20
> -       ucdl_size =3D sizeof(struct utp_transfer_cmd_desc) * nutrs;
> +       ucdl_size =3D sizeof_utp_transfer_cmd_desc(hba) * nutrs;
>         dmam_free_coherent(hba->dev, ucdl_size, hba->ucdl_base_addr,
>                            hba->ucdl_dma_addr);
>=20
> --
> 2.7.4