Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 11:15:16 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Song Shuai <suagrfillet@gmail.com>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <alexghiti@rivosinc.com>,
        <heiko@sntech.de>, <guoren@kernel.org>,
        <anshuman.khandual@arm.com>, <mick@ics.forth.gr>,
        <samuel@sholland.org>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -fixes V2] riscv: mm: remove redundant parameter of
 create_fdt_early_page_table
Message-ID: <20230427-prevail-upload-033ca439a54c@wendy>
References: <20230426100009.685435-1-suagrfillet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2zFe0gN+LmyYDnho"
Content-Disposition: inline
In-Reply-To: <20230426100009.685435-1-suagrfillet@gmail.com>
Precedence: bulk

--2zFe0gN+LmyYDnho
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 26, 2023 at 06:00:09PM +0800, Song Shuai wrote:
> create_fdt_early_page_table() explicitly uses early_pg_dir for
> 32-bit fdt mapping and the pgdir parameter is redundant here.
> So remove it and its caller.
>=20
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Signed-off-by: Song Shuai <suagrfillet@gmail.com>

Whoops, I missed the v2, so copy-pasting:

"and its caller" sounds like you're removing the caller itself when
that's not what you're doing!
I am certainly not suggesting that you resubmit because of that though.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Automation failed to apply this which is a bit weird. What was the
base-commit?

Cheers,
Conor.

> ---
> Changes in V1:
> https://lore.kernel.org/linux-riscv/83540cb1-0c9b-f572-849a-cb100437d049@=
ghiti.fr/T/#t
> - fix the typo
> ---
>  arch/riscv/mm/init.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 0f14f4a8d179..6ebb75a9a6b9 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -843,8 +843,7 @@ static void __init create_kernel_page_table(pgd_t *pg=
dir, bool early)
>   * this means 2 PMD entries whereas for 32-bit kernel, this is only 1 PG=
DIR
>   * entry.
>   */
> -static void __init create_fdt_early_page_table(pgd_t *pgdir,
> -					       uintptr_t fix_fdt_va,
> +static void __init create_fdt_early_page_table(uintptr_t fix_fdt_va,
>  					       uintptr_t dtb_pa)
>  {
>  	uintptr_t pa =3D dtb_pa & ~(PMD_SIZE - 1);
> @@ -1034,8 +1033,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
>  	create_kernel_page_table(early_pg_dir, true);
> =20
>  	/* Setup early mapping for FDT early scan */
> -	create_fdt_early_page_table(early_pg_dir,
> -				    __fix_to_virt(FIX_FDT), dtb_pa);
> +	create_fdt_early_page_table(__fix_to_virt(FIX_FDT), dtb_pa);
> =20
>  	/*
>  	 * Bootime fixmap only can handle PMD_SIZE mapping. Thus, boot-ioremap
> --=20
> 2.20.1
>=20

--2zFe0gN+LmyYDnho
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZEpLNAAKCRB4tDGHoIJi
0pEgAQD3m31cs3VtahRPXPTCH4i1LIzufQcpRdG6aAOc1Juk7wD5AR62nuAwA3MQ
MSz1apHcc5OiNw5Q8BSkobIIDdksPQs=
=PAQy
-----END PGP SIGNATURE-----

--2zFe0gN+LmyYDnho--