Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Apr 2023 11:11:22 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Song Shuai <suagrfillet@gmail.com>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <alexghiti@rivosinc.com>,
        <heiko@sntech.de>, <guoren@kernel.org>,
        <anshuman.khandual@arm.com>, <mick@ics.forth.gr>,
        <samuel@sholland.org>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -fixes] riscv: mm: remove redundant parameter of
 create_fdt_early_page_table
Message-ID: <20230427-lecturer-goon-a7c1245fa2bb@wendy>
References: <20230426091511.674496-1-suagrfillet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="B4nDN1w4sHZ1Joe6"
Content-Disposition: inline
In-Reply-To: <20230426091511.674496-1-suagrfillet@gmail.com>
Precedence: bulk

--B4nDN1w4sHZ1Joe6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 26, 2023 at 05:15:11PM +0800, Song Shuai wrote:
> create_fdt_early_page_table() explicitly uses early_pg_dir for
> 32-bit ftb mapping and the pgdir parameter is redundant here.
> So remove it and its caller.

"and its caller" sounds like you're removing the caller itself when
that's not what you're doing!
I am certainly not suggesting that you resubmit because of that though.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--B4nDN1w4sHZ1Joe6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZEpKSgAKCRB4tDGHoIJi
0tdyAP9IYmb79WDRFsH48lzLc2Tk5z6eDoSPuuP8mLa3KlnjRQEAjzhtySq7Mq/m
xlkT1FzflYgXZJShfdRO0yJ6DEQL/Qw=
=2zWl
-----END PGP SIGNATURE-----

--B4nDN1w4sHZ1Joe6--