Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <406dbcfb-7a08-8067-d717-3472e42e19e6@roeck-us.net>
Date:   Thu, 27 Apr 2023 03:32:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] hwmon: (max597x) Add Maxim Max597x
Content-Language: en-US
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
References: <20230426090356.745979-1-Naresh.Solanki@9elements.com>
 <2579ed08-b21d-489e-8a40-8310efdfa1c4@roeck-us.net>
 <5104bcd2-4203-e4f3-ac58-310fa4d45c7b@9elements.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <5104bcd2-4203-e4f3-ac58-310fa4d45c7b@9elements.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/27/23 02:50, Naresh Solanki wrote:
> Hi Guenter,
> 
[ ... ]

>> Again, I think it would make much more sense to add hwmon support
>> to the regulator driver than having a separate driver since there
>> is lots of overlap. For example, the regulator driver already
>> sets and monitors limits.
> I agree. But the chip also has led functionality. I got review feedback to make it MFD. So when rewriting as MFD driver made separate driver based on subsystem. I'm not sure if it is ok to use hwmon subsytem in regulator driver. Will once check with maintainer on this.

LED has completely different functionality. Overlap between regulator and
hwmon is substantial because the regulator code handles limits and alarms.
Sure, you kind of bypassed (ignored) that by not implementing limit and alarm
support in the hwmon driver, but that is really just avoiding the problem,
not solving it.

Guenter