Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e61385de6044932aabfc407ed8bc368f7e9631f.camel@kernel.org>
Subject: Re: [PATCH] tpm: Re-enable TPM chip boostrapping non-tpm_tis TPM
 drivers
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Pengfei Xu <pengfei.xu@intel.com>
Cc:     linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        linux-kernel@vger.kernel.org, heng.su@intel.com
Date:   Thu, 27 Apr 2023 14:12:47 +0300
In-Reply-To: <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org>
References: <20230426185833.289868-1-jarkko@kernel.org>
         <ZEnWykDF6kbZ8nVi@xpf.sh.intel.com>
         <a258fcd353d67e918a0c86a59e27bf1332764a7b.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.0-1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-04-27 at 13:52 +0300, Jarkko Sakkinen wrote:
> On Thu, 2023-04-27 at 09:58 +0800, Pengfei Xu wrote:
> > On 2023-04-26 at 21:58:33 +0300, Jarkko Sakkinen wrote:
> > > TPM chip bootstrapping was removed from tpm_chip_register(), and it
> > > was relocated to tpm_tis_core. This breaks all drivers which are not
> > > based on tpm_tis because the chip will not get properly initialized.
> > >=20
> > > Take the corrective steps:
> > > 1. Rename tpm_chip_startup() as tpm_chip_bootstrap() and make it one-=
shot.
> > > 2. Call tpm_chip_bootstrap() in tpm_chip_register(), which reverts th=
e
> > >    things  as tehy used to be.
> >            ^ two space and one typo "they"
> > 	   Thanks for your fixed patch in short time!
> >=20
> >   And I tested this patch, it could not be reproduced in 155s, and the =
patch
> >   fixed this issue.
> >   Fixed dmesg is in attached.
> >=20
> > Tested-by: Pengfei Xu <pengfei.xu@intel.com>
>=20
> Thanks a lot! I'll take immediate action to send PR to Linus.
>=20
> Lino: no worries. It was expected that such a large refactorization
> could break a thing or two. You did a good job in any case.

Done: https://lkml.org/lkml/2023/4/27/297

BR, Jarkko