Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca738971-036b-f180-88f7-cefe0ed5a412@quicinc.com>
Date:   Thu, 27 Apr 2023 16:37:11 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <richardcochran@gmail.com>, <manivannan.sadhasivam@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <1682327030-25535-1-git-send-email-quic_rohiagar@quicinc.com>
 <1682327030-25535-3-git-send-email-quic_rohiagar@quicinc.com>
 <ZEk9lySMZcrRZYwX@surfacebook>
 <66158251-6934-a07f-4b82-4deaa76fa482@quicinc.com>
 <CAHp75VcCAOD3utLjjXeQ97nGcUTm7pic5F52+e7cJDxpDXwttA@mail.gmail.com>
 <1ed28be7-7bb5-acc5-c955-f4cf238ffc49@quicinc.com>
 <CAHp75VcDBFyG9+RaOUma4y+Q0em2-Nvuk_71vDkenGk+2HJqEQ@mail.gmail.com>
From:   Rohit Agarwal <quic_rohiagar@quicinc.com>
In-Reply-To: <CAHp75VcDBFyG9+RaOUma4y+Q0em2-Nvuk_71vDkenGk+2HJqEQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/27/2023 4:24 PM, Andy Shevchenko wrote:
> On Thu, Apr 27, 2023 at 11:53 AM Rohit Agarwal
> <quic_rohiagar@quicinc.com> wrote:
>> On 4/26/2023 10:12 PM, Andy Shevchenko wrote:
>>> On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
>>>> On 4/26/2023 8:34 PM, andy.shevchenko@gmail.com wrote:
> ...
>
>>>> Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
>>> Yes, please.
>> PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple
>> other fields that needs to be set
>> for each pingroup defined.
>> Would rename this to SDX75_PINGROUP, as seen on some other platforms.
>> Would that be ok?
> For this patch, yes. But can you create a separate followup that
> replaces three members of struct msm_pingroup by embedding struct
> pingroup into it? There are examples of such changes in the kernel
> already. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/drivers/pinctrl?id=39b707fa7aba7cbfd7d53be50b6098e620f7a6d4
>
Sure, create a separate followup patch referring it. Will use 
SDX75_PINGROUP for now.
Thanks,
Rohit.